From: "Jernej Škrabec" <jernej.skrabec@gmail.com>
To: "Jassi Brar" <jassisinghbrar@gmail.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Chen-Yu Tsai <wens@csie.org>,
Samuel Holland <samuel@sholland.org>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev, kernel@pengutronix.de
Subject: Re: [PATCH 10/12] mailbox: sun6i-msgbox: Convert to platform remove callback returning void
Date: Tue, 09 Jan 2024 21:15:52 +0100 [thread overview]
Message-ID: <3783111.kQq0lBPeGt@jernej-laptop> (raw)
In-Reply-To: <2db7ef94aa35587980697405ec373e0b7bb70466.1703710628.git.u.kleine-koenig@pengutronix.de>
Dne sreda, 27. december 2023 ob 22:02:38 CET je Uwe Kleine-König napisal(a):
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is ignored (apart
> from emitting a warning) and this typically results in resource leaks.
>
> To improve here there is a quest to make the remove callback return
> void. In the first step of this quest all drivers are converted to
> .remove_new(), which already returns void. Eventually after all drivers
> are converted, .remove_new() will be renamed to .remove().
>
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: Jernej Skrabec <jernej.skrabec@gmail.com>
Best regards,
Jernej
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-01-09 20:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-27 21:02 [PATCH 00/12] mailbox: Convert to platform remove callback returning void Uwe Kleine-König
2023-12-27 21:02 ` [PATCH 03/12] mailbox: imx: " Uwe Kleine-König
2023-12-27 21:02 ` [PATCH 05/12] mailbox: mtk-cmdq: " Uwe Kleine-König
2023-12-27 21:02 ` [PATCH 09/12] mailbox: stm32-ipcc: " Uwe Kleine-König
2023-12-27 21:02 ` [PATCH 10/12] mailbox: sun6i-msgbox: " Uwe Kleine-König
2024-01-09 20:15 ` Jernej Škrabec [this message]
2023-12-27 21:02 ` [PATCH 12/12] mailbox: zynqmp-ipi: " Uwe Kleine-König
2024-01-02 9:36 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3783111.kQq0lBPeGt@jernej-laptop \
--to=jernej.skrabec@gmail.com \
--cc=jassisinghbrar@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=samuel@sholland.org \
--cc=u.kleine-koenig@pengutronix.de \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox