public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] arm64: dts: Added syscon-reboot node for FSL's LS2085A SoC
Date: Fri, 30 Oct 2015 20:59:19 +0100	[thread overview]
Message-ID: <3842856.zmPu9RX8Gg@wuerfel> (raw)
In-Reply-To: <CY1PR0301MB07483E9D229314891961B6AD872F0@CY1PR0301MB0748.namprd03.prod.outlook.com>

On Friday 30 October 2015 16:34:26 Stuart Yoder wrote:
> My suggestion is to perhaps make that more explicit in the proposed
> device tree node, by making the reg size "4" and naming it
> as per the register name
> 
>        rstcr: rstcr at 1E60000 {
>                compatible = "syscon";
>                reg = <0x0 0x1E60000 0x0 0x4>;
>        };
> 
> The intent is really just to expose a single reset register
> and use syscon-reboot until PSCI is available.

I would rather see a more specific compatible string here that describes
the actual name, e.g.

	compatible = "fsl,ls2085a-rstcr", "syscon";

this way we have the option of making it a real driver later on by matching
on the specific string, but using the fallback syscon string otherwise.

BTW, please change the address to lowercase letters in both the node name and
the reg property. I would also change the name to 'syscon' instead of 'rstcr',
making that

	rstcr: syscon at 1e60000 {
		...
	};

	Arnd

      reply	other threads:[~2015-10-30 19:59 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-28 21:09 [PATCH v2] arm64: dts: Added syscon-reboot node for FSL's LS2085A SoC J. German Rivera
2015-10-29 21:49 ` Arnd Bergmann
2015-10-30 16:34   ` Stuart Yoder
2015-10-30 19:59     ` Arnd Bergmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3842856.zmPu9RX8Gg@wuerfel \
    --to=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox