* [PATCH] cpufreq: mediatek: fix build error
@ 2015-11-16 21:27 Arnd Bergmann
2015-11-16 22:35 ` Rafael J. Wysocki
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2015-11-16 21:27 UTC (permalink / raw)
To: linux-arm-kernel
The recently added mt8173 cpufreq driver relies on the cpu topology
that is always present on ARM64 but optional on ARM32:
drivers/cpufreq/mt8173-cpufreq.c: In function 'mtk_cpufreq_init':
drivers/cpufreq/mt8173-cpufreq.c:441:30: error: 'cpu_topology' undeclared (first use in this function)
cpumask_copy(policy->cpus, &cpu_topology[policy->cpu].core_sibling);
This refines the Kconfig dependencies so that we can still build on
ARM32, but only if COMPILE_TEST is selected and the CPU topology
code is present.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig.arm
index 1582c1c016b0..8014c2307332 100644
--- a/drivers/cpufreq/Kconfig.arm
+++ b/drivers/cpufreq/Kconfig.arm
@@ -84,6 +84,7 @@ config ARM_KIRKWOOD_CPUFREQ
config ARM_MT8173_CPUFREQ
bool "Mediatek MT8173 CPUFreq support"
depends on ARCH_MEDIATEK && REGULATOR
+ depends on ARM64 || (ARM_CPU_TOPOLOGY && COMPILE_TEST)
depends on !CPU_THERMAL || THERMAL=y
select PM_OPP
help
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] cpufreq: mediatek: fix build error
2015-11-16 21:27 [PATCH] cpufreq: mediatek: fix build error Arnd Bergmann
@ 2015-11-16 22:35 ` Rafael J. Wysocki
0 siblings, 0 replies; 2+ messages in thread
From: Rafael J. Wysocki @ 2015-11-16 22:35 UTC (permalink / raw)
To: linux-arm-kernel
On Monday, November 16, 2015 10:27:55 PM Arnd Bergmann wrote:
> The recently added mt8173 cpufreq driver relies on the cpu topology
> that is always present on ARM64 but optional on ARM32:
>
> drivers/cpufreq/mt8173-cpufreq.c: In function 'mtk_cpufreq_init':
> drivers/cpufreq/mt8173-cpufreq.c:441:30: error: 'cpu_topology' undeclared (first use in this function)
> cpumask_copy(policy->cpus, &cpu_topology[policy->cpu].core_sibling);
>
> This refines the Kconfig dependencies so that we can still build on
> ARM32, but only if COMPILE_TEST is selected and the CPU topology
> code is present.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig.arm
> index 1582c1c016b0..8014c2307332 100644
> --- a/drivers/cpufreq/Kconfig.arm
> +++ b/drivers/cpufreq/Kconfig.arm
> @@ -84,6 +84,7 @@ config ARM_KIRKWOOD_CPUFREQ
> config ARM_MT8173_CPUFREQ
> bool "Mediatek MT8173 CPUFreq support"
> depends on ARCH_MEDIATEK && REGULATOR
> + depends on ARM64 || (ARM_CPU_TOPOLOGY && COMPILE_TEST)
> depends on !CPU_THERMAL || THERMAL=y
> select PM_OPP
> help
>
Applied, thanks!
Rafael
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-11-16 22:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-16 21:27 [PATCH] cpufreq: mediatek: fix build error Arnd Bergmann
2015-11-16 22:35 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox