* [PATCH 0/2] arm64: dts: renesas: Remove renesas, no-ether-link property
@ 2017-12-20 13:22 Vladimir Zapolskiy
2017-12-20 13:22 ` [PATCH 1/2] arm64: dts: renesas: salvator-x: " Vladimir Zapolskiy
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Vladimir Zapolskiy @ 2017-12-20 13:22 UTC (permalink / raw)
To: linux-arm-kernel
The present change is a bug fix for AVB link iteratively up/down.
Steps to reproduce:
- start AVB TX stream (Using aplay via MSE),
- disconnect+reconnect the eth cable,
- after a reconnection the eth connection goes iteratively up/down
without user interaction,
- this may heal after some seconds or even stay for minutes.
As the documentation specifies, the "renesas,no-ether-link" option
should be used when a board does not provide a proper AVB_LINK signal.
There is no need for this option enabled on RCAR H3/M3 Salvator-X/XS
and ULCB starter kits since the AVB_LINK is correctly handled by HW.
Choosing to keep or remove the "renesas,no-ether-link" option will
have impact on the code flow in the following ways:
- keeping this option enabled may lead to unexpected behavior since
the RX & TX are enabled/disabled directly from adjust_link function
without any HW interrogation,
- removing this option, the RX & TX will only be enabled/disabled after
HW interrogation. The HW check is made through the LMON pin in PSR
register which specifies AVB_LINK signal value (0 - at low level;
1 - at high level).
In conclusion, the change is also a safety improvement because it
removes the "renesas,no-ether-link" option leading to a proper way
of detecting the link state based on HW interrogation and not on
software heuristic.
Note that DTS files for V3M Starter Kit, Draak and Eagle boards
contain the same property, the files are untouched due to unavailable
schematics to verify if the fix applies to these boards as well.
Bogdan Mirea (2):
arm64: dts: renesas: salvator-x: Remove renesas,no-ether-link property
arm64: dts: renesas: ulcb: Remove renesas,no-ether-link property
arch/arm64/boot/dts/renesas/salvator-common.dtsi | 1 -
arch/arm64/boot/dts/renesas/ulcb.dtsi | 1 -
2 files changed, 2 deletions(-)
--
2.8.1
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH 1/2] arm64: dts: renesas: salvator-x: Remove renesas, no-ether-link property
2017-12-20 13:22 [PATCH 0/2] arm64: dts: renesas: Remove renesas, no-ether-link property Vladimir Zapolskiy
@ 2017-12-20 13:22 ` Vladimir Zapolskiy
2017-12-20 13:22 ` [PATCH 2/2] arm64: dts: renesas: ulcb: " Vladimir Zapolskiy
2017-12-21 11:28 ` [PATCH 0/2] arm64: dts: renesas: Remove renesas,no-ether-link property Simon Horman
2 siblings, 0 replies; 6+ messages in thread
From: Vladimir Zapolskiy @ 2017-12-20 13:22 UTC (permalink / raw)
To: linux-arm-kernel
From: Bogdan Mirea <Bogdan-Stefan_Mirea@mentor.com>
The present change is a bug fix for AVB link iteratively up/down.
Steps to reproduce:
- start AVB TX stream (Using aplay via MSE),
- disconnect+reconnect the eth cable,
- after a reconnection the eth connection goes iteratively up/down
without user interaction,
- this may heal after some seconds or even stay for minutes.
As the documentation specifies, the "renesas,no-ether-link" option
should be used when a board does not provide a proper AVB_LINK signal.
There is no need for this option enabled on RCAR H3/M3 Salvator-X/XS
and ULCB starter kits since the AVB_LINK is correctly handled by HW.
Choosing to keep or remove the "renesas,no-ether-link" option will
have impact on the code flow in the following ways:
- keeping this option enabled may lead to unexpected behavior since
the RX & TX are enabled/disabled directly from adjust_link function
without any HW interrogation,
- removing this option, the RX & TX will only be enabled/disabled after
HW interrogation. The HW check is made through the LMON pin in PSR
register which specifies AVB_LINK signal value (0 - at low level;
1 - at high level).
In conclusion, the present change is also a safety improvement because
it removes the "renesas,no-ether-link" option leading to a proper way
of detecting the link state based on HW interrogation and not on
software heuristic.
Signed-off-by: Bogdan Mirea <Bogdan-Stefan_Mirea@mentor.com>
Signed-off-by: Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>
---
arch/arm64/boot/dts/renesas/salvator-common.dtsi | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm64/boot/dts/renesas/salvator-common.dtsi b/arch/arm64/boot/dts/renesas/salvator-common.dtsi
index 4e800e933944..c3095bd575d7 100644
--- a/arch/arm64/boot/dts/renesas/salvator-common.dtsi
+++ b/arch/arm64/boot/dts/renesas/salvator-common.dtsi
@@ -255,7 +255,6 @@
&avb {
pinctrl-0 = <&avb_pins>;
pinctrl-names = "default";
- renesas,no-ether-link;
phy-handle = <&phy0>;
status = "okay";
--
2.8.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 2/2] arm64: dts: renesas: ulcb: Remove renesas, no-ether-link property
2017-12-20 13:22 [PATCH 0/2] arm64: dts: renesas: Remove renesas, no-ether-link property Vladimir Zapolskiy
2017-12-20 13:22 ` [PATCH 1/2] arm64: dts: renesas: salvator-x: " Vladimir Zapolskiy
@ 2017-12-20 13:22 ` Vladimir Zapolskiy
2017-12-21 11:28 ` [PATCH 0/2] arm64: dts: renesas: Remove renesas,no-ether-link property Simon Horman
2 siblings, 0 replies; 6+ messages in thread
From: Vladimir Zapolskiy @ 2017-12-20 13:22 UTC (permalink / raw)
To: linux-arm-kernel
From: Bogdan Mirea <Bogdan-Stefan_Mirea@mentor.com>
The present change is a bug fix for AVB link iteratively up/down.
Steps to reproduce:
- start AVB TX stream (Using aplay via MSE),
- disconnect+reconnect the eth cable,
- after a reconnection the eth connection goes iteratively up/down
without user interaction,
- this may heal after some seconds or even stay for minutes.
As the documentation specifies, the "renesas,no-ether-link" option
should be used when a board does not provide a proper AVB_LINK signal.
There is no need for this option enabled on RCAR H3/M3 Salvator-X/XS
and ULCB starter kits since the AVB_LINK is correctly handled by HW.
Choosing to keep or remove the "renesas,no-ether-link" option will
have impact on the code flow in the following ways:
- keeping this option enabled may lead to unexpected behavior since
the RX & TX are enabled/disabled directly from adjust_link function
without any HW interrogation,
- removing this option, the RX & TX will only be enabled/disabled after
HW interrogation. The HW check is made through the LMON pin in PSR
register which specifies AVB_LINK signal value (0 - at low level;
1 - at high level).
In conclusion, the present change is also a safety improvement because
it removes the "renesas,no-ether-link" option leading to a proper way
of detecting the link state based on HW interrogation and not on
software heuristic.
Signed-off-by: Bogdan Mirea <Bogdan-Stefan_Mirea@mentor.com>
Signed-off-by: Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>
---
arch/arm64/boot/dts/renesas/ulcb.dtsi | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm64/boot/dts/renesas/ulcb.dtsi b/arch/arm64/boot/dts/renesas/ulcb.dtsi
index be91016e0b48..3e7a6b94e9f8 100644
--- a/arch/arm64/boot/dts/renesas/ulcb.dtsi
+++ b/arch/arm64/boot/dts/renesas/ulcb.dtsi
@@ -145,7 +145,6 @@
&avb {
pinctrl-0 = <&avb_pins>;
pinctrl-names = "default";
- renesas,no-ether-link;
phy-handle = <&phy0>;
status = "okay";
--
2.8.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 0/2] arm64: dts: renesas: Remove renesas,no-ether-link property
2017-12-20 13:22 [PATCH 0/2] arm64: dts: renesas: Remove renesas, no-ether-link property Vladimir Zapolskiy
2017-12-20 13:22 ` [PATCH 1/2] arm64: dts: renesas: salvator-x: " Vladimir Zapolskiy
2017-12-20 13:22 ` [PATCH 2/2] arm64: dts: renesas: ulcb: " Vladimir Zapolskiy
@ 2017-12-21 11:28 ` Simon Horman
2017-12-21 14:57 ` Vladimir Zapolskiy
2 siblings, 1 reply; 6+ messages in thread
From: Simon Horman @ 2017-12-21 11:28 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Dec 20, 2017 at 03:22:10PM +0200, Vladimir Zapolskiy wrote:
> The present change is a bug fix for AVB link iteratively up/down.
If this is a bug please consider including Fixes tags in the patches.
> Steps to reproduce:
> - start AVB TX stream (Using aplay via MSE),
> - disconnect+reconnect the eth cable,
> - after a reconnection the eth connection goes iteratively up/down
> without user interaction,
> - this may heal after some seconds or even stay for minutes.
>
> As the documentation specifies, the "renesas,no-ether-link" option
> should be used when a board does not provide a proper AVB_LINK signal.
> There is no need for this option enabled on RCAR H3/M3 Salvator-X/XS
> and ULCB starter kits since the AVB_LINK is correctly handled by HW.
>
> Choosing to keep or remove the "renesas,no-ether-link" option will
> have impact on the code flow in the following ways:
> - keeping this option enabled may lead to unexpected behavior since
> the RX & TX are enabled/disabled directly from adjust_link function
> without any HW interrogation,
> - removing this option, the RX & TX will only be enabled/disabled after
> HW interrogation. The HW check is made through the LMON pin in PSR
> register which specifies AVB_LINK signal value (0 - at low level;
> 1 - at high level).
>
> In conclusion, the change is also a safety improvement because it
> removes the "renesas,no-ether-link" option leading to a proper way
> of detecting the link state based on HW interrogation and not on
> software heuristic.
>
> Note that DTS files for V3M Starter Kit, Draak and Eagle boards
> contain the same property, the files are untouched due to unavailable
> schematics to verify if the fix applies to these boards as well.
>
> Bogdan Mirea (2):
> arm64: dts: renesas: salvator-x: Remove renesas,no-ether-link property
> arm64: dts: renesas: ulcb: Remove renesas,no-ether-link property
>
> arch/arm64/boot/dts/renesas/salvator-common.dtsi | 1 -
> arch/arm64/boot/dts/renesas/ulcb.dtsi | 1 -
> 2 files changed, 2 deletions(-)
>
> --
> 2.8.1
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 0/2] arm64: dts: renesas: Remove renesas,no-ether-link property
2017-12-21 11:28 ` [PATCH 0/2] arm64: dts: renesas: Remove renesas,no-ether-link property Simon Horman
@ 2017-12-21 14:57 ` Vladimir Zapolskiy
2017-12-22 8:28 ` Simon Horman
0 siblings, 1 reply; 6+ messages in thread
From: Vladimir Zapolskiy @ 2017-12-21 14:57 UTC (permalink / raw)
To: linux-arm-kernel
Hi Simon,
On 12/21/2017 01:28 PM, Simon Horman wrote:
> On Wed, Dec 20, 2017 at 03:22:10PM +0200, Vladimir Zapolskiy wrote:
>> The present change is a bug fix for AVB link iteratively up/down.
>
> If this is a bug please consider including Fixes tags in the patches.
>
would you prefer to get v2 with the Fixes tags added or short replies
to v1 with the requested information?
--
With best wishes,
Vladimir
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 0/2] arm64: dts: renesas: Remove renesas,no-ether-link property
2017-12-21 14:57 ` Vladimir Zapolskiy
@ 2017-12-22 8:28 ` Simon Horman
0 siblings, 0 replies; 6+ messages in thread
From: Simon Horman @ 2017-12-22 8:28 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Dec 21, 2017 at 04:57:58PM +0200, Vladimir Zapolskiy wrote:
> Hi Simon,
>
> On 12/21/2017 01:28 PM, Simon Horman wrote:
> > On Wed, Dec 20, 2017 at 03:22:10PM +0200, Vladimir Zapolskiy wrote:
> >> The present change is a bug fix for AVB link iteratively up/down.
> >
> > If this is a bug please consider including Fixes tags in the patches.
> >
>
> would you prefer to get v2 with the Fixes tags added or short replies
> to v1 with the requested information?
Either way would be fine. I see you have gone ahead and posted v2,
lets roll with that.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-12-22 8:28 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-12-20 13:22 [PATCH 0/2] arm64: dts: renesas: Remove renesas, no-ether-link property Vladimir Zapolskiy
2017-12-20 13:22 ` [PATCH 1/2] arm64: dts: renesas: salvator-x: " Vladimir Zapolskiy
2017-12-20 13:22 ` [PATCH 2/2] arm64: dts: renesas: ulcb: " Vladimir Zapolskiy
2017-12-21 11:28 ` [PATCH 0/2] arm64: dts: renesas: Remove renesas,no-ether-link property Simon Horman
2017-12-21 14:57 ` Vladimir Zapolskiy
2017-12-22 8:28 ` Simon Horman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox