From: Vladimir Murzin <vladimir.murzin@arm.com>
To: Sudeep Holla <sudeep.holla@arm.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: dts: vexpress: use list instead of tuple for mmci interrupts
Date: Tue, 22 Jan 2019 13:36:34 +0000 [thread overview]
Message-ID: <39d7c460-3ead-34a0-75ad-732089cd9ffc@arm.com> (raw)
In-Reply-To: <20190122121850.10120-1-sudeep.holla@arm.com>
On 1/22/19 12:18 PM, Sudeep Holla wrote:
> Vexpress motherboard MMCI requires dedicated interrupts for CMD and PIO,
> which obviously should be expressed as a list. Current form uses tuple
> and it works fine since interrupt-cells equal to 1.
>
> Reported-by: Vladimir Murzin <vladimir.murzin@arm.com>
> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
> ---
> arch/arm/boot/dts/vexpress-v2m-rs1.dtsi | 2 +-
> arch/arm/boot/dts/vexpress-v2m.dtsi | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/vexpress-v2m-rs1.dtsi b/arch/arm/boot/dts/vexpress-v2m-rs1.dtsi
> index a9569d15de41..d3963e9eaf48 100644
> --- a/arch/arm/boot/dts/vexpress-v2m-rs1.dtsi
> +++ b/arch/arm/boot/dts/vexpress-v2m-rs1.dtsi
> @@ -133,7 +133,7 @@
> mmci@50000 {
> compatible = "arm,pl180", "arm,primecell";
> reg = <0x050000 0x1000>;
> - interrupts = <9 10>;
> + interrupts = <9>, <10>;
> cd-gpios = <&v2m_mmc_gpios 0 0>;
> wp-gpios = <&v2m_mmc_gpios 1 0>;
> max-frequency = <12000000>;
> diff --git a/arch/arm/boot/dts/vexpress-v2m.dtsi b/arch/arm/boot/dts/vexpress-v2m.dtsi
> index fd42e1194179..798c97aff7fa 100644
> --- a/arch/arm/boot/dts/vexpress-v2m.dtsi
> +++ b/arch/arm/boot/dts/vexpress-v2m.dtsi
> @@ -133,7 +133,7 @@
> mmci@5000 {
> compatible = "arm,pl180", "arm,primecell";
> reg = <0x05000 0x1000>;
> - interrupts = <9 10>;
> + interrupts = <9>, <10>;
> cd-gpios = <&v2m_mmc_gpios 0 0>;
> wp-gpios = <&v2m_mmc_gpios 1 0>;
> max-frequency = <12000000>;
> --
> 2.17.1
>
>
FWIW
Reviewed-by: Vladimir Murzin <vladimir.murzin@arm.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-01-22 13:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-22 12:18 [PATCH] ARM: dts: vexpress: use list instead of tuple for mmci interrupts Sudeep Holla
2019-01-22 13:36 ` Vladimir Murzin [this message]
2019-01-22 13:49 ` Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=39d7c460-3ead-34a0-75ad-732089cd9ffc@arm.com \
--to=vladimir.murzin@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox