* [PATCH] ARM: dts: vexpress: use list instead of tuple for mmci interrupts
@ 2019-01-22 12:18 Sudeep Holla
2019-01-22 13:36 ` Vladimir Murzin
0 siblings, 1 reply; 3+ messages in thread
From: Sudeep Holla @ 2019-01-22 12:18 UTC (permalink / raw)
To: linux-arm-kernel; +Cc: Vladimir Murzin, Sudeep Holla
Vexpress motherboard MMCI requires dedicated interrupts for CMD and PIO,
which obviously should be expressed as a list. Current form uses tuple
and it works fine since interrupt-cells equal to 1.
Reported-by: Vladimir Murzin <vladimir.murzin@arm.com>
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
---
arch/arm/boot/dts/vexpress-v2m-rs1.dtsi | 2 +-
arch/arm/boot/dts/vexpress-v2m.dtsi | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/vexpress-v2m-rs1.dtsi b/arch/arm/boot/dts/vexpress-v2m-rs1.dtsi
index a9569d15de41..d3963e9eaf48 100644
--- a/arch/arm/boot/dts/vexpress-v2m-rs1.dtsi
+++ b/arch/arm/boot/dts/vexpress-v2m-rs1.dtsi
@@ -133,7 +133,7 @@
mmci@50000 {
compatible = "arm,pl180", "arm,primecell";
reg = <0x050000 0x1000>;
- interrupts = <9 10>;
+ interrupts = <9>, <10>;
cd-gpios = <&v2m_mmc_gpios 0 0>;
wp-gpios = <&v2m_mmc_gpios 1 0>;
max-frequency = <12000000>;
diff --git a/arch/arm/boot/dts/vexpress-v2m.dtsi b/arch/arm/boot/dts/vexpress-v2m.dtsi
index fd42e1194179..798c97aff7fa 100644
--- a/arch/arm/boot/dts/vexpress-v2m.dtsi
+++ b/arch/arm/boot/dts/vexpress-v2m.dtsi
@@ -133,7 +133,7 @@
mmci@5000 {
compatible = "arm,pl180", "arm,primecell";
reg = <0x05000 0x1000>;
- interrupts = <9 10>;
+ interrupts = <9>, <10>;
cd-gpios = <&v2m_mmc_gpios 0 0>;
wp-gpios = <&v2m_mmc_gpios 1 0>;
max-frequency = <12000000>;
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] ARM: dts: vexpress: use list instead of tuple for mmci interrupts
2019-01-22 12:18 [PATCH] ARM: dts: vexpress: use list instead of tuple for mmci interrupts Sudeep Holla
@ 2019-01-22 13:36 ` Vladimir Murzin
2019-01-22 13:49 ` Sudeep Holla
0 siblings, 1 reply; 3+ messages in thread
From: Vladimir Murzin @ 2019-01-22 13:36 UTC (permalink / raw)
To: Sudeep Holla, linux-arm-kernel
On 1/22/19 12:18 PM, Sudeep Holla wrote:
> Vexpress motherboard MMCI requires dedicated interrupts for CMD and PIO,
> which obviously should be expressed as a list. Current form uses tuple
> and it works fine since interrupt-cells equal to 1.
>
> Reported-by: Vladimir Murzin <vladimir.murzin@arm.com>
> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
> ---
> arch/arm/boot/dts/vexpress-v2m-rs1.dtsi | 2 +-
> arch/arm/boot/dts/vexpress-v2m.dtsi | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/vexpress-v2m-rs1.dtsi b/arch/arm/boot/dts/vexpress-v2m-rs1.dtsi
> index a9569d15de41..d3963e9eaf48 100644
> --- a/arch/arm/boot/dts/vexpress-v2m-rs1.dtsi
> +++ b/arch/arm/boot/dts/vexpress-v2m-rs1.dtsi
> @@ -133,7 +133,7 @@
> mmci@50000 {
> compatible = "arm,pl180", "arm,primecell";
> reg = <0x050000 0x1000>;
> - interrupts = <9 10>;
> + interrupts = <9>, <10>;
> cd-gpios = <&v2m_mmc_gpios 0 0>;
> wp-gpios = <&v2m_mmc_gpios 1 0>;
> max-frequency = <12000000>;
> diff --git a/arch/arm/boot/dts/vexpress-v2m.dtsi b/arch/arm/boot/dts/vexpress-v2m.dtsi
> index fd42e1194179..798c97aff7fa 100644
> --- a/arch/arm/boot/dts/vexpress-v2m.dtsi
> +++ b/arch/arm/boot/dts/vexpress-v2m.dtsi
> @@ -133,7 +133,7 @@
> mmci@5000 {
> compatible = "arm,pl180", "arm,primecell";
> reg = <0x05000 0x1000>;
> - interrupts = <9 10>;
> + interrupts = <9>, <10>;
> cd-gpios = <&v2m_mmc_gpios 0 0>;
> wp-gpios = <&v2m_mmc_gpios 1 0>;
> max-frequency = <12000000>;
> --
> 2.17.1
>
>
FWIW
Reviewed-by: Vladimir Murzin <vladimir.murzin@arm.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] ARM: dts: vexpress: use list instead of tuple for mmci interrupts
2019-01-22 13:36 ` Vladimir Murzin
@ 2019-01-22 13:49 ` Sudeep Holla
0 siblings, 0 replies; 3+ messages in thread
From: Sudeep Holla @ 2019-01-22 13:49 UTC (permalink / raw)
To: Vladimir Murzin; +Cc: linux-arm-kernel, Sudeep Holla
On Tue, Jan 22, 2019 at 01:36:34PM +0000, Vladimir Murzin wrote:
> On 1/22/19 12:18 PM, Sudeep Holla wrote:
> > Vexpress motherboard MMCI requires dedicated interrupts for CMD and PIO,
> > which obviously should be expressed as a list. Current form uses tuple
> > and it works fine since interrupt-cells equal to 1.
> >
> > Reported-by: Vladimir Murzin <vladimir.murzin@arm.com>
> > Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
> >
>
> FWIW
>
> Reviewed-by: Vladimir Murzin <vladimir.murzin@arm.com>
Thanks.
--
Regards,
Sudeep
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-01-22 13:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-01-22 12:18 [PATCH] ARM: dts: vexpress: use list instead of tuple for mmci interrupts Sudeep Holla
2019-01-22 13:36 ` Vladimir Murzin
2019-01-22 13:49 ` Sudeep Holla
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox