* [PATCH] usb: phy: mxs: silence EPROBE_DEFER error on boot
@ 2025-02-03 6:09 Dominique Martinet
2025-02-03 6:19 ` Christophe JAILLET
2025-02-03 6:23 ` Christophe JAILLET
0 siblings, 2 replies; 3+ messages in thread
From: Dominique Martinet @ 2025-02-03 6:09 UTC (permalink / raw)
To: Greg Kroah-Hartman, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam
Cc: linux-usb, imx, linux-arm-kernel, linux-kernel,
Dominique Martinet
Use dev_err_probe to silence EPROBE_DEFER error on boot on i.MX8ULP:
[ 0.127301] mxs_phy 29910000.usb-phy: can't get the clock, err=-517
Signed-off-by: Dominique Martinet <dominique.martinet@atmark-techno.com>
---
drivers/usb/phy/phy-mxs-usb.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/usb/phy/phy-mxs-usb.c b/drivers/usb/phy/phy-mxs-usb.c
index 7490f1798b461c39c29bb74e1e57e0a4adce2bd7..dd2b4a5633934e257e792bbd61d6748304b5e679 100644
--- a/drivers/usb/phy/phy-mxs-usb.c
+++ b/drivers/usb/phy/phy-mxs-usb.c
@@ -770,9 +770,8 @@ static int mxs_phy_probe(struct platform_device *pdev)
clk = devm_clk_get(&pdev->dev, NULL);
if (IS_ERR(clk)) {
- dev_err(&pdev->dev,
+ return dev_err_probe(&pdev->dev, PTR_ERR(clk),
"can't get the clock, err=%ld", PTR_ERR(clk));
- return PTR_ERR(clk);
}
mxs_phy = devm_kzalloc(&pdev->dev, sizeof(*mxs_phy), GFP_KERNEL);
---
base-commit: 2014c95afecee3e76ca4a56956a936e23283f05b
change-id: 20250203-defer_usb2-ee26f66a01ad
Best regards,
--
Dominique Martinet <dominique.martinet@atmark-techno.com>
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] usb: phy: mxs: silence EPROBE_DEFER error on boot
2025-02-03 6:09 [PATCH] usb: phy: mxs: silence EPROBE_DEFER error on boot Dominique Martinet
@ 2025-02-03 6:19 ` Christophe JAILLET
2025-02-03 6:23 ` Christophe JAILLET
1 sibling, 0 replies; 3+ messages in thread
From: Christophe JAILLET @ 2025-02-03 6:19 UTC (permalink / raw)
To: dominique.martinet
Cc: festevam, gregkh, imx, kernel, linux-arm-kernel, linux-kernel,
linux-usb, s.hauer, shawnguo
Le 03/02/2025 à 07:09, Dominique Martinet a écrit :
> Use dev_err_probe to silence EPROBE_DEFER error on boot on i.MX8ULP:
> [ 0.127301] mxs_phy 29910000.usb-phy: can't get the clock, err=-517
>
> Signed-off-by: Dominique Martinet <dominique.martinet-9u97MdVgWv6RbxiC3EKwHAC/G2K4zDHf@public.gmane.org>
> ---
> drivers/usb/phy/phy-mxs-usb.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/usb/phy/phy-mxs-usb.c b/drivers/usb/phy/phy-mxs-usb.c
> index 7490f1798b461c39c29bb74e1e57e0a4adce2bd7..dd2b4a5633934e257e792bbd61d6748304b5e679 100644
> --- a/drivers/usb/phy/phy-mxs-usb.c
> +++ b/drivers/usb/phy/phy-mxs-usb.c
> @@ -770,9 +770,8 @@ static int mxs_phy_probe(struct platform_device *pdev)
>
> clk = devm_clk_get(&pdev->dev, NULL);
> if (IS_ERR(clk)) {
> - dev_err(&pdev->dev,
> + return dev_err_probe(&pdev->dev, PTR_ERR(clk),
> "can't get the clock, err=%ld", PTR_ERR(clk));
, err=%ld", PTR_ERR(clk) should be removed now.
The error code will already be added in the message in a human readable way.
Alignment could also be adjusted so that "can't... is still under the (.
CJ
> - return PTR_ERR(clk);
> }
>
> mxs_phy = devm_kzalloc(&pdev->dev, sizeof(*mxs_phy), GFP_KERNEL);
>
> ---
> base-commit: 2014c95afecee3e76ca4a56956a936e23283f05b
> change-id: 20250203-defer_usb2-ee26f66a01ad
>
> Best regards,
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] usb: phy: mxs: silence EPROBE_DEFER error on boot
2025-02-03 6:09 [PATCH] usb: phy: mxs: silence EPROBE_DEFER error on boot Dominique Martinet
2025-02-03 6:19 ` Christophe JAILLET
@ 2025-02-03 6:23 ` Christophe JAILLET
1 sibling, 0 replies; 3+ messages in thread
From: Christophe JAILLET @ 2025-02-03 6:23 UTC (permalink / raw)
To: Dominique Martinet
Cc: festevam, gregkh, imx, kernel, linux-arm-kernel, linux-kernel,
linux-usb, s.hauer, shawnguo
Le 03/02/2025 à 07:09, Dominique Martinet a écrit :
> Use dev_err_probe to silence EPROBE_DEFER error on boot on i.MX8ULP:
> [ 0.127301] mxs_phy 29910000.usb-phy: can't get the clock, err=-517
>
> Signed-off-by: Dominique Martinet <dominique.martinet-9u97MdVgWv6RbxiC3EKwHAC/G2K4zDHf@public.gmane.org>
> ---
> drivers/usb/phy/phy-mxs-usb.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/usb/phy/phy-mxs-usb.c b/drivers/usb/phy/phy-mxs-usb.c
> index 7490f1798b461c39c29bb74e1e57e0a4adce2bd7..dd2b4a5633934e257e792bbd61d6748304b5e679 100644
> --- a/drivers/usb/phy/phy-mxs-usb.c
> +++ b/drivers/usb/phy/phy-mxs-usb.c
> @@ -770,9 +770,8 @@ static int mxs_phy_probe(struct platform_device *pdev)
>
> clk = devm_clk_get(&pdev->dev, NULL);
> if (IS_ERR(clk)) {
> - dev_err(&pdev->dev,
> + return dev_err_probe(&pdev->dev, PTR_ERR(clk),
> "can't get the clock, err=%ld", PTR_ERR(clk));
> - return PTR_ERR(clk);
> }
extra { } can also be removed now that there is only 1 line left.
CJ
>
> mxs_phy = devm_kzalloc(&pdev->dev, sizeof(*mxs_phy), GFP_KERNEL);
>
> ---
> base-commit: 2014c95afecee3e76ca4a56956a936e23283f05b
> change-id: 20250203-defer_usb2-ee26f66a01ad
>
> Best regards,
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-02-03 6:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-02-03 6:09 [PATCH] usb: phy: mxs: silence EPROBE_DEFER error on boot Dominique Martinet
2025-02-03 6:19 ` Christophe JAILLET
2025-02-03 6:23 ` Christophe JAILLET
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox