From: Tengfei Fan <quic_tengfan@quicinc.com>
To: Krzysztof Kozlowski <krzk@kernel.org>,
Georgi Djakov <djakov@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>
Cc: <kernel@quicinc.com>, <linux-arm-msm@vger.kernel.org>,
<linux-pm@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v3 3/3] arm64: defconfig: Enable interconnect for SM4450
Date: Mon, 5 Aug 2024 09:51:16 +0800 [thread overview]
Message-ID: <3d3bd0be-5b8a-4a3f-bc82-cb1b72fc1899@quicinc.com> (raw)
In-Reply-To: <0bc3c40d-f6ec-4db2-ba7d-ad6d3a0c6d38@kernel.org>
On 8/2/2024 3:20 PM, Krzysztof Kozlowski wrote:
> On 01/08/2024 10:54, Tengfei Fan wrote:
>> Add the SM4450 interconnect driver as built-in.
>
> This we see from the diff. Tell us instead: why?
>
> That's a standard requirement for every defconfig change. Damn, for
> every change. Don't say what the diff is saying, unless it is
> non-trivial. Say why you are doing things.
>
> Best regards,
> Krzysztof
>
In the next version of the patch series, I will describe in the comment
message why this config needs to be enabled.
--
Thx and BRs,
Tengfei Fan
next prev parent reply other threads:[~2024-08-05 1:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-01 8:54 [PATCH v3 0/3] interconnect: qcom: Add SM4450 interconnect Tengfei Fan
2024-08-01 8:54 ` [PATCH v3 1/3] dt-bindings: interconnect: Add Qualcomm SM4450 Tengfei Fan
2024-08-02 7:22 ` Krzysztof Kozlowski
2024-08-05 1:46 ` Tengfei Fan
2024-08-01 8:54 ` [PATCH v3 2/3] interconnect: qcom: Add SM4450 interconnect provider driver Tengfei Fan
2024-08-03 4:45 ` kernel test robot
2024-08-01 8:54 ` [PATCH v3 3/3] arm64: defconfig: Enable interconnect for SM4450 Tengfei Fan
2024-08-02 7:20 ` Krzysztof Kozlowski
2024-08-05 1:51 ` Tengfei Fan [this message]
2024-08-02 7:22 ` [PATCH v3 0/3] interconnect: qcom: Add SM4450 interconnect Krzysztof Kozlowski
2024-08-05 1:51 ` Tengfei Fan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3d3bd0be-5b8a-4a3f-bc82-cb1b72fc1899@quicinc.com \
--to=quic_tengfan@quicinc.com \
--cc=catalin.marinas@arm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=djakov@kernel.org \
--cc=kernel@quicinc.com \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=robh@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox