Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Wang, Sen" <sen@ti.com>
To: Moteen Shah <m-shah@ti.com>, <krzk+dt@kernel.org>,
	<robh@kernel.org>, <conor+dt@kernel.org>, <nm@ti.com>,
	<vigneshr@ti.com>, <kristo@kernel.org>
Cc: <devicetree@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>, <u-kumar1@ti.com>,
	<gehariprasath@ti.com>, <y-abhilashchandra@ti.com>
Subject: Re: [PATCH v5 2/2] arm64: dts: ti: Add audio overlay for k3-j721s2-evm
Date: Thu, 28 May 2026 22:09:09 -0500	[thread overview]
Message-ID: <3d958ba0-30b1-461b-aea7-c0bf758a490c@ti.com> (raw)
In-Reply-To: <20260520115603.2662930-3-m-shah@ti.com>

On 5/20/2026 6:56 AM, Moteen Shah wrote:
> From: Jayesh Choudhary <j-choudhary@ti.com>
> 
> Add device tree overlay to enable analog audio support on J721S2-EVM
> using PCM3168A codec connected to McASP4 serializers.
(snip)> +&scm_conf {
> +	#address-cells = <1>;
> +	#size-cells = <1>;
> +
> +	audio_refclk1: clock-controller@42e4 {
> +		compatible = "ti,j721s2-audio-refclk", "ti,am62-audio-refclk";
> +		reg = <0x42e4 0x4>;
> +		clocks = <&k3_clks 157 299>;
> +		assigned-clocks = <&k3_clks 157 299>;
> +		assigned-clock-parents = <&k3_clks 157 328>;
> +		#clock-cells = <0>;
> +	};
> +};

Hi Moteen,

Should the bulk of this scm_conf block go to the SoC-dtsi instead? It 
looks like it could be a part of J721 SoC dtsi, which currently doesn't 
seem to have any audio refclks defined.

Best,
Sen Wang



  reply	other threads:[~2026-05-29  3:21 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-20 11:56 [PATCH v5 0/2] Enable audio support for J721S2 EVM Moteen Shah
2026-05-20 11:56 ` [PATCH v5 1/2] dt-bindings: ti: Update audio-refclk binding and j721e system controller Moteen Shah
2026-05-20 11:56 ` [PATCH v5 2/2] arm64: dts: ti: Add audio overlay for k3-j721s2-evm Moteen Shah
2026-05-29  3:09   ` Wang, Sen [this message]
2026-05-29 15:22     ` Nishanth Menon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3d958ba0-30b1-461b-aea7-c0bf758a490c@ti.com \
    --to=sen@ti.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gehariprasath@ti.com \
    --cc=kristo@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=m-shah@ti.com \
    --cc=nm@ti.com \
    --cc=robh@kernel.org \
    --cc=u-kumar1@ti.com \
    --cc=vigneshr@ti.com \
    --cc=y-abhilashchandra@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox