From: Krzysztof Kozlowski <krzk@kernel.org>
To: "André Draszik" <andre.draszik@linaro.org>
Cc: Alim Akhtar <alim.akhtar@samsung.com>,
Rob Herring <robh@kernel.org>, Conor Dooley <conor+dt@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Peter Griffin <peter.griffin@linaro.org>,
Tudor Ambarus <tudor.ambarus@linaro.org>,
Will McVicker <willmcvicker@google.com>,
kernel-team@android.com, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH v3 02/10] dt-bindings: soc: samsung: exynos-pmu: move gs101-pmu into separate binding
Date: Wed, 22 Oct 2025 08:36:27 +0200 [thread overview]
Message-ID: <3d9c4fe2-72c2-45b2-ad15-8cf5f825e53c@kernel.org> (raw)
In-Reply-To: <20251022-tremendous-literate-markhor-a7b98f@kuoka>
On 22/10/2025 08:34, Krzysztof Kozlowski wrote:
> On Thu, Oct 16, 2025 at 04:58:35PM +0100, André Draszik wrote:
>> The gs101-pmu binding is going to acquire various additional (pattern)
>> properties that don't apply to other PMUs supported by this binding.
>>
>> To enable this, move google,gs101-pmu into a separate binding.
>
> You did not copy all the properties which effectively drops certain
> things from the binding, e.g. clocks, interrupt-controller and maybe
> more. Please list them in commit msg and explain they are not applicable
> to GS101.
>
>>
>> Signed-off-by: André Draszik <andre.draszik@linaro.org>
>>
>> ---
>> v3:
>> - use additionalProperties, not unevaluatedProperties
>> - fix path in $id (Rob)
>> - drop comment around 'select' (Rob)
Ah, and please make the example complete by adding
syscon-reboot/poweroff nodes.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-10-22 6:36 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20251016155848eucas1p193debe70e38b1694bfb250d748f4aa14@eucas1p1.samsung.com>
2025-10-16 15:58 ` [PATCH v3 00/10] pmdomain: samsung: add supoort for Google GS101 André Draszik
2025-10-16 15:58 ` [PATCH v3 01/10] dt-bindings: power: samsung: add google,gs101-pd André Draszik
2025-10-22 6:31 ` Krzysztof Kozlowski
2025-10-16 15:58 ` [PATCH v3 02/10] dt-bindings: soc: samsung: exynos-pmu: move gs101-pmu into separate binding André Draszik
2025-10-22 6:34 ` Krzysztof Kozlowski
2025-10-22 6:36 ` Krzysztof Kozlowski [this message]
2025-10-16 15:58 ` [PATCH v3 03/10] dt-bindings: soc: samsung: gs101-pmu: allow power domains as children André Draszik
2025-10-21 12:59 ` Ulf Hansson
2025-10-21 16:18 ` Krzysztof Kozlowski
2025-10-22 10:03 ` Ulf Hansson
2025-10-22 6:39 ` Krzysztof Kozlowski
2025-10-16 15:58 ` [PATCH v3 04/10] pmdomain: samsung: plug potential memleak during probe André Draszik
2025-10-21 13:54 ` Ulf Hansson
2025-10-16 15:58 ` [PATCH v3 05/10] pmdomain: samsung: convert to using regmap André Draszik
2025-10-16 15:58 ` [PATCH v3 06/10] pmdomain: samsung: convert to regmap_read_poll_timeout() André Draszik
2025-10-21 20:38 ` Marek Szyprowski
2025-10-22 13:45 ` Marek Szyprowski
2025-10-16 15:58 ` [PATCH v3 07/10] pmdomain: samsung: don't hardcode offset for registers to 0 and 4 André Draszik
2025-10-16 15:58 ` [PATCH v3 08/10] pmdomain: samsung: selectively handle enforced sync_state André Draszik
2025-10-22 11:06 ` Ulf Hansson
2025-10-22 18:39 ` Marek Szyprowski
2025-10-23 10:02 ` Ulf Hansson
2025-10-23 12:17 ` Marek Szyprowski
2025-10-23 13:46 ` Ulf Hansson
2025-10-16 15:58 ` [PATCH v3 09/10] pmdomain: samsung: add support for google,gs101-pd André Draszik
2025-10-16 15:58 ` [PATCH v3 10/10] pmdomain: samsung: use dev_err() instead of pr_err() André Draszik
2025-10-17 6:43 ` [PATCH v3 00/10] pmdomain: samsung: add supoort for Google GS101 Marek Szyprowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3d9c4fe2-72c2-45b2-ad15-8cf5f825e53c@kernel.org \
--to=krzk@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=andre.draszik@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel-team@android.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=peter.griffin@linaro.org \
--cc=robh@kernel.org \
--cc=tudor.ambarus@linaro.org \
--cc=ulf.hansson@linaro.org \
--cc=willmcvicker@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox