From: Florian Fainelli <florian.fainelli@broadcom.com>
To: Danesh Petigara <danesh.petigara@broadcom.com>,
mmayer@broadcom.com, krzk@kernel.org
Cc: bcm-kernel-feedback-list@broadcom.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Justin Chen <justin.chen@broadcom.com>,
stable@vger.kernel.org
Subject: Re: [PATCH 2/2] memory: brcmstb_dpfe: Bounds check DCPU-supplied MSG_ARG_COUNT
Date: Wed, 26 Aug 2026 16:07:16 -0700 [thread overview]
Message-ID: <3e5ec697-8f8b-426d-ac11-4c851aa5204a@broadcom.com> (raw)
In-Reply-To: <20260826201500.3000125-3-danesh.petigara@broadcom.com>
On 8/26/26 13:14, Danesh Petigara wrote:
> From: Justin Chen <justin.chen@broadcom.com>
>
> A compromised or buggy DCPU coprocessor can make any user who reads
> world-readable /sys/devices/.../dpfe_info|dpfe_dram trigger a kernel
> stack out-of-bounds read of arbitrary extent. This bounds checks
> chksum_idx against MSG_FIELD_MAX after reading the response from DCPU
> message RAM.
>
> Fixes: 5d06f53d9509 ("memory: brcmstb: dpfe: Compute checksum at __send_command() time")
> Cc: stable@vger.kernel.org
> Signed-off-by: Justin Chen <justin.chen@broadcom.com>
> Assisted-by: Gemini:gemini-3.1-pro-preview cursor
> Signed-off-by: Danesh Petigara <danesh.petigara@broadcom.com>
Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
--
Florian
prev parent reply other threads:[~2026-08-26 23:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-26 20:14 [PATCH 0/2] Harden DPFE driver against buggy/malicious DCPU Danesh Petigara
2026-08-26 20:14 ` [PATCH 1/2] memory: brcmstb_dpfe: Fix out-of-bounds access due to DCPU offset Danesh Petigara
2026-08-26 23:07 ` Florian Fainelli
2026-08-27 6:48 ` Krzysztof Kozlowski
2026-08-27 17:37 ` Florian Fainelli
2026-08-27 21:31 ` Krzysztof Kozlowski
2026-08-28 0:04 ` Danesh Petigara
2026-08-28 0:54 ` Markus Mayer
2026-08-26 20:14 ` [PATCH 2/2] memory: brcmstb_dpfe: Bounds check DCPU-supplied MSG_ARG_COUNT Danesh Petigara
2026-08-26 23:07 ` Florian Fainelli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3e5ec697-8f8b-426d-ac11-4c851aa5204a@broadcom.com \
--to=florian.fainelli@broadcom.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=danesh.petigara@broadcom.com \
--cc=justin.chen@broadcom.com \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmayer@broadcom.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox