* [PATCH] arm64: defconfig: Increase SERIAL_8250_NR_UARTS to 10
@ 2023-12-01 19:12 Heiko Stuebner
2023-12-01 19:57 ` Florian Fainelli
0 siblings, 1 reply; 9+ messages in thread
From: Heiko Stuebner @ 2023-12-01 19:12 UTC (permalink / raw)
To: linux-rockchip; +Cc: linux-arm-kernel, quentin.schulz, heiko, Heiko Stuebner
From: Heiko Stuebner <heiko.stuebner@cherry.de>
Boards using socs like the rk3588 can use up to 10 uarts, so the default
of 4 is way too low. Therefore increase the maximum number to 10.
SERIAL_8250_RUNTIME_UARTS on the other hand describes the number of uart
data structures to prepare before registering them. This option can stay
at its default value of 4 since for one it can be changed via a boot
parameter 8250.nr_uarts but also since
commit 9d86719f8769 ("serial: 8250: Allow using ports higher than SERIAL_8250_RUNTIME_UARTS")
the kernel can register uarts dynamically that are above the
SERIAL_8250_RUNTIME_UARTS threshold.
Signed-off-by: Heiko Stuebner <heiko.stuebner@cherry.de>
---
arch/arm64/configs/defconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index b60aa1f89343..69835dc43d24 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -448,6 +448,7 @@ CONFIG_SERIO_AMBAKMI=y
CONFIG_LEGACY_PTY_COUNT=16
CONFIG_SERIAL_8250=y
CONFIG_SERIAL_8250_CONSOLE=y
+CONFIG_SERIAL_8250_NR_UARTS=10
CONFIG_SERIAL_8250_EXTENDED=y
CONFIG_SERIAL_8250_SHARE_IRQ=y
CONFIG_SERIAL_8250_BCM2835AUX=y
--
2.39.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH] arm64: defconfig: Increase SERIAL_8250_NR_UARTS to 10 2023-12-01 19:12 [PATCH] arm64: defconfig: Increase SERIAL_8250_NR_UARTS to 10 Heiko Stuebner @ 2023-12-01 19:57 ` Florian Fainelli 2023-12-01 20:09 ` Francesco Dolcini 0 siblings, 1 reply; 9+ messages in thread From: Florian Fainelli @ 2023-12-01 19:57 UTC (permalink / raw) To: Heiko Stuebner, linux-rockchip, Francesco Dolcini Cc: linux-arm-kernel, quentin.schulz, Heiko Stuebner +Francesco, On 12/1/23 11:12, Heiko Stuebner wrote: > From: Heiko Stuebner <heiko.stuebner@cherry.de> > > Boards using socs like the rk3588 can use up to 10 uarts, so the default > of 4 is way too low. Therefore increase the maximum number to 10. > > SERIAL_8250_RUNTIME_UARTS on the other hand describes the number of uart > data structures to prepare before registering them. This option can stay > at its default value of 4 since for one it can be changed via a boot > parameter 8250.nr_uarts but also since > commit 9d86719f8769 ("serial: 8250: Allow using ports higher than SERIAL_8250_RUNTIME_UARTS") > > the kernel can register uarts dynamically that are above the > SERIAL_8250_RUNTIME_UARTS threshold. > > Signed-off-by: Heiko Stuebner <heiko.stuebner@cherry.de> There is a competing patch set from Francesco being submitted as well: https://lore.kernel.org/all/20231201171544.1901-1-francesco@dolcini.it/ looks like some coordination is necessary. -- Florian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] arm64: defconfig: Increase SERIAL_8250_NR_UARTS to 10 2023-12-01 19:57 ` Florian Fainelli @ 2023-12-01 20:09 ` Francesco Dolcini 2023-12-01 20:56 ` Heiko Stübner 0 siblings, 1 reply; 9+ messages in thread From: Francesco Dolcini @ 2023-12-01 20:09 UTC (permalink / raw) To: Florian Fainelli, Heiko Stuebner Cc: linux-rockchip, Francesco Dolcini, linux-arm-kernel, quentin.schulz, Heiko Stuebner On Fri, Dec 01, 2023 at 11:57:53AM -0800, Florian Fainelli wrote: > +Francesco, > > On 12/1/23 11:12, Heiko Stuebner wrote: > > From: Heiko Stuebner <heiko.stuebner@cherry.de> > > > > Boards using socs like the rk3588 can use up to 10 uarts, so the default > > of 4 is way too low. Therefore increase the maximum number to 10. Do you have an actual need of 10, e.g. an existing board with 10 uarts enabled supported by the mainline kernel? Just thinking at the last arm64 SoC I am working with it should be 12 if we use this as a metric. > > SERIAL_8250_RUNTIME_UARTS on the other hand describes the number of uart > > data structures to prepare before registering them. This option can stay > > at its default value of 4 since for one it can be changed via a boot > > parameter 8250.nr_uarts but also since > > commit 9d86719f8769 ("serial: 8250: Allow using ports higher than SERIAL_8250_RUNTIME_UARTS") > > > > the kernel can register uarts dynamically that are above the > > SERIAL_8250_RUNTIME_UARTS threshold. > > > > Signed-off-by: Heiko Stuebner <heiko.stuebner@cherry.de> > > There is a competing patch set from Francesco being submitted as well: > https://lore.kernel.org/all/20231201171544.1901-1-francesco@dolcini.it/ > > looks like some coordination is necessary. Yep, thanks Florian. Heiko: should I include your needs in my patch? It looks like these are the days of the 8250 uart, I sent my patch just one day before yours. Francesco _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] arm64: defconfig: Increase SERIAL_8250_NR_UARTS to 10 2023-12-01 20:09 ` Francesco Dolcini @ 2023-12-01 20:56 ` Heiko Stübner 2023-12-01 21:03 ` Heiko Stübner 2023-12-02 11:51 ` Francesco Dolcini 0 siblings, 2 replies; 9+ messages in thread From: Heiko Stübner @ 2023-12-01 20:56 UTC (permalink / raw) To: Florian Fainelli, Francesco Dolcini Cc: linux-rockchip, Francesco Dolcini, linux-arm-kernel, quentin.schulz, Heiko Stuebner Hi, Am Freitag, 1. Dezember 2023, 21:09:29 CET schrieb Francesco Dolcini: > On Fri, Dec 01, 2023 at 11:57:53AM -0800, Florian Fainelli wrote: > > +Francesco, > > > > On 12/1/23 11:12, Heiko Stuebner wrote: > > > From: Heiko Stuebner <heiko.stuebner@cherry.de> > > > > > > Boards using socs like the rk3588 can use up to 10 uarts, so the default > > > of 4 is way too low. Therefore increase the maximum number to 10. > Do you have an actual need of 10, e.g. an existing board with 10 uarts > enabled supported by the mainline kernel? Just thinking at the last arm64 SoC I > am working with it should be 12 if we use this as a metric. The rk3588 can do 10 (0-9), the board I'm working on is using up to uart7 (aka 8 uarts). Reasoning below in the 3rd paragraph. > > > SERIAL_8250_RUNTIME_UARTS on the other hand describes the number of uart > > > data structures to prepare before registering them. This option can stay > > > at its default value of 4 since for one it can be changed via a boot > > > parameter 8250.nr_uarts but also since > > > commit 9d86719f8769 ("serial: 8250: Allow using ports higher than SERIAL_8250_RUNTIME_UARTS") > > > > > > the kernel can register uarts dynamically that are above the > > > SERIAL_8250_RUNTIME_UARTS threshold. > > > > > > Signed-off-by: Heiko Stuebner <heiko.stuebner@cherry.de> > > > > There is a competing patch set from Francesco being submitted as well: > > https://lore.kernel.org/all/20231201171544.1901-1-francesco@dolcini.it/ > > > > looks like some coordination is necessary. Thanks Florian for catching this coincidence. > Yep, thanks Florian. > > Heiko: should I include your needs in my patch? It looks like these are the > days of the 8250 uart, I sent my patch just one day before yours. yeah, I was surprised by the time overlap as well. After reading up on NR_UARTS and NR_RUNTIME_UARTS I opted for going with the maximum possible. From what I understood, increasing the runtime-uart-number would incur overhead in terms of prepared data structures. But the core NR_UARTS only seems to limit the actual maximum number of uarts in the system. With the somewhat recent patch named above, even those can still be registered without bad effects, so I opted with increasing the NR_UARTS to the maximum to expect at some point, least the next board then needs yet another patch. But left the runtime number alone to not create overhead. So TL;DR: I could live with the 8 from your original patch, but I guess would prefer going with a safer value, so the 10 or your 12 from above. Because I guess if a controller is present, someone will use it eventually ;-). Heiko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] arm64: defconfig: Increase SERIAL_8250_NR_UARTS to 10 2023-12-01 20:56 ` Heiko Stübner @ 2023-12-01 21:03 ` Heiko Stübner 2023-12-01 21:12 ` Francesco Dolcini 2023-12-02 11:51 ` Francesco Dolcini 1 sibling, 1 reply; 9+ messages in thread From: Heiko Stübner @ 2023-12-01 21:03 UTC (permalink / raw) To: Florian Fainelli, Francesco Dolcini Cc: linux-rockchip, Francesco Dolcini, linux-arm-kernel, quentin.schulz, Heiko Stuebner Am Freitag, 1. Dezember 2023, 21:56:27 CET schrieb Heiko Stübner: > Hi, > > Am Freitag, 1. Dezember 2023, 21:09:29 CET schrieb Francesco Dolcini: > > On Fri, Dec 01, 2023 at 11:57:53AM -0800, Florian Fainelli wrote: > > > +Francesco, > > > > > > On 12/1/23 11:12, Heiko Stuebner wrote: > > > > From: Heiko Stuebner <heiko.stuebner@cherry.de> > > > > > > > > Boards using socs like the rk3588 can use up to 10 uarts, so the default > > > > of 4 is way too low. Therefore increase the maximum number to 10. > > Do you have an actual need of 10, e.g. an existing board with 10 uarts > > enabled supported by the mainline kernel? Just thinking at the last arm64 SoC I > > am working with it should be 12 if we use this as a metric. > > The rk3588 can do 10 (0-9), the board I'm working on is using up to uart7 (aka 8 uarts). > Reasoning below in the 3rd paragraph. > > > > > > SERIAL_8250_RUNTIME_UARTS on the other hand describes the number of uart > > > > data structures to prepare before registering them. This option can stay > > > > at its default value of 4 since for one it can be changed via a boot > > > > parameter 8250.nr_uarts but also since > > > > commit 9d86719f8769 ("serial: 8250: Allow using ports higher than SERIAL_8250_RUNTIME_UARTS") > > > > > > > > the kernel can register uarts dynamically that are above the > > > > SERIAL_8250_RUNTIME_UARTS threshold. > > > > > > > > Signed-off-by: Heiko Stuebner <heiko.stuebner@cherry.de> > > > > > > There is a competing patch set from Francesco being submitted as well: > > > https://lore.kernel.org/all/20231201171544.1901-1-francesco@dolcini.it/ > > > > > > looks like some coordination is necessary. > > Thanks Florian for catching this coincidence. > > > > Yep, thanks Florian. > > > > Heiko: should I include your needs in my patch? It looks like these are the > > days of the 8250 uart, I sent my patch just one day before yours. > > yeah, I was surprised by the time overlap as well. > > After reading up on NR_UARTS and NR_RUNTIME_UARTS I opted for going with > the maximum possible. > > From what I understood, increasing the runtime-uart-number would incur > overhead in terms of prepared data structures. But the core NR_UARTS > only seems to limit the actual maximum number of uarts in the system. > > With the somewhat recent patch named above, even those can still be > registered without bad effects, so I opted with increasing the NR_UARTS > to the maximum to expect at some point, least the next board then needs > yet another patch. > But left the runtime number alone to not create overhead. > > > So TL;DR: > I could live with the 8 from your original patch, but I guess would prefer > going with a safer value, so the 10 or your 12 from above. > > Because I guess if a controller is present, someone will use it > eventually ;-). and looking at other rk3588 boards the indiedroid-nova actually uses the uart9 (aka the 10th uart) ;-) Also the turing-rk1 and orangepi-5-plus as well. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] arm64: defconfig: Increase SERIAL_8250_NR_UARTS to 10 2023-12-01 21:03 ` Heiko Stübner @ 2023-12-01 21:12 ` Francesco Dolcini 0 siblings, 0 replies; 9+ messages in thread From: Francesco Dolcini @ 2023-12-01 21:12 UTC (permalink / raw) To: Heiko Stübner Cc: Florian Fainelli, Francesco Dolcini, linux-rockchip, Francesco Dolcini, linux-arm-kernel, quentin.schulz, Heiko Stuebner On Fri, Dec 01, 2023 at 10:03:07PM +0100, Heiko Stübner wrote: > Am Freitag, 1. Dezember 2023, 21:56:27 CET schrieb Heiko Stübner: > > Hi, > > > > Am Freitag, 1. Dezember 2023, 21:09:29 CET schrieb Francesco Dolcini: > > > On Fri, Dec 01, 2023 at 11:57:53AM -0800, Florian Fainelli wrote: > > > > +Francesco, > > > > > > > > On 12/1/23 11:12, Heiko Stuebner wrote: > > > > > From: Heiko Stuebner <heiko.stuebner@cherry.de> > > > > > > > > > > Boards using socs like the rk3588 can use up to 10 uarts, so the default > > > > > of 4 is way too low. Therefore increase the maximum number to 10. > > > Do you have an actual need of 10, e.g. an existing board with 10 uarts > > > enabled supported by the mainline kernel? Just thinking at the last arm64 SoC I > > > am working with it should be 12 if we use this as a metric. > > > > The rk3588 can do 10 (0-9), the board I'm working on is using up to uart7 (aka 8 uarts). > > Reasoning below in the 3rd paragraph. > > > > > > > > > SERIAL_8250_RUNTIME_UARTS on the other hand describes the number of uart > > > > > data structures to prepare before registering them. This option can stay > > > > > at its default value of 4 since for one it can be changed via a boot > > > > > parameter 8250.nr_uarts but also since > > > > > commit 9d86719f8769 ("serial: 8250: Allow using ports higher than SERIAL_8250_RUNTIME_UARTS") > > > > > > > > > > the kernel can register uarts dynamically that are above the > > > > > SERIAL_8250_RUNTIME_UARTS threshold. > > > > > > > > > > Signed-off-by: Heiko Stuebner <heiko.stuebner@cherry.de> > > > > > > > > There is a competing patch set from Francesco being submitted as well: > > > > https://lore.kernel.org/all/20231201171544.1901-1-francesco@dolcini.it/ > > > > > > > > looks like some coordination is necessary. > > > > Thanks Florian for catching this coincidence. > > > > > > > Yep, thanks Florian. > > > > > > Heiko: should I include your needs in my patch? It looks like these are the > > > days of the 8250 uart, I sent my patch just one day before yours. > > > > yeah, I was surprised by the time overlap as well. > > > > After reading up on NR_UARTS and NR_RUNTIME_UARTS I opted for going with > > the maximum possible. > > > > From what I understood, increasing the runtime-uart-number would incur > > overhead in terms of prepared data structures. But the core NR_UARTS > > only seems to limit the actual maximum number of uarts in the system. > > > > With the somewhat recent patch named above, even those can still be > > registered without bad effects, so I opted with increasing the NR_UARTS > > to the maximum to expect at some point, least the next board then needs > > yet another patch. > > But left the runtime number alone to not create overhead. > > > > > > So TL;DR: > > I could live with the 8 from your original patch, but I guess would prefer > > going with a safer value, so the 10 or your 12 from above. > > > > Because I guess if a controller is present, someone will use it > > eventually ;-). > > and looking at other rk3588 boards the indiedroid-nova actually > uses the uart9 (aka the 10th uart) ;-) I think this is not relevant. It uses only 2 uart in total, it should just works with the actual config. Francesco _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] arm64: defconfig: Increase SERIAL_8250_NR_UARTS to 10 2023-12-01 20:56 ` Heiko Stübner 2023-12-01 21:03 ` Heiko Stübner @ 2023-12-02 11:51 ` Francesco Dolcini 2023-12-02 12:12 ` Heiko Stübner 1 sibling, 1 reply; 9+ messages in thread From: Francesco Dolcini @ 2023-12-02 11:51 UTC (permalink / raw) To: Heiko Stübner Cc: Florian Fainelli, Francesco Dolcini, linux-rockchip, Francesco Dolcini, linux-arm-kernel, quentin.schulz, Heiko Stuebner On Fri, Dec 01, 2023 at 09:56:27PM +0100, Heiko Stübner wrote: > Hi, > > Am Freitag, 1. Dezember 2023, 21:09:29 CET schrieb Francesco Dolcini: > > On Fri, Dec 01, 2023 at 11:57:53AM -0800, Florian Fainelli wrote: > > > +Francesco, > > > > > > On 12/1/23 11:12, Heiko Stuebner wrote: > > > > From: Heiko Stuebner <heiko.stuebner@cherry.de> > > > > > > > > Boards using socs like the rk3588 can use up to 10 uarts, so the default > > > > of 4 is way too low. Therefore increase the maximum number to 10. > > Do you have an actual need of 10, e.g. an existing board with 10 uarts > > enabled supported by the mainline kernel? Just thinking at the last arm64 SoC I > > am working with it should be 12 if we use this as a metric. > > The rk3588 can do 10 (0-9), the board I'm working on is using up to uart7 (aka 8 uarts). > Reasoning below in the 3rd paragraph. > > > > > > SERIAL_8250_RUNTIME_UARTS on the other hand describes the number of uart > > > > data structures to prepare before registering them. This option can stay > > > > at its default value of 4 since for one it can be changed via a boot > > > > parameter 8250.nr_uarts but also since > > > > commit 9d86719f8769 ("serial: 8250: Allow using ports higher than SERIAL_8250_RUNTIME_UARTS") > > > > > > > > the kernel can register uarts dynamically that are above the > > > > SERIAL_8250_RUNTIME_UARTS threshold. > > > > > > > > Signed-off-by: Heiko Stuebner <heiko.stuebner@cherry.de> > > > > > > There is a competing patch set from Francesco being submitted as well: > > > https://lore.kernel.org/all/20231201171544.1901-1-francesco@dolcini.it/ > > > > > > looks like some coordination is necessary. > > > So TL;DR: > I could live with the 8 from your original patch, but I guess would prefer > going with a safer value, so the 10 or your 12 from above. > > Because I guess if a controller is present, someone will use it > eventually ;-). There was an explicit push back on this approach from Arnd, see https://lore.kernel.org/all/CAK8P3a2VSBvOn1o+q1PYZaQ6LS9U4cz+DZGuDbisHkwNs2dAAw@mail.gmail.com/ I would propose that we stay with my current proposal of 8. Francesco _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] arm64: defconfig: Increase SERIAL_8250_NR_UARTS to 10 2023-12-02 11:51 ` Francesco Dolcini @ 2023-12-02 12:12 ` Heiko Stübner 2023-12-04 9:32 ` Quentin Schulz 0 siblings, 1 reply; 9+ messages in thread From: Heiko Stübner @ 2023-12-02 12:12 UTC (permalink / raw) To: Francesco Dolcini Cc: Florian Fainelli, Francesco Dolcini, linux-rockchip, Francesco Dolcini, linux-arm-kernel, quentin.schulz, Heiko Stuebner Am Samstag, 2. Dezember 2023, 12:51:03 CET schrieb Francesco Dolcini: > On Fri, Dec 01, 2023 at 09:56:27PM +0100, Heiko Stübner wrote: > > Hi, > > > > Am Freitag, 1. Dezember 2023, 21:09:29 CET schrieb Francesco Dolcini: > > > On Fri, Dec 01, 2023 at 11:57:53AM -0800, Florian Fainelli wrote: > > > > +Francesco, > > > > > > > > On 12/1/23 11:12, Heiko Stuebner wrote: > > > > > From: Heiko Stuebner <heiko.stuebner@cherry.de> > > > > > > > > > > Boards using socs like the rk3588 can use up to 10 uarts, so the default > > > > > of 4 is way too low. Therefore increase the maximum number to 10. > > > Do you have an actual need of 10, e.g. an existing board with 10 uarts > > > enabled supported by the mainline kernel? Just thinking at the last arm64 SoC I > > > am working with it should be 12 if we use this as a metric. > > > > The rk3588 can do 10 (0-9), the board I'm working on is using up to uart7 (aka 8 uarts). > > Reasoning below in the 3rd paragraph. > > > > > > > > > SERIAL_8250_RUNTIME_UARTS on the other hand describes the number of uart > > > > > data structures to prepare before registering them. This option can stay > > > > > at its default value of 4 since for one it can be changed via a boot > > > > > parameter 8250.nr_uarts but also since > > > > > commit 9d86719f8769 ("serial: 8250: Allow using ports higher than SERIAL_8250_RUNTIME_UARTS") > > > > > > > > > > the kernel can register uarts dynamically that are above the > > > > > SERIAL_8250_RUNTIME_UARTS threshold. > > > > > > > > > > Signed-off-by: Heiko Stuebner <heiko.stuebner@cherry.de> > > > > > > > > There is a competing patch set from Francesco being submitted as well: > > > > https://lore.kernel.org/all/20231201171544.1901-1-francesco@dolcini.it/ > > > > > > > > looks like some coordination is necessary. > > > > > > So TL;DR: > > I could live with the 8 from your original patch, but I guess would prefer > > going with a safer value, so the 10 or your 12 from above. > > > > Because I guess if a controller is present, someone will use it > > eventually ;-). > > There was an explicit push back on this approach from Arnd, see > https://lore.kernel.org/all/CAK8P3a2VSBvOn1o+q1PYZaQ6LS9U4cz+DZGuDbisHkwNs2dAAw@mail.gmail.com/ aliases really are a matter of difficult discussions ;-) I.e. Krzysztof's argument some days ago was "No, this should be per-board to match board labeling/schematics." https://lore.kernel.org/all/813224c2-398d-4c2d-8909-1839ce63be60@linaro.org/ And on Rockchip socs everyting from soc manual, board schematics down to the description of pin headers use the uart controller number so people will expect uart9 to be ttyS9 on the system as well. > I would propose that we stay with my current proposal of 8. But ok we can go this route, simply as the current board I'm working on only use 8, so I can leave that "fight" to someone else ;-) Heiko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] arm64: defconfig: Increase SERIAL_8250_NR_UARTS to 10 2023-12-02 12:12 ` Heiko Stübner @ 2023-12-04 9:32 ` Quentin Schulz 0 siblings, 0 replies; 9+ messages in thread From: Quentin Schulz @ 2023-12-04 9:32 UTC (permalink / raw) To: Heiko Stübner, Francesco Dolcini Cc: Florian Fainelli, linux-rockchip, Francesco Dolcini, linux-arm-kernel, Heiko Stuebner Hi all, On 12/2/23 13:12, Heiko Stübner wrote: > Am Samstag, 2. Dezember 2023, 12:51:03 CET schrieb Francesco Dolcini: >> On Fri, Dec 01, 2023 at 09:56:27PM +0100, Heiko Stübner wrote: >>> Hi, >>> >>> Am Freitag, 1. Dezember 2023, 21:09:29 CET schrieb Francesco Dolcini: >>>> On Fri, Dec 01, 2023 at 11:57:53AM -0800, Florian Fainelli wrote: >>>>> +Francesco, >>>>> >>>>> On 12/1/23 11:12, Heiko Stuebner wrote: >>>>>> From: Heiko Stuebner <heiko.stuebner@cherry.de> >>>>>> >>>>>> Boards using socs like the rk3588 can use up to 10 uarts, so the default >>>>>> of 4 is way too low. Therefore increase the maximum number to 10. >>>> Do you have an actual need of 10, e.g. an existing board with 10 uarts >>>> enabled supported by the mainline kernel? Just thinking at the last arm64 SoC I >>>> am working with it should be 12 if we use this as a metric. >>> >>> The rk3588 can do 10 (0-9), the board I'm working on is using up to uart7 (aka 8 uarts). >>> Reasoning below in the 3rd paragraph. >>> >>> >>>>>> SERIAL_8250_RUNTIME_UARTS on the other hand describes the number of uart >>>>>> data structures to prepare before registering them. This option can stay >>>>>> at its default value of 4 since for one it can be changed via a boot >>>>>> parameter 8250.nr_uarts but also since >>>>>> commit 9d86719f8769 ("serial: 8250: Allow using ports higher than SERIAL_8250_RUNTIME_UARTS") >>>>>> >>>>>> the kernel can register uarts dynamically that are above the >>>>>> SERIAL_8250_RUNTIME_UARTS threshold. >>>>>> >>>>>> Signed-off-by: Heiko Stuebner <heiko.stuebner@cherry.de> >>>>> >>>>> There is a competing patch set from Francesco being submitted as well: >>>>> https://lore.kernel.org/all/20231201171544.1901-1-francesco@dolcini.it/ >>>>> >>>>> looks like some coordination is necessary. >>> >>> >>> So TL;DR: >>> I could live with the 8 from your original patch, but I guess would prefer >>> going with a safer value, so the 10 or your 12 from above. >>> >>> Because I guess if a controller is present, someone will use it >>> eventually ;-). >> >> There was an explicit push back on this approach from Arnd, see >> https://lore.kernel.org/all/CAK8P3a2VSBvOn1o+q1PYZaQ6LS9U4cz+DZGuDbisHkwNs2dAAw@mail.gmail.com/ > > aliases really are a matter of difficult discussions ;-) > I.e. Krzysztof's argument some days ago was > > "No, this should be per-board to match board labeling/schematics." > > https://lore.kernel.org/all/813224c2-398d-4c2d-8909-1839ce63be60@linaro.org/ > > And on Rockchip socs everyting from soc manual, board schematics down to > the description of pin headers use the uart controller number so people will > expect uart9 to be ttyS9 on the system as well. > > >> I would propose that we stay with my current proposal of 8. > > But ok we can go this route, simply as the current board I'm working on > only use 8, so I can leave that "fight" to someone else ;-) > Actually, UART8 and UART9 (so the 9th and 10th controllers) are exposed on the Mezzanine connector and we have a HW design for a daughterboard using that already. So we'll eventually support it upstream as well. So at least 10 is necessary if I understood correctly. And yes, those are really named after their controller indices on the schematics. So we need the value of the symbol to be that high. Cheers, Quentin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2023-12-04 9:32 UTC | newest] Thread overview: 9+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2023-12-01 19:12 [PATCH] arm64: defconfig: Increase SERIAL_8250_NR_UARTS to 10 Heiko Stuebner 2023-12-01 19:57 ` Florian Fainelli 2023-12-01 20:09 ` Francesco Dolcini 2023-12-01 20:56 ` Heiko Stübner 2023-12-01 21:03 ` Heiko Stübner 2023-12-01 21:12 ` Francesco Dolcini 2023-12-02 11:51 ` Francesco Dolcini 2023-12-02 12:12 ` Heiko Stübner 2023-12-04 9:32 ` Quentin Schulz
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox