* [PATCH 1/1] ARM: vt8500: Staticize local symbols
@ 2014-05-27 11:57 Sachin Kamat
2014-05-27 12:05 ` Arnd Bergmann
0 siblings, 1 reply; 6+ messages in thread
From: Sachin Kamat @ 2014-05-27 11:57 UTC (permalink / raw)
To: linux-arm-kernel
Variables local to this file are made static.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
arch/arm/mach-vt8500/vt8500.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm/mach-vt8500/vt8500.c b/arch/arm/mach-vt8500/vt8500.c
index 4a73464cb11b..2da7be31e7e2 100644
--- a/arch/arm/mach-vt8500/vt8500.c
+++ b/arch/arm/mach-vt8500/vt8500.c
@@ -44,7 +44,7 @@
static void __iomem *pmc_base;
-void vt8500_restart(enum reboot_mode mode, const char *cmd)
+static void vt8500_restart(enum reboot_mode mode, const char *cmd)
{
if (pmc_base)
writel(1, pmc_base + VT8500_PMSR_REG);
@@ -60,7 +60,7 @@ static struct map_desc vt8500_io_desc[] __initdata = {
},
};
-void __init vt8500_map_io(void)
+static void __init vt8500_map_io(void)
{
iotable_init(vt8500_io_desc, ARRAY_SIZE(vt8500_io_desc));
}
@@ -72,7 +72,7 @@ static void vt8500_power_off(void)
asm("mcr%? p15, 0, %0, c7, c0, 4" : : "r" (0));
}
-void __init vt8500_init(void)
+static void __init vt8500_init(void)
{
struct device_node *np;
#if defined(CONFIG_FB_VT8500) || defined(CONFIG_FB_WM8505)
--
1.7.9.5
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 1/1] ARM: vt8500: Staticize local symbols
2014-05-27 11:57 [PATCH 1/1] ARM: vt8500: Staticize local symbols Sachin Kamat
@ 2014-05-27 12:05 ` Arnd Bergmann
2014-05-29 20:44 ` Tony Prisk
0 siblings, 1 reply; 6+ messages in thread
From: Arnd Bergmann @ 2014-05-27 12:05 UTC (permalink / raw)
To: linux-arm-kernel
On Tuesday 27 May 2014 17:27:43 Sachin Kamat wrote:
> Variables local to this file are made static.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
> arch/arm/mach-vt8500/vt8500.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
Acked-by: Arnd Bergmann <arnd@arndb.de>
Looks good to me, but you forgot to take the maintainer on Cc.
How should we handle this patch? I guess this is the only one
for vt8500 in 3.16, so I can pick it up directly with Tony's
Ack.
> diff --git a/arch/arm/mach-vt8500/vt8500.c b/arch/arm/mach-vt8500/vt8500.c
> index 4a73464cb11b..2da7be31e7e2 100644
> --- a/arch/arm/mach-vt8500/vt8500.c
> +++ b/arch/arm/mach-vt8500/vt8500.c
> @@ -44,7 +44,7 @@
>
> static void __iomem *pmc_base;
>
> -void vt8500_restart(enum reboot_mode mode, const char *cmd)
> +static void vt8500_restart(enum reboot_mode mode, const char *cmd)
> {
> if (pmc_base)
> writel(1, pmc_base + VT8500_PMSR_REG);
> @@ -60,7 +60,7 @@ static struct map_desc vt8500_io_desc[] __initdata = {
> },
> };
>
> -void __init vt8500_map_io(void)
> +static void __init vt8500_map_io(void)
> {
> iotable_init(vt8500_io_desc, ARRAY_SIZE(vt8500_io_desc));
> }
> @@ -72,7 +72,7 @@ static void vt8500_power_off(void)
> asm("mcr%? p15, 0, %0, c7, c0, 4" : : "r" (0));
> }
>
> -void __init vt8500_init(void)
> +static void __init vt8500_init(void)
> {
> struct device_node *np;
> #if defined(CONFIG_FB_VT8500) || defined(CONFIG_FB_WM8505)
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/1] ARM: vt8500: Staticize local symbols
2014-05-27 12:05 ` Arnd Bergmann
@ 2014-05-29 20:44 ` Tony Prisk
2014-05-30 6:19 ` Sachin Kamat
0 siblings, 1 reply; 6+ messages in thread
From: Tony Prisk @ 2014-05-29 20:44 UTC (permalink / raw)
To: linux-arm-kernel
On 28/05/14 00:05, Arnd Bergmann wrote:
> On Tuesday 27 May 2014 17:27:43 Sachin Kamat wrote:
>> Variables local to this file are made static.
>>
>> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
>> ---
>> arch/arm/mach-vt8500/vt8500.c | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
> Acked-by: Arnd Bergmann <arnd@arndb.de>
>
> Looks good to me, but you forgot to take the maintainer on Cc.
>
> How should we handle this patch? I guess this is the only one
> for vt8500 in 3.16, so I can pick it up directly with Tony's
> Ack.
>
>> diff --git a/arch/arm/mach-vt8500/vt8500.c b/arch/arm/mach-vt8500/vt8500.c
>> index 4a73464cb11b..2da7be31e7e2 100644
>> --- a/arch/arm/mach-vt8500/vt8500.c
>> +++ b/arch/arm/mach-vt8500/vt8500.c
>> @@ -44,7 +44,7 @@
>>
>> static void __iomem *pmc_base;
>>
>> -void vt8500_restart(enum reboot_mode mode, const char *cmd)
>> +static void vt8500_restart(enum reboot_mode mode, const char *cmd)
>> {
>> if (pmc_base)
>> writel(1, pmc_base + VT8500_PMSR_REG);
>> @@ -60,7 +60,7 @@ static struct map_desc vt8500_io_desc[] __initdata = {
>> },
>> };
>>
>> -void __init vt8500_map_io(void)
>> +static void __init vt8500_map_io(void)
>> {
>> iotable_init(vt8500_io_desc, ARRAY_SIZE(vt8500_io_desc));
>> }
>> @@ -72,7 +72,7 @@ static void vt8500_power_off(void)
>> asm("mcr%? p15, 0, %0, c7, c0, 4" : : "r" (0));
>> }
>>
>> -void __init vt8500_init(void)
>> +static void __init vt8500_init(void)
>> {
>> struct device_node *np;
>> #if defined(CONFIG_FB_VT8500) || defined(CONFIG_FB_WM8505)
>>
Acked-by: Tony Prisk <linux@prisktech.co.nz>
Can you pick this up please Arnd? Doesn't look like there will be
anything else for 3.16
Regards
Tony P
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/1] ARM: vt8500: Staticize local symbols
2014-05-29 20:44 ` Tony Prisk
@ 2014-05-30 6:19 ` Sachin Kamat
2014-05-30 14:53 ` Arnd Bergmann
0 siblings, 1 reply; 6+ messages in thread
From: Sachin Kamat @ 2014-05-30 6:19 UTC (permalink / raw)
To: linux-arm-kernel
On 30 May 2014 02:14, Tony Prisk <linux@prisktech.co.nz> wrote:
>
> On 28/05/14 00:05, Arnd Bergmann wrote:
>>
>> On Tuesday 27 May 2014 17:27:43 Sachin Kamat wrote:
>>>
>>> Variables local to this file are made static.
>>>
>>> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
>>> ---
>>> arch/arm/mach-vt8500/vt8500.c | 6 +++---
>>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> Acked-by: Arnd Bergmann <arnd@arndb.de>
>>
>> Looks good to me, but you forgot to take the maintainer on Cc.
>>
>> How should we handle this patch? I guess this is the only one
>> for vt8500 in 3.16, so I can pick it up directly with Tony's
>> Ack.
>>
>>> diff --git a/arch/arm/mach-vt8500/vt8500.c
>>> b/arch/arm/mach-vt8500/vt8500.c
>>> index 4a73464cb11b..2da7be31e7e2 100644
>>> --- a/arch/arm/mach-vt8500/vt8500.c
>>> +++ b/arch/arm/mach-vt8500/vt8500.c
>>> @@ -44,7 +44,7 @@
>>> static void __iomem *pmc_base;
>>> -void vt8500_restart(enum reboot_mode mode, const char *cmd)
>>> +static void vt8500_restart(enum reboot_mode mode, const char *cmd)
>>> {
>>> if (pmc_base)
>>> writel(1, pmc_base + VT8500_PMSR_REG);
>>> @@ -60,7 +60,7 @@ static struct map_desc vt8500_io_desc[] __initdata = {
>>> },
>>> };
>>> -void __init vt8500_map_io(void)
>>> +static void __init vt8500_map_io(void)
>>> {
>>> iotable_init(vt8500_io_desc, ARRAY_SIZE(vt8500_io_desc));
>>> }
>>> @@ -72,7 +72,7 @@ static void vt8500_power_off(void)
>>> asm("mcr%? p15, 0, %0, c7, c0, 4" : : "r" (0));
>>> }
>>> -void __init vt8500_init(void)
>>> +static void __init vt8500_init(void)
>>> {
>>> struct device_node *np;
>>> #if defined(CONFIG_FB_VT8500) || defined(CONFIG_FB_WM8505)
>>>
> Acked-by: Tony Prisk <linux@prisktech.co.nz>
Thanks Tony.
> Can you pick this up please Arnd? Doesn't look like there will be anything
> else for 3.16
Arnd,
I have a few more similar patches for other platforms (mvebu, sti, spear).
Can I send them as well along with the accumulated acks for you to apply?
---
With warm regards,
Sachin
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/1] ARM: vt8500: Staticize local symbols
2014-05-30 6:19 ` Sachin Kamat
@ 2014-05-30 14:53 ` Arnd Bergmann
2014-05-30 17:03 ` Sachin Kamat
0 siblings, 1 reply; 6+ messages in thread
From: Arnd Bergmann @ 2014-05-30 14:53 UTC (permalink / raw)
To: linux-arm-kernel
On Friday 30 May 2014 11:49:02 Sachin Kamat wrote:
>
> I have a few more similar patches for other platforms (mvebu, sti, spear).
> Can I send them as well along with the accumulated acks for you to apply?
Yes, that's fine. If you can, please send a pull request with the lot
to arm at kernel.org, with the maintainers and linux-arm-kernel on Cc.
Arnd
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/1] ARM: vt8500: Staticize local symbols
2014-05-30 14:53 ` Arnd Bergmann
@ 2014-05-30 17:03 ` Sachin Kamat
0 siblings, 0 replies; 6+ messages in thread
From: Sachin Kamat @ 2014-05-30 17:03 UTC (permalink / raw)
To: linux-arm-kernel
On 30 May 2014 20:23, Arnd Bergmann <arnd@arndb.de> wrote:
> On Friday 30 May 2014 11:49:02 Sachin Kamat wrote:
>>
>> I have a few more similar patches for other platforms (mvebu, sti, spear).
>> Can I send them as well along with the accumulated acks for you to apply?
>
> Yes, that's fine. If you can, please send a pull request with the lot
> to arm at kernel.org, with the maintainers and linux-arm-kernel on Cc.
Actually, I happened to post all the 8 patches to linux-arm-kernel
with the respective
maintainers and you in Cc before leaving for the weekend (The first
patch in the series
being "[PATCH Resend 1/8] ARM: sti: Staticize local variables").
Please see if you can
pick them up. Else I will send you a pull request on Monday.
--
With warm regards,
Sachin
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-05-30 17:03 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-27 11:57 [PATCH 1/1] ARM: vt8500: Staticize local symbols Sachin Kamat
2014-05-27 12:05 ` Arnd Bergmann
2014-05-29 20:44 ` Tony Prisk
2014-05-30 6:19 ` Sachin Kamat
2014-05-30 14:53 ` Arnd Bergmann
2014-05-30 17:03 ` Sachin Kamat
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox