* RE: [PATCH] PCI: imx6: Keep Root Port MSI capability also for i.MX6Q
2026-04-27 11:58 [PATCH] PCI: imx6: Keep Root Port MSI capability also for i.MX6Q Soeren Moch
@ 2026-04-28 2:19 ` Hongxing Zhu
2026-07-05 9:10 ` Soeren Moch
2026-04-30 18:53 ` Frank Li
2026-07-06 10:29 ` Manivannan Sadhasivam
2 siblings, 1 reply; 7+ messages in thread
From: Hongxing Zhu @ 2026-04-28 2:19 UTC (permalink / raw)
To: Soeren Moch
Cc: stable@vger.kernel.org, Manivannan Sadhasivam, Lucas Stach,
Bjorn Helgaas, Frank Li, Fabio Estevam, linux-pci@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev,
linux-kernel@vger.kernel.org
> -----Original Message-----
> From: Soeren Moch <smoch@web.de>
> Sent: Monday, April 27, 2026 7:58 PM
> To: Hongxing Zhu <hongxing.zhu@nxp.com>
> Cc: Soeren Moch <smoch@web.de>; stable@vger.kernel.org; Manivannan
> Sadhasivam <mani@kernel.org>; Lucas Stach <l.stach@pengutronix.de>; Bjorn
> Helgaas <bhelgaas@google.com>; Frank Li <frank.li@nxp.com>; Fabio Estevam
> <festevam@gmail.com>; linux-pci@vger.kernel.org; linux-arm-
> kernel@lists.infradead.org; imx@lists.linux.dev; linux-kernel@vger.kernel.org
> Subject: [PATCH] PCI: imx6: Keep Root Port MSI capability also for i.MX6Q
>
> [You don't often get email from smoch@web.de. Learn why this is important at
> https://aka.ms/LearnAboutSenderIdentification ]
>
> Also on the NXP i.MX6Q chipset MSIs from the endpoints won't be received by
> the iMSI-RX MSI controller if the Root Port MSI capability is disabled.
>
> Even though the Root Port MSIs won't be received by the iMSI-RX controller due
> to design, this chipset has some weird hardware bug that prevents the endpoint
> MSIs from reaching when the Root Port MSI capability is disabled.
>
> Hence, always keep the Root Port MSI capability for this chipset.
>
> Note that by keeping Root Port MSI capability, Root Port MSIs such as AER, PME
> and others won't be received by default. So users need to use workarounds such
> as passing 'pcie_pme=nomsi' cmdline param.
>
> Fixes: 3a4e8302e72f ("PCI: imx6: Keep Root Port MSI capability with iMSI-RX to
> work around hardware bug")
> Cc: <stable@vger.kernel.org> # 7.0.x
> Signed-off-by: Soeren Moch <smoch@web.de>
Acked-by: Richard Zhu <hongxing.zhu@nxp.com>
Best Regards
Richard Zhu
> ---
> Cc: Manivannan Sadhasivam <mani@kernel.org>
> Cc: Richard Zhu <hongxing.zhu@nxp.com>
> Cc: Lucas Stach <l.stach@pengutronix.de>
> Cc: Bjorn Helgaas <bhelgaas@google.com>
> Cc: Frank Li <Frank.Li@nxp.com>
> Cc: Fabio Estevam <festevam@gmail.com>
> Cc: linux-pci@vger.kernel.org
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: imx@lists.linux.dev
> Cc: linux-kernel@vger.kernel.org
>
> Tested on a tbs2910 board [1]
> [1] arch/arm/boot/dts/nxp/imx/imx6q-tbs2910.dts
> ---
> drivers/pci/controller/dwc/pci-imx6.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/pci/controller/dwc/pci-imx6.c
> b/drivers/pci/controller/dwc/pci-imx6.c
> index 6d6a1688e7eb..3d461bdef967 100644
> --- a/drivers/pci/controller/dwc/pci-imx6.c
> +++ b/drivers/pci/controller/dwc/pci-imx6.c
> @@ -1865,7 +1865,8 @@ static const struct imx_pcie_drvdata drvdata[] = {
> .flags = IMX_PCIE_FLAG_IMX_PHY |
> IMX_PCIE_FLAG_SPEED_CHANGE_WORKAROUND |
> IMX_PCIE_FLAG_BROKEN_SUSPEND |
> - IMX_PCIE_FLAG_SUPPORTS_SUSPEND,
> + IMX_PCIE_FLAG_SUPPORTS_SUSPEND |
> + IMX_PCIE_FLAG_KEEP_MSI_CAP,
> .dbi_length = 0x200,
> .gpr = "fsl,imx6q-iomuxc-gpr",
> .ltssm_off = IOMUXC_GPR12,
> --
> 2.43.0
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] PCI: imx6: Keep Root Port MSI capability also for i.MX6Q
2026-04-28 2:19 ` Hongxing Zhu
@ 2026-07-05 9:10 ` Soeren Moch
2026-07-06 3:06 ` Hongxing Zhu
0 siblings, 1 reply; 7+ messages in thread
From: Soeren Moch @ 2026-07-05 9:10 UTC (permalink / raw)
To: Hongxing Zhu
Cc: stable@vger.kernel.org, Manivannan Sadhasivam, Lucas Stach,
Bjorn Helgaas, Frank Li, Fabio Estevam, linux-pci@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev,
linux-kernel@vger.kernel.org
On 28.04.26 04:19, Hongxing Zhu wrote:
>> -----Original Message-----
>> From: Soeren Moch <smoch@web.de>
>> Sent: Monday, April 27, 2026 7:58 PM
>> To: Hongxing Zhu <hongxing.zhu@nxp.com>
>> Cc: Soeren Moch <smoch@web.de>; stable@vger.kernel.org; Manivannan
>> Sadhasivam <mani@kernel.org>; Lucas Stach <l.stach@pengutronix.de>; Bjorn
>> Helgaas <bhelgaas@google.com>; Frank Li <frank.li@nxp.com>; Fabio Estevam
>> <festevam@gmail.com>; linux-pci@vger.kernel.org; linux-arm-
>> kernel@lists.infradead.org; imx@lists.linux.dev; linux-kernel@vger.kernel.org
>> Subject: [PATCH] PCI: imx6: Keep Root Port MSI capability also for i.MX6Q
>>
>> [You don't often get email from smoch@web.de. Learn why this is important at
>> https://aka.ms/LearnAboutSenderIdentification ]
>>
>> Also on the NXP i.MX6Q chipset MSIs from the endpoints won't be received by
>> the iMSI-RX MSI controller if the Root Port MSI capability is disabled.
>>
>> Even though the Root Port MSIs won't be received by the iMSI-RX controller due
>> to design, this chipset has some weird hardware bug that prevents the endpoint
>> MSIs from reaching when the Root Port MSI capability is disabled.
>>
>> Hence, always keep the Root Port MSI capability for this chipset.
>>
>> Note that by keeping Root Port MSI capability, Root Port MSIs such as AER, PME
>> and others won't be received by default. So users need to use workarounds such
>> as passing 'pcie_pme=nomsi' cmdline param.
>>
>> Fixes: 3a4e8302e72f ("PCI: imx6: Keep Root Port MSI capability with iMSI-RX to
>> work around hardware bug")
>> Cc: <stable@vger.kernel.org> # 7.0.x
>> Signed-off-by: Soeren Moch <smoch@web.de>
> Acked-by: Richard Zhu <hongxing.zhu@nxp.com>
This patch is a regression fix for linux-7.0.
It is still not part of linux-7.2-rc1 .
Can I do something to get this merged, is something still missing from
my side?
Thanks,
Soeren
>
> Best Regards
> Richard Zhu
>> ---
>> Cc: Manivannan Sadhasivam <mani@kernel.org>
>> Cc: Richard Zhu <hongxing.zhu@nxp.com>
>> Cc: Lucas Stach <l.stach@pengutronix.de>
>> Cc: Bjorn Helgaas <bhelgaas@google.com>
>> Cc: Frank Li <Frank.Li@nxp.com>
>> Cc: Fabio Estevam <festevam@gmail.com>
>> Cc: linux-pci@vger.kernel.org
>> Cc: linux-arm-kernel@lists.infradead.org
>> Cc: imx@lists.linux.dev
>> Cc: linux-kernel@vger.kernel.org
>>
>> Tested on a tbs2910 board [1]
>> [1] arch/arm/boot/dts/nxp/imx/imx6q-tbs2910.dts
>> ---
>> drivers/pci/controller/dwc/pci-imx6.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/pci/controller/dwc/pci-imx6.c
>> b/drivers/pci/controller/dwc/pci-imx6.c
>> index 6d6a1688e7eb..3d461bdef967 100644
>> --- a/drivers/pci/controller/dwc/pci-imx6.c
>> +++ b/drivers/pci/controller/dwc/pci-imx6.c
>> @@ -1865,7 +1865,8 @@ static const struct imx_pcie_drvdata drvdata[] = {
>> .flags = IMX_PCIE_FLAG_IMX_PHY |
>> IMX_PCIE_FLAG_SPEED_CHANGE_WORKAROUND |
>> IMX_PCIE_FLAG_BROKEN_SUSPEND |
>> - IMX_PCIE_FLAG_SUPPORTS_SUSPEND,
>> + IMX_PCIE_FLAG_SUPPORTS_SUSPEND |
>> + IMX_PCIE_FLAG_KEEP_MSI_CAP,
>> .dbi_length = 0x200,
>> .gpr = "fsl,imx6q-iomuxc-gpr",
>> .ltssm_off = IOMUXC_GPR12,
>> --
>> 2.43.0
>
^ permalink raw reply [flat|nested] 7+ messages in thread* RE: [PATCH] PCI: imx6: Keep Root Port MSI capability also for i.MX6Q
2026-07-05 9:10 ` Soeren Moch
@ 2026-07-06 3:06 ` Hongxing Zhu
0 siblings, 0 replies; 7+ messages in thread
From: Hongxing Zhu @ 2026-07-06 3:06 UTC (permalink / raw)
To: Soeren Moch, Manivannan Sadhasivam
Cc: stable@vger.kernel.org, Manivannan Sadhasivam, Lucas Stach,
Bjorn Helgaas, Frank Li, Fabio Estevam, linux-pci@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev,
linux-kernel@vger.kernel.org
> -----Original Message-----
> From: Soeren Moch <smoch@web.de>
> Sent: Sunday, July 5, 2026 5:11 PM
> To: Hongxing Zhu <hongxing.zhu@nxp.com>
> Cc: stable@vger.kernel.org; Manivannan Sadhasivam <mani@kernel.org>; Lucas
> Stach <l.stach@pengutronix.de>; Bjorn Helgaas <bhelgaas@google.com>; Frank
> Li <frank.li@nxp.com>; Fabio Estevam <festevam@gmail.com>; linux-
> pci@vger.kernel.org; linux-arm-kernel@lists.infradead.org; imx@lists.linux.dev;
> linux-kernel@vger.kernel.org
> Subject: Re: [PATCH] PCI: imx6: Keep Root Port MSI capability also for i.MX6Q
>
> [You don't often get email from smoch@web.de. Learn why this is important at
> https://aka.ms/LearnAboutSenderIdentification ]
>
> On 28.04.26 04:19, Hongxing Zhu wrote:
> >> -----Original Message-----
> >> From: Soeren Moch <smoch@web.de>
> >> Sent: Monday, April 27, 2026 7:58 PM
> >> To: Hongxing Zhu <hongxing.zhu@nxp.com>
> >> Cc: Soeren Moch <smoch@web.de>; stable@vger.kernel.org; Manivannan
> >> Sadhasivam <mani@kernel.org>; Lucas Stach <l.stach@pengutronix.de>;
> >> Bjorn Helgaas <bhelgaas@google.com>; Frank Li <frank.li@nxp.com>;
> >> Fabio Estevam <festevam@gmail.com>; linux-pci@vger.kernel.org;
> >> linux-arm- kernel@lists.infradead.org; imx@lists.linux.dev;
> >> linux-kernel@vger.kernel.org
> >> Subject: [PATCH] PCI: imx6: Keep Root Port MSI capability also for
> >> i.MX6Q
> >>
> >> [You don't often get email from smoch@web.de. Learn why this is
> >> important at https://aka.ms/LearnAboutSenderIdentification ]
> >>
> >> Also on the NXP i.MX6Q chipset MSIs from the endpoints won't be
> >> received by the iMSI-RX MSI controller if the Root Port MSI capability is
> disabled.
> >>
> >> Even though the Root Port MSIs won't be received by the iMSI-RX
> >> controller due to design, this chipset has some weird hardware bug
> >> that prevents the endpoint MSIs from reaching when the Root Port MSI
> capability is disabled.
> >>
> >> Hence, always keep the Root Port MSI capability for this chipset.
> >>
> >> Note that by keeping Root Port MSI capability, Root Port MSIs such as
> >> AER, PME and others won't be received by default. So users need to
> >> use workarounds such as passing 'pcie_pme=nomsi' cmdline param.
> >>
> >> Fixes: 3a4e8302e72f ("PCI: imx6: Keep Root Port MSI capability with
> >> iMSI-RX to work around hardware bug")
> >> Cc: <stable@vger.kernel.org> # 7.0.x
> >> Signed-off-by: Soeren Moch <smoch@web.de>
> > Acked-by: Richard Zhu <hongxing.zhu@nxp.com>
>
> This patch is a regression fix for linux-7.0.
> It is still not part of linux-7.2-rc1 .
>
> Can I do something to get this merged, is something still missing from my side?
Maybe Mani missed this fix in previous merge window.
Hi Mani:
Can you help to take look at this minor fix patch?
Best Regards
Richard Zhu
>
> Thanks,
> Soeren
>
> >
> > Best Regards
> > Richard Zhu
> >> ---
> >> Cc: Manivannan Sadhasivam <mani@kernel.org>
> >> Cc: Richard Zhu <hongxing.zhu@nxp.com>
> >> Cc: Lucas Stach <l.stach@pengutronix.de>
> >> Cc: Bjorn Helgaas <bhelgaas@google.com>
> >> Cc: Frank Li <Frank.Li@nxp.com>
> >> Cc: Fabio Estevam <festevam@gmail.com>
> >> Cc: linux-pci@vger.kernel.org
> >> Cc: linux-arm-kernel@lists.infradead.org
> >> Cc: imx@lists.linux.dev
> >> Cc: linux-kernel@vger.kernel.org
> >>
> >> Tested on a tbs2910 board [1]
> >> [1] arch/arm/boot/dts/nxp/imx/imx6q-tbs2910.dts
> >> ---
> >> drivers/pci/controller/dwc/pci-imx6.c | 3 ++-
> >> 1 file changed, 2 insertions(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/pci/controller/dwc/pci-imx6.c
> >> b/drivers/pci/controller/dwc/pci-imx6.c
> >> index 6d6a1688e7eb..3d461bdef967 100644
> >> --- a/drivers/pci/controller/dwc/pci-imx6.c
> >> +++ b/drivers/pci/controller/dwc/pci-imx6.c
> >> @@ -1865,7 +1865,8 @@ static const struct imx_pcie_drvdata drvdata[] = {
> >> .flags = IMX_PCIE_FLAG_IMX_PHY |
> >> IMX_PCIE_FLAG_SPEED_CHANGE_WORKAROUND |
> >> IMX_PCIE_FLAG_BROKEN_SUSPEND |
> >> - IMX_PCIE_FLAG_SUPPORTS_SUSPEND,
> >> + IMX_PCIE_FLAG_SUPPORTS_SUSPEND |
> >> + IMX_PCIE_FLAG_KEEP_MSI_CAP,
> >> .dbi_length = 0x200,
> >> .gpr = "fsl,imx6q-iomuxc-gpr",
> >> .ltssm_off = IOMUXC_GPR12,
> >> --
> >> 2.43.0
> >
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] PCI: imx6: Keep Root Port MSI capability also for i.MX6Q
2026-04-27 11:58 [PATCH] PCI: imx6: Keep Root Port MSI capability also for i.MX6Q Soeren Moch
2026-04-28 2:19 ` Hongxing Zhu
@ 2026-04-30 18:53 ` Frank Li
2026-07-06 10:29 ` Manivannan Sadhasivam
2 siblings, 0 replies; 7+ messages in thread
From: Frank Li @ 2026-04-30 18:53 UTC (permalink / raw)
To: Soeren Moch
Cc: Richard Zhu, stable, Manivannan Sadhasivam, Lucas Stach,
Bjorn Helgaas, Fabio Estevam, linux-pci, linux-arm-kernel, imx,
linux-kernel
On Mon, Apr 27, 2026 at 01:58:04PM +0200, Soeren Moch wrote:
> Also on the NXP i.MX6Q chipset MSIs from the endpoints won't be received by
> the iMSI-RX MSI controller if the Root Port MSI capability is disabled.
>
> Even though the Root Port MSIs won't be received by the iMSI-RX controller
> due to design, this chipset has some weird hardware bug that prevents
> the endpoint MSIs from reaching when the Root Port MSI capability is
> disabled.
>
> Hence, always keep the Root Port MSI capability for this chipset.
>
> Note that by keeping Root Port MSI capability, Root Port MSIs such as AER,
> PME and others won't be received by default. So users need to use
> workarounds such as passing 'pcie_pme=nomsi' cmdline param.
>
> Fixes: 3a4e8302e72f ("PCI: imx6: Keep Root Port MSI capability with iMSI-RX to work around hardware bug")
> Cc: <stable@vger.kernel.org> # 7.0.x
> Signed-off-by: Soeren Moch <smoch@web.de>
Reviewed-by: Frank Li <Frank.Li@nxp.com>
> ---
> Cc: Manivannan Sadhasivam <mani@kernel.org>
> Cc: Richard Zhu <hongxing.zhu@nxp.com>
> Cc: Lucas Stach <l.stach@pengutronix.de>
> Cc: Bjorn Helgaas <bhelgaas@google.com>
> Cc: Frank Li <Frank.Li@nxp.com>
> Cc: Fabio Estevam <festevam@gmail.com>
> Cc: linux-pci@vger.kernel.org
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: imx@lists.linux.dev
> Cc: linux-kernel@vger.kernel.org
>
> Tested on a tbs2910 board [1]
> [1] arch/arm/boot/dts/nxp/imx/imx6q-tbs2910.dts
> ---
> drivers/pci/controller/dwc/pci-imx6.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pci-imx6.c
> index 6d6a1688e7eb..3d461bdef967 100644
> --- a/drivers/pci/controller/dwc/pci-imx6.c
> +++ b/drivers/pci/controller/dwc/pci-imx6.c
> @@ -1865,7 +1865,8 @@ static const struct imx_pcie_drvdata drvdata[] = {
> .flags = IMX_PCIE_FLAG_IMX_PHY |
> IMX_PCIE_FLAG_SPEED_CHANGE_WORKAROUND |
> IMX_PCIE_FLAG_BROKEN_SUSPEND |
> - IMX_PCIE_FLAG_SUPPORTS_SUSPEND,
> + IMX_PCIE_FLAG_SUPPORTS_SUSPEND |
> + IMX_PCIE_FLAG_KEEP_MSI_CAP,
> .dbi_length = 0x200,
> .gpr = "fsl,imx6q-iomuxc-gpr",
> .ltssm_off = IOMUXC_GPR12,
> --
> 2.43.0
>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] PCI: imx6: Keep Root Port MSI capability also for i.MX6Q
2026-04-27 11:58 [PATCH] PCI: imx6: Keep Root Port MSI capability also for i.MX6Q Soeren Moch
2026-04-28 2:19 ` Hongxing Zhu
2026-04-30 18:53 ` Frank Li
@ 2026-07-06 10:29 ` Manivannan Sadhasivam
2026-07-08 8:52 ` Soeren Moch
2 siblings, 1 reply; 7+ messages in thread
From: Manivannan Sadhasivam @ 2026-07-06 10:29 UTC (permalink / raw)
To: Soeren Moch, Bjorn Helgaas
Cc: Richard Zhu, stable, Lucas Stach, Frank Li, Fabio Estevam,
linux-pci, linux-arm-kernel, imx, linux-kernel
On Mon, Apr 27, 2026 at 01:58:04PM +0200, Soeren Moch wrote:
> Also on the NXP i.MX6Q chipset MSIs from the endpoints won't be received by
> the iMSI-RX MSI controller if the Root Port MSI capability is disabled.
>
> Even though the Root Port MSIs won't be received by the iMSI-RX controller
> due to design, this chipset has some weird hardware bug that prevents
> the endpoint MSIs from reaching when the Root Port MSI capability is
> disabled.
>
> Hence, always keep the Root Port MSI capability for this chipset.
>
> Note that by keeping Root Port MSI capability, Root Port MSIs such as AER,
> PME and others won't be received by default. So users need to use
> workarounds such as passing 'pcie_pme=nomsi' cmdline param.
>
> Fixes: 3a4e8302e72f ("PCI: imx6: Keep Root Port MSI capability with iMSI-RX to work around hardware bug")
This is not the correct fixes tag. Correct one is:
f5cd8a929c825 ("PCI: dwc: Remove MSI/MSIX capability for Root Port if iMSI-RX is used as MSI controller")
> Cc: <stable@vger.kernel.org> # 7.0.x
> Signed-off-by: Soeren Moch <smoch@web.de>
Reviewed-by: Manivannan Sadhasivam <mani@kernel.org>
@Bjorn: Can you merge this patch for 7.2-rcS with correct fixes tag?
- Mani
> ---
> Cc: Manivannan Sadhasivam <mani@kernel.org>
> Cc: Richard Zhu <hongxing.zhu@nxp.com>
> Cc: Lucas Stach <l.stach@pengutronix.de>
> Cc: Bjorn Helgaas <bhelgaas@google.com>
> Cc: Frank Li <Frank.Li@nxp.com>
> Cc: Fabio Estevam <festevam@gmail.com>
> Cc: linux-pci@vger.kernel.org
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: imx@lists.linux.dev
> Cc: linux-kernel@vger.kernel.org
>
> Tested on a tbs2910 board [1]
> [1] arch/arm/boot/dts/nxp/imx/imx6q-tbs2910.dts
> ---
> drivers/pci/controller/dwc/pci-imx6.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pci-imx6.c
> index 6d6a1688e7eb..3d461bdef967 100644
> --- a/drivers/pci/controller/dwc/pci-imx6.c
> +++ b/drivers/pci/controller/dwc/pci-imx6.c
> @@ -1865,7 +1865,8 @@ static const struct imx_pcie_drvdata drvdata[] = {
> .flags = IMX_PCIE_FLAG_IMX_PHY |
> IMX_PCIE_FLAG_SPEED_CHANGE_WORKAROUND |
> IMX_PCIE_FLAG_BROKEN_SUSPEND |
> - IMX_PCIE_FLAG_SUPPORTS_SUSPEND,
> + IMX_PCIE_FLAG_SUPPORTS_SUSPEND |
> + IMX_PCIE_FLAG_KEEP_MSI_CAP,
> .dbi_length = 0x200,
> .gpr = "fsl,imx6q-iomuxc-gpr",
> .ltssm_off = IOMUXC_GPR12,
> --
> 2.43.0
>
--
மணிவண்ணன் சதாசிவம்
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] PCI: imx6: Keep Root Port MSI capability also for i.MX6Q
2026-07-06 10:29 ` Manivannan Sadhasivam
@ 2026-07-08 8:52 ` Soeren Moch
0 siblings, 0 replies; 7+ messages in thread
From: Soeren Moch @ 2026-07-08 8:52 UTC (permalink / raw)
To: Manivannan Sadhasivam, Bjorn Helgaas
Cc: Richard Zhu, stable, Lucas Stach, Frank Li, Fabio Estevam,
linux-pci, linux-arm-kernel, imx, linux-kernel
On 06.07.26 12:29, Manivannan Sadhasivam wrote:
> On Mon, Apr 27, 2026 at 01:58:04PM +0200, Soeren Moch wrote:
>> Also on the NXP i.MX6Q chipset MSIs from the endpoints won't be received by
>> the iMSI-RX MSI controller if the Root Port MSI capability is disabled.
>>
>> Even though the Root Port MSIs won't be received by the iMSI-RX controller
>> due to design, this chipset has some weird hardware bug that prevents
>> the endpoint MSIs from reaching when the Root Port MSI capability is
>> disabled.
>>
>> Hence, always keep the Root Port MSI capability for this chipset.
>>
>> Note that by keeping Root Port MSI capability, Root Port MSIs such as AER,
>> PME and others won't be received by default. So users need to use
>> workarounds such as passing 'pcie_pme=nomsi' cmdline param.
>>
>> Fixes: 3a4e8302e72f ("PCI: imx6: Keep Root Port MSI capability with iMSI-RX to work around hardware bug")
> This is not the correct fixes tag. Correct one is:
> f5cd8a929c825 ("PCI: dwc: Remove MSI/MSIX capability for Root Port if iMSI-RX is used as MSI controller")
Thanks for the fix of the fixes tag!
>> Cc: <stable@vger.kernel.org> # 7.0.x
>> Signed-off-by: Soeren Moch <smoch@web.de>
> Reviewed-by: Manivannan Sadhasivam <mani@kernel.org>
>
> @Bjorn: Can you merge this patch for 7.2-rcS with correct fixes tag?
I can send a v2 of the patch if you prefer.
Thanks,
Soeren
>
> - Mani
>
>> ---
>> Cc: Manivannan Sadhasivam <mani@kernel.org>
>> Cc: Richard Zhu <hongxing.zhu@nxp.com>
>> Cc: Lucas Stach <l.stach@pengutronix.de>
>> Cc: Bjorn Helgaas <bhelgaas@google.com>
>> Cc: Frank Li <Frank.Li@nxp.com>
>> Cc: Fabio Estevam <festevam@gmail.com>
>> Cc: linux-pci@vger.kernel.org
>> Cc: linux-arm-kernel@lists.infradead.org
>> Cc: imx@lists.linux.dev
>> Cc: linux-kernel@vger.kernel.org
>>
>> Tested on a tbs2910 board [1]
>> [1] arch/arm/boot/dts/nxp/imx/imx6q-tbs2910.dts
>> ---
>> drivers/pci/controller/dwc/pci-imx6.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pci-imx6.c
>> index 6d6a1688e7eb..3d461bdef967 100644
>> --- a/drivers/pci/controller/dwc/pci-imx6.c
>> +++ b/drivers/pci/controller/dwc/pci-imx6.c
>> @@ -1865,7 +1865,8 @@ static const struct imx_pcie_drvdata drvdata[] = {
>> .flags = IMX_PCIE_FLAG_IMX_PHY |
>> IMX_PCIE_FLAG_SPEED_CHANGE_WORKAROUND |
>> IMX_PCIE_FLAG_BROKEN_SUSPEND |
>> - IMX_PCIE_FLAG_SUPPORTS_SUSPEND,
>> + IMX_PCIE_FLAG_SUPPORTS_SUSPEND |
>> + IMX_PCIE_FLAG_KEEP_MSI_CAP,
>> .dbi_length = 0x200,
>> .gpr = "fsl,imx6q-iomuxc-gpr",
>> .ltssm_off = IOMUXC_GPR12,
>> --
>> 2.43.0
>>
^ permalink raw reply [flat|nested] 7+ messages in thread