From: laurent.pinchart@ideasonboard.com (Laurent Pinchart)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] PM / Runtime: Defer resuming of the device in pm_runtime_force_resume()
Date: Thu, 12 May 2016 22:01:13 +0300 [thread overview]
Message-ID: <4661739.p5SU9QcIps@avalon> (raw)
In-Reply-To: <CAPDyKFpOxabizwQqhtKb-h0vGpTRtrCa0nPxAKMY22rnjLCouw@mail.gmail.com>
Hello,
On Wednesday 27 Apr 2016 16:23:49 Ulf Hansson wrote:
> [...]
>
> >> Following you reasoning, I agree!
> >>
> >> Let's put this patch on hold for a little while. I am already working
> >> on changing genpd, so it shouldn't take long before I can post some
> >> additional genpd patches improving the behaviour.
> >
> > I'd like to see something merged for v4.7 if possible. I agree that my
> > patch isn't a long term solution (we want to avoid adding additional
> > fields to the device power structure), but it has the benefit of being
> > available now and fixing the problem I ran into with drivers that would
> > be broken on v4.7 without a fix. Do you think you could get a better fix
> > ready in time for v4.7 ? If so I'm fine with dropping this patch, but
> > otherwise I'd prefer to get it merged and reverted as part of your better
> > implementation for v4.8.
>
> My impression was that devices becomes unnecessary resumed when they
> don't need to. They won't stay resumed as the PM core invokes
> pm_runtime_put() in the system PM complete phase.
>
> So, in the end I think we are trying to optimize a behaviour here, but
> not fix something that is "broken", correct?
>
> Anyway, I have no objections to your proposed solution, so I leave it
> to Rafael and Kevin to decide what to do.
Kevin, Rafael, any comment ? I need to fix PM support in a driver that is
currently broken partly due to this issue. Which of "PM / Runtime: Only force-
resume device if it has been force-suspended" and this patch should we merge,
if any ?
> From my side I will continue with the improvements for the system PM
> support in genpd.
Thanks.
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2016-05-12 19:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-21 10:34 [PATCH] PM / Runtime: Defer resuming of the device in pm_runtime_force_resume() Ulf Hansson
2016-04-21 17:31 ` Laurent Pinchart
2016-04-21 20:57 ` Laurent Pinchart
2016-04-22 20:27 ` Kevin Hilman
2016-04-25 8:15 ` Ulf Hansson
2016-04-25 13:32 ` Ulf Hansson
2016-04-25 16:52 ` Laurent Pinchart
2016-04-27 14:23 ` Ulf Hansson
2016-05-12 19:01 ` Laurent Pinchart [this message]
2016-05-12 20:28 ` Rafael J. Wysocki
2016-05-13 13:59 ` Ulf Hansson
2016-04-21 19:23 ` Rafael J. Wysocki
2016-04-22 6:58 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4661739.p5SU9QcIps@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox