public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: Alexander Stein <alexander.stein@ew.tq-group.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/1] arm64: dts: imx8mp: add missing pinctrl for RTC alarm
Date: Tue, 06 Sep 2022 08:35:49 +0200	[thread overview]
Message-ID: <4771067.31r3eYUQgx@steina-w> (raw)
In-Reply-To: <CAOMZO5DeSnEDqmy1V5FJoEKZ07i157-1e0WErqJgYT3JiKrfUg@mail.gmail.com>

Hello Fabio,

Am Montag, 5. September 2022, 14:26:42 CEST schrieb Fabio Estevam:
> Hi Alexander,
> 
> On Mon, Sep 5, 2022 at 4:26 AM Alexander Stein
> 
> <alexander.stein@ew.tq-group.com> wrote:
> > Although the RTC is on the module, the RTC_EVENT# signal is connected
> > on the mainboard. Already set by bootloader, but make explicit in Linux
> > as well.
> > 
> > Fixes: 418d1d840e42 ("arm64: dts: freescale: add initial device tree for
> > TQMa8MPQL with i.MX8MP") Signed-off-by: Alexander Stein
> > <alexander.stein@ew.tq-group.com>
> 
> The change looks good, but the Subject should be improved to contain
> the board name:
> 
> arm64: dts: imx8mp-tqma8mpql-mba8mpxl: add missing pinctrl for RTC alarm
> 
> Reviewed-by: Fabio Estevam <festevam@gmail.com>

Thank you for your fast feedback. You are right, the board name is missing and 
I'll add it.

Thanks
Alexander




_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

      reply	other threads:[~2022-09-06  6:37 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-05  7:25 [PATCH 1/1] arm64: dts: imx8mp: add missing pinctrl for RTC alarm Alexander Stein
2022-09-05 12:26 ` Fabio Estevam
2022-09-06  6:35   ` Alexander Stein [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4771067.31r3eYUQgx@steina-w \
    --to=alexander.stein@ew.tq-group.com \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox