[PATCH 1/1] arm64: dts: imx8mp: add missing pinctrl for RTC alarm

[PATCH 1/1] arm64: dts: imx8mp: add missing pinctrl for RTC alarm

[Alexander Stein]

Although the RTC is on the module, the RTC_EVENT# signal is connected
on the mainboard. Already set by bootloader, but make explicit in Linux
as well.

Fixes: 418d1d840e42 ("arm64: dts: freescale: add initial device tree for TQMa8MPQL with i.MX8MP")
Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
 arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql-mba8mpxl.dts | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql-mba8mpxl.dts b/arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql-mba8mpxl.dts
index 1838232d3d60..89443bc36b1b 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql-mba8mpxl.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql-mba8mpxl.dts
@@ -517,6 +517,8 @@ &i2c6 {
 
 &pcf85063 {
 	/* RTC_EVENT# is connected on MBa8MPxL */
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_pcf85063>;
 	interrupt-parent = <&gpio4>;
 	interrupts = <28 IRQ_TYPE_EDGE_FALLING>;
 };
@@ -852,6 +854,10 @@ pinctrl_lvdsdisplay: lvdsdisplaygrp {
 		fsl,pins = <MX8MP_IOMUXC_SAI5_RXC__GPIO3_IO20		0x10>; /* Power enable */
 	};
 
+	pinctrl_pcf85063: pcf85063grp {
+		fsl,pins = <MX8MP_IOMUXC_SAI3_RXFS__GPIO4_IO28		0x80>;
+	};
+
 	/* LVDS Backlight */
 	pinctrl_pwm2: pwm2grp {
 		fsl,pins = <MX8MP_IOMUXC_SAI5_RXD0__PWM2_OUT		0x14>;
-- 
2.25.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 1/1] arm64: dts: imx8mp: add missing pinctrl for RTC alarm

[Fabio Estevam]

Hi Alexander,

On Mon, Sep 5, 2022 at 4:26 AM Alexander Stein
<alexander.stein@ew.tq-group.com> wrote:
>
> Although the RTC is on the module, the RTC_EVENT# signal is connected
> on the mainboard. Already set by bootloader, but make explicit in Linux
> as well.
>
> Fixes: 418d1d840e42 ("arm64: dts: freescale: add initial device tree for TQMa8MPQL with i.MX8MP")
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>

The change looks good, but the Subject should be improved to contain
the board name:

arm64: dts: imx8mp-tqma8mpql-mba8mpxl: add missing pinctrl for RTC alarm

Reviewed-by: Fabio Estevam <festevam@gmail.com>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 1/1] arm64: dts: imx8mp: add missing pinctrl for RTC alarm

[Alexander Stein]

Hello Fabio,

Am Montag, 5. September 2022, 14:26:42 CEST schrieb Fabio Estevam:
> Hi Alexander,
> 
> On Mon, Sep 5, 2022 at 4:26 AM Alexander Stein
> 
> <alexander.stein@ew.tq-group.com> wrote:
> > Although the RTC is on the module, the RTC_EVENT# signal is connected
> > on the mainboard. Already set by bootloader, but make explicit in Linux
> > as well.
> > 
> > Fixes: 418d1d840e42 ("arm64: dts: freescale: add initial device tree for
> > TQMa8MPQL with i.MX8MP") Signed-off-by: Alexander Stein
> > <alexander.stein@ew.tq-group.com>
> 
> The change looks good, but the Subject should be improved to contain
> the board name:
> 
> arm64: dts: imx8mp-tqma8mpql-mba8mpxl: add missing pinctrl for RTC alarm
> 
> Reviewed-by: Fabio Estevam <festevam@gmail.com>

Thank you for your fast feedback. You are right, the board name is missing and 
I'll add it.

Thanks
Alexander




_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel