Re: [PATCH v2] arm64: dts: rockchip: add HYM8563 RTC to Radxa CM5 IO board

[Heiko Stuebner <heiko@sntech.de>]

Hi Brian,

I've applied the change with some changes.
Please the comments below in mind for future patches, but there is no
need to send another version:


Am Sonntag, 5. Juli 2026, 20:19:19 Mitteleuropäische Sommerzeit schrieb Brian Mayer:
> Hello again, to clarify: I tested the v1 patch in my radxa cm5, but since
> this v2 only contains name changes I didn't test. I added the missing
> agent tag and am sending the patch inline. Thanks.
> 
> The Radxa CM5 IO carrier has a Haoyu HYM8563 real-time clock on I2C6 at
> address 0x51, with its interrupt line on GPIO0_B0 and a CR1220 backup
> battery holder. Without a device tree node, no /dev/rtc* appears even
> when CONFIG_RTC_DRV_HYM8563 is enabled.
> 
> Describe the RTC, wire the interrupt pin with a pull-up, mark it as a
> wakeup source, and point the rtc0 alias at it so RTC_HCTOSYS/SYSTOHC use
> the external clock. Wiring matches Radxa's downstream board support and
> uses schematic names for the rtc_int_l pinctrl entry.

Please way less AI fluff. The patch content show that you're wiring up the
interrupt + pinctrl etc.

Also, please no personal "Hello again ...." in the actual commit message.
The text above is the text that ends up in the git log for your change,
so should be short and to the point.

I've shortened it to:
-----
Describe the Haoyu HYM8563 RTC connected to I2C6 on the Radxa CM5 IO
carrier including its interrupt line.
-----


> Assisted-by: Grok:grok-build
> Signed-off-by: Brian Mayer <bleemayer@gmail.com>
> ---

Personal comments, remarks etc should be here, below the 3 dashes and
above the diffstat. That way we can still read them, but they don't
end up in the git history.


>  .../dts/rockchip/rk3588s-radxa-cm5-io.dts     | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)
> 
> Changes in v2:
> - Rename pinctrl to rtc_int_l / rtc-int-l to match schematics
> - Drop Tested-by (covered by Signed-off-by)
> - Add Assisted-by: Grok:grok-build
> - Send inline with git send-email (not as attachment)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-radxa-cm5-io.dts b/arch/arm64/boot/dts/rockchip/rk3588s-radxa-cm5-io.dts
> index af4a9bc01..d22db4d18 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3588s-radxa-cm5-io.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3588s-radxa-cm5-io.dts
> @@ -19,6 +19,7 @@ / {
>  	aliases {
>  		ethernet0 = &gmac1;
>  		mmc1 = &sdmmc;
> +		rtc0 = &hym8563;
>  	};
>  
>  	chosen {
> @@ -198,6 +199,18 @@ usbc0_dp_altmode_mux: endpoint {
>  			};
>  		};
>  	};
> +
> +	hym8563: rtc@51 {
> +		compatible = "haoyu,hym8563";
> +		reg = <0x51>;
> +		#clock-cells = <0>;
> +		clock-output-names = "hym8563";
> +		interrupt-parent = <&gpio0>;
> +		interrupts = <RK_PB0 IRQ_TYPE_LEVEL_LOW>;
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&rtc_int_l>;
> +		wakeup-source;
> +	};
>  };
>  
>  &i2s5_8ch {
> @@ -221,6 +234,12 @@ usbc0_int: usbc0-int {
>  		};
>  	};
>  
> +	hym8563 {
> +		rtc_int_l: rtc-int-l {
> +			rockchip,pins = <0 RK_PB0 RK_FUNC_GPIO &pcfg_pull_up>;
> +		};
> +	};
> +

please sort nodes alphabetically (hdmi -> hym8563)
I did that when applying.


Thanks
Heiko


>  	hdmi {
>  		hdmi0_tx_on_h: hdmi0-tx-on-h {
>  			rockchip,pins = <4 RK_PB6 RK_FUNC_GPIO &pcfg_pull_none>;
> 
> base-commit: 87320be9f0d24fce67631b7eef919f0b79c3e45c
>