From: Hari Nagalla <hnagalla@ti.com>
To: Nishanth Menon <nm@ti.com>
Cc: <vigneshr@ti.com>, <kristo@kernel.org>, <robh+dt@kernel.org>,
<krzysztof.kozlowski+dt@linaro.org>,
<linux-arm-kernel@lists.infradead.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] arm64: dts: ti: k3-j784s4-main: Add MAIN domain R5F cluster nodes
Date: Wed, 29 Mar 2023 15:19:33 -0500 [thread overview]
Message-ID: <48c03b5a-6557-9eee-8b85-24d72cfbfcd1@ti.com> (raw)
In-Reply-To: <20230329125247.w45k5fjzmcgjdyso@delicate>
On 3/29/23 07:52, Nishanth Menon wrote:
>> MAIN R5FSS0 Core0: j784s4-main-r5f0_0-fw (both in LockStep and Split modes)
>> MAIN R5FSS0 Core1: j784s4-main-r5f0_1-fw (needed only in Split mode)
>> MAIN R5FSS1 Core0: j784s4-main-r5f1_0-fw (both in LockStep and Split modes)
>> MAIN R5FSS1 Core1: j784s4-main-r5f1_1-fw (needed only in Split mode)
>> MAIN R5FSS2 Core0: j784s4-main-r5f2_0-fw (both in LockStep and Split modes)
>> MAIN R5FSS2 Core1: j784s4-main-r5f2_1-fw (needed only in Split mode)
> Why are the patches split up into main and mcu - if you are adding r5f
> cores, do them as a single patch.
>
Thought would be cleaner with separated patches for resolving potential
merge conflicts. But, can combine into one for v2.
>> +
>> + main_r5fss0: r5fss@5c00000 {
>> + compatible = "ti,j721s2-r5fss";
>> + ti,cluster-mode = <1>;
>> + #address-cells = <1>;
>> + #size-cells = <1>;
>> + ranges = <0x5c00000 0x00 0x5c00000 0x20000>,
>> + <0x5d00000 0x00 0x5d00000 0x20000>;
>> + power-domains = <&k3_pds 336 TI_SCI_PD_EXCLUSIVE>;
>> +
>> + main_r5fss0_core0: r5f@5c00000 {
>> + compatible = "ti,j721s2-r5f";
>> + reg = <0x5c00000 0x00010000>,
>> + <0x5c10000 0x00010000>;
>> + reg-names = "atcm", "btcm";
>> + ti,sci = <&sms>;
>> + ti,sci-dev-id = <339>;
>> + ti,sci-proc-ids = <0x06 0xff>;
>> + resets = <&k3_reset 339 1>;
>> + firmware-name = "j784s4-main-r5f0_0-fw";
>> + ti,atcm-enable = <1>;
>> + ti,btcm-enable = <1>;
>> + ti,loczrama = <1>;
>> + status = "disabled";
> Why are these disabled by default?
Well, the idea is to let the board specific device tree enable needed
remote core nodes in *-evm/sk.dts and disable by default in SoC device
tree files by default.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-03-29 20:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-29 9:36 [PATCH 0/3] Add R5F and C71 DSP nodes for J784S4 SoC Hari Nagalla
2023-03-29 9:36 ` [PATCH 1/3] arm64: dts: ti: k3-j784s4-main: Add MAIN domain R5F cluster nodes Hari Nagalla
2023-03-29 12:52 ` Nishanth Menon
2023-03-29 20:19 ` Hari Nagalla [this message]
2023-03-29 21:55 ` Nishanth Menon
2023-03-29 9:36 ` [PATCH 2/3] arm64: dts: ti: k3-j784s4-mcu: Add MCU domain R5F cluster node Hari Nagalla
2023-03-29 12:51 ` Nishanth Menon
2023-03-29 9:36 ` [PATCH 3/3] arm64: dts: ti: k3-j784s4-main: Add C71x DSP nodes Hari Nagalla
2023-03-29 12:50 ` Nishanth Menon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48c03b5a-6557-9eee-8b85-24d72cfbfcd1@ti.com \
--to=hnagalla@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=kristo@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nm@ti.com \
--cc=robh+dt@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox