From: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: Sascha Hauer <s.hauer@pengutronix.de>,
linux-kernel <linux-kernel@vger.kernel.org>,
NXP Linux Team <linux-imx@nxp.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Shawn Guo <shawnguo@kernel.org>,
"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: (EXT) Re: [PATCH 2/2] ARM: dts: imx6qdl: tqma6: minor fixes
Date: Tue, 25 Aug 2020 09:22:23 +0200 [thread overview]
Message-ID: <4b7d57738ce8e2130c4740a0f3f973fbaf60a7cf.camel@ew.tq-group.com> (raw)
In-Reply-To: <CAOMZO5DSX1pf3xxo=CGvgPmHcjMJoWFx74grVJBckSmjtF-RGg@mail.gmail.com>
On Mon, 2020-08-24 at 18:36 -0300, Fabio Estevam wrote:
> Hi Matthias,
>
> On Mon, Aug 24, 2020 at 6:10 AM Matthias Schiffer
> <matthias.schiffer@ew.tq-group.com> wrote:
>
> > diff --git a/arch/arm/boot/dts/imx6qdl-tqma6.dtsi
> > b/arch/arm/boot/dts/imx6qdl-tqma6.dtsi
> > index 9513020ddd1a..7aaae83c1fae 100644
> > --- a/arch/arm/boot/dts/imx6qdl-tqma6.dtsi
> > +++ b/arch/arm/boot/dts/imx6qdl-tqma6.dtsi
> > @@ -20,7 +20,7 @@
> > &ecspi1 {
> > pinctrl-names = "default";
> > pinctrl-0 = <&pinctrl_ecspi1>;
> > - fsl,spi-num-chipselects = <1>;
> > + num-cs = <1>;
>
> You could simply remove fsl,spi-num-chipselects without passing num-
> cs.
>
> The spi core is able to count the number of chipselects passed via
> cs-gpios in the device tree.
Hmm, unless I'm overlooking something, this is not going to work:
- spi_get_gpio_descs() sets num_chipselect to the maximum of the
num_chipselect set in the driver and the number of cs-gpios
- spi_imx_probe() sets num_chipselect to 3 if not specified in the
device tree
So I think we would end up with 3 instead of 1 chipselect.
Kind regards,
Matthias
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-08-25 7:23 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-24 9:10 [PATCH 1/2] ARM: dts: imx6qdl: tqma6: fix indentation Matthias Schiffer
2020-08-24 9:10 ` [PATCH 2/2] ARM: dts: imx6qdl: tqma6: minor fixes Matthias Schiffer
2020-08-24 21:36 ` Fabio Estevam
2020-08-25 7:22 ` Matthias Schiffer [this message]
2020-08-25 14:24 ` (EXT) " Fabio Estevam
2020-08-25 14:40 ` (EXT) " Matthias Schiffer
2020-08-25 17:16 ` Fabio Estevam
2020-08-26 10:32 ` (EXT) " Matthias Schiffer
2020-08-26 10:34 ` Matthias Schiffer
2020-08-26 10:59 ` Fabio Estevam
2020-08-26 11:54 ` (EXT) " Matthias Schiffer
2020-08-26 13:01 ` Fabio Estevam
2020-08-26 13:13 ` (EXT) " Matthias Schiffer
2020-08-26 13:49 ` Fabio Estevam
2020-08-27 7:31 ` Matthias Schiffer
2020-08-27 21:27 ` Fabio Estevam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4b7d57738ce8e2130c4740a0f3f973fbaf60a7cf.camel@ew.tq-group.com \
--to=matthias.schiffer@ew.tq-group.com \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox