From: Andrew Lunn <andrew@lunn.ch>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org,
Algea Cao <algea.cao@rock-chips.com>,
Andy Yan <andy.yan@rock-chips.com>,
Cenk Uluisik <cenk.uluisik@googlemail.com>,
Conor Dooley <conor+dt@kernel.org>,
Cristian Ciocaltea <cristian.ciocaltea@collabora.com>,
Heiko Stuebner <heiko@sntech.de>,
Jimmy Hon <honyuenkwun@gmail.com>,
Kever Yang <kever.yang@rock-chips.com>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Maxime Ripard <mripard@kernel.org>,
Muhammed Efe Cetin <efectn@6tel.net>, Ondrej Jirman <megi@xff.cz>,
Rob Herring <robh@kernel.org>, Sandy Huang <hjc@rock-chips.com>
Subject: Re: [PATCH 3/3] arm64: dts: rockchip: Add rk3588s-orangepi-cm5-base device tree
Date: Mon, 6 Oct 2025 18:06:21 +0200 [thread overview]
Message-ID: <4d337915-e3a9-46b7-a30b-ccb47ad33556@lunn.ch> (raw)
In-Reply-To: <20251002034708.19248-4-laurent.pinchart@ideasonboard.com>
> +&gmac1 {
> + clock_in_out = "output";
> + phy-handle = <&rgmii_phy>;
> + phy-mode = "rgmii-id";
> + phy-supply = <&vcc_3v3>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&gmac1_miim
> + &gmac1_rx_bus2
> + &gmac1_tx_bus2
> + &gmac1_rgmii_clk
> + &gmac1_rgmii_bus>;
> + tx_delay = <0x42>;
Nice to see phy-mode 'rgmii-id', but 0x42 is pretty high in comparison
to other boards correctly using 'rgmii-id', and is asymmetric with no
rx_delay value.
I cannot say this is wrong, it is just odd, not what i would expect.
Andrew
next prev parent reply other threads:[~2025-10-06 16:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-02 3:47 [PATCH 0/3] arm64: dts: rockchip: Add device tree for the Orange Pi CM5 Base board Laurent Pinchart
2025-10-02 3:47 ` [PATCH 1/3] dt-bindings: arm: rockchip: Add Orange Pi CM5 Base Laurent Pinchart
2025-10-02 18:30 ` Conor Dooley
2025-10-02 3:47 ` [PATCH 2/3] dt-bindings: display: rk3588-dw-hdmi-qp: Document enable-gpios property Laurent Pinchart
2025-10-02 18:30 ` Conor Dooley
2025-10-02 3:47 ` [PATCH 3/3] arm64: dts: rockchip: Add rk3588s-orangepi-cm5-base device tree Laurent Pinchart
2025-10-03 0:01 ` Jimmy Hon
2025-10-03 2:39 ` Laurent Pinchart
2025-10-04 2:47 ` Jimmy Hon
2025-10-04 22:12 ` Laurent Pinchart
2025-10-06 16:06 ` Andrew Lunn [this message]
2025-10-06 16:24 ` Laurent Pinchart
2025-10-02 19:24 ` [PATCH 0/3] arm64: dts: rockchip: Add device tree for the Orange Pi CM5 Base board Cristian Ciocaltea
2025-10-02 20:52 ` Laurent Pinchart
2025-10-02 21:56 ` Cristian Ciocaltea
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4d337915-e3a9-46b7-a30b-ccb47ad33556@lunn.ch \
--to=andrew@lunn.ch \
--cc=algea.cao@rock-chips.com \
--cc=andy.yan@rock-chips.com \
--cc=cenk.uluisik@googlemail.com \
--cc=conor+dt@kernel.org \
--cc=cristian.ciocaltea@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=efectn@6tel.net \
--cc=heiko@sntech.de \
--cc=hjc@rock-chips.com \
--cc=honyuenkwun@gmail.com \
--cc=kever.yang@rock-chips.com \
--cc=krzk+dt@kernel.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=megi@xff.cz \
--cc=mripard@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox