Re: [RFT PATCH v2 3/7] perf-x86: iostat: Move iostat arch-specific implementation to util

[Yushan Wang <wangyushan12@huawei.com>]

 On 5/7/2026 11:35 PM, Ian Rogers wrote:
> On Wed, May 6, 2026 at 11:37 PM Yushan Wang <wangyushan12@huawei.com> wrote:
>>
>> To support cross-platform iostat capabilities, like record/report on
>> different platforms, architecture-specific implementation of iostat
>> should be moved out of arch directory to get built. Build scripts are
>> changed accordingly.
>>
>> Signed-off-by: Yushan Wang <wangyushan12@huawei.com>
>> ---
>>  tools/perf/arch/x86/util/Build                           | 1 -
>>  tools/perf/util/Build                                    | 1 +
>>  tools/perf/{arch/x86/util/iostat.c => util/x86-iostat.c} | 0
>>  3 files changed, 1 insertion(+), 1 deletion(-)
>>  rename tools/perf/{arch/x86/util/iostat.c => util/x86-iostat.c} (100%)
>
> To avoid cluttering up tools/perf/util, would it make sense to create
> a "tools/perf/util/iostat-arch" directory similar to  annotate-arch,
> dwarf-regs-arch, kvm-stat-arch and perf-regs-arch?
>
> Thanks,
> Ian

Yes, I can do that in the next version.

In fact, as what latter comments addressed, I think merging these iostat
handlers into one source file to avoid redundancy may be better.

Thanks,
Yushan

>