Re: [RFT PATCH v2 4/7] perf-x86: iostat: Change iostat_prefix() to static

[Yushan Wang <wangyushan12@huawei.com>]

On 5/7/2026 11:39 PM, Ian Rogers wrote:
> On Wed, May 6, 2026 at 11:37 PM Yushan Wang <wangyushan12@huawei.com> wrote:
>>
>> Change iostat_prefix() to static function, since it is not used outside.
>>
>> Signed-off-by: Yushan Wang <wangyushan12@huawei.com>
>
> Reviewed-by: Ian Rogers <irogers@google.com>
>
>> ---
>>  tools/perf/util/iostat.c     |  7 ------
>>  tools/perf/util/iostat.h     |  2 --
>>  tools/perf/util/x86-iostat.c | 44 ++++++++++++++++++------------------
>>  3 files changed, 22 insertions(+), 31 deletions(-)
>>
>> diff --git a/tools/perf/util/iostat.c b/tools/perf/util/iostat.c
>> index b770bd473af7..a68ab100780d 100644
>> --- a/tools/perf/util/iostat.c
>> +++ b/tools/perf/util/iostat.c
>> @@ -37,13 +37,6 @@ __weak void iostat_print_metric(struct perf_stat_config *config __maybe_unused,
>>  {
>>  }
>>
>> -__weak void iostat_prefix(struct evlist *evlist __maybe_unused,
>> -                         struct perf_stat_config *config __maybe_unused,
>> -                         char *prefix __maybe_unused,
>> -                         struct timespec *ts __maybe_unused)
>> -{
>> -}
>> -
>>  __weak void iostat_print_counters(struct evlist *evlist __maybe_unused,
>>                                   struct perf_stat_config *config __maybe_unused,
>>                                   struct timespec *ts __maybe_unused,
>
> This change doesn't remove the weak symbols, but they should go. We
> should use the ELF machine to determine which architecture version to
> use.

The weak symbols are removed in patch 6. Reserving them here keeps this patch
from failing perf build :)

Thanks,
Yushan

>
> Thanks,
> Ian
>

[...]