* [PATCH] media: stm32: dcmipp: Propagate runtime resume errors
@ 2026-07-04 7:17 Pengpeng Hou
2026-07-04 7:44 ` Markus Elfring
0 siblings, 1 reply; 2+ messages in thread
From: Pengpeng Hou @ 2026-07-04 7:17 UTC (permalink / raw)
To: Hugues Fruchet, Alain Volmat, Mauro Carvalho Chehab,
Maxime Coquelin, Alexandre Torgue, linux-media, linux-stm32,
linux-arm-kernel, linux-kernel
Cc: Pengpeng Hou
dcmipp_runtime_resume() can fail while preparing the device clocks, but
dcmipp_resume() currently ignores the result of
pm_runtime_force_resume() and always returns success.
Return the pm_runtime_force_resume() result so system resume does not
hide a failed runtime resume.
Signed-off-by: Pengpeng Hou <pengpeng@iscas.ac.cn>
---
drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-core.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-core.c b/drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-core.c
index 49398d077764..516334541b2c 100644
--- a/drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-core.c
+++ b/drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-core.c
@@ -649,9 +649,7 @@ static int dcmipp_resume(struct device *dev)
pinctrl_pm_select_default_state(dev);
/* clock enable */
- pm_runtime_force_resume(dev);
-
- return 0;
+ return pm_runtime_force_resume(dev);
}
static const struct dev_pm_ops dcmipp_pm_ops = {
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] media: stm32: dcmipp: Propagate runtime resume errors
2026-07-04 7:17 [PATCH] media: stm32: dcmipp: Propagate runtime resume errors Pengpeng Hou
@ 2026-07-04 7:44 ` Markus Elfring
0 siblings, 0 replies; 2+ messages in thread
From: Markus Elfring @ 2026-07-04 7:44 UTC (permalink / raw)
To: Pengpeng Hou, linux-media, linux-arm-kernel, linux-stm32,
Alain Volmat, Alexandre Torgue, Hugues Fruchet,
Mauro Carvalho Chehab, Maxime Coquelin
Cc: LKML
…
> Return the pm_runtime_force_resume() result so system resume does not
> hide a failed runtime resume.
How do you think about to add any tags (like “Fixes” and “Cc”) accordingly?
See also:
* https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v7.2-rc1#n145
* https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/stable-kernel-rules.rst?h=v7.2-rc1#n34
Regards,
Markus
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-07-04 7:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-04 7:17 [PATCH] media: stm32: dcmipp: Propagate runtime resume errors Pengpeng Hou
2026-07-04 7:44 ` Markus Elfring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox