* [PATCH] drivers/built-in.o: In function `qcom_smp2p_intr':
@ 2015-11-20 9:43 Arnd Bergmann
2015-11-20 10:29 ` Arnd Bergmann
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2015-11-20 9:43 UTC (permalink / raw)
To: linux-arm-kernel
The newly added smp2p and smsm drivers cannot be loadable modules
but depend on smem, which can be, and that causes a link error:
:(.text+0xa6e68): undefined reference to `qcom_smem_get'
drivers/built-in.o: In function `qcom_smp2p_probe':
:(.text+0xa7320): undefined reference to `qcom_smem_alloc'
:(.text+0xa736c): undefined reference to `qcom_smem_get'
drivers/built-in.o: In function `qcom_smsm_probe':
:(.text+0xa7b34): undefined reference to `qcom_smem_get'
This marks all the drivers as 'tristate' to make the Kconfig
dependency resolution work properly.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: dbb04bd7122f ("soc: qcom: smp2p: Qualcomm Shared Memory Point to Point")
Fixes: d7387fc6add4 ("soc: qcom: smsm: Add driver for Qualcomm SMSM")
---
This showed up on arm allmodconfig with linux-next today, please apply or fold
into the original patches.
diff --git a/drivers/soc/qcom/Kconfig b/drivers/soc/qcom/Kconfig
index b57be7ab50b6..57b7145358e7 100644
--- a/drivers/soc/qcom/Kconfig
+++ b/drivers/soc/qcom/Kconfig
@@ -54,7 +54,7 @@ config QCOM_SMEM_STATE
bool
config QCOM_SMP2P
- bool "Qualcomm Shared Memory Point to Point support"
+ tristate "Qualcomm Shared Memory Point to Point support"
depends on QCOM_SMEM
select QCOM_SMEM_STATE
help
@@ -62,7 +62,7 @@ config QCOM_SMP2P
protocol.
config QCOM_SMSM
- bool "Qualcomm Shared Memory State Machine"
+ tristate "Qualcomm Shared Memory State Machine"
depends on QCOM_SMEM
select QCOM_SMEM_STATE
help
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] drivers/built-in.o: In function `qcom_smp2p_intr':
2015-11-20 9:43 [PATCH] drivers/built-in.o: In function `qcom_smp2p_intr': Arnd Bergmann
@ 2015-11-20 10:29 ` Arnd Bergmann
0 siblings, 0 replies; 2+ messages in thread
From: Arnd Bergmann @ 2015-11-20 10:29 UTC (permalink / raw)
To: linux-arm-kernel
On Friday 20 November 2015 10:43:00 Arnd Bergmann wrote:
> The newly added smp2p and smsm drivers cannot be loadable modules
> but depend on smem, which can be, and that causes a link error:
>
Sorry, $SUBJECT is wrong, I'll resend.
Arnd
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-11-20 10:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-20 9:43 [PATCH] drivers/built-in.o: In function `qcom_smp2p_intr': Arnd Bergmann
2015-11-20 10:29 ` Arnd Bergmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox