From: Andrew Lunn <andrew@lunn.ch>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Alexander Clouter <alex@digriz.org.uk>,
Gregory Clement <gregory.clement@bootlin.com>,
Russell King <linux@armlinux.org.uk>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Andy Shevchenko <andy@kernel.org>, Kees Cook <kees@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arm: orion5x: use string choices helper
Date: Tue, 17 Jun 2025 04:06:24 +0200 [thread overview]
Message-ID: <520f1391-a107-4705-bb11-02912cbc3b98@lunn.ch> (raw)
In-Reply-To: <87h60fnoct.wl-kuninori.morimoto.gx@renesas.com>
On Tue, Jun 17, 2025 at 01:33:38AM +0000, Kuninori Morimoto wrote:
>
> Hi Andrew
>
> Thank you for your review
>
> > > - return sprintf(buf, "%s\n", (ts78xx_fpga.state) ? "online" : "offline");
> > > + return sprintf(buf, "%sline\n", str_on_off(ts78xx_fpga.state));
> >
> > static inline const char *str_on_off(bool v)
> > {
> > return v ? "on" : "off";
> > }
> >
> > That is an ABI change. Sorry, but NACK.
>
> It updates format too, I guess it keeps "online/offline" ?
>
> - return sprintf(buf, "%s\n", ...
> + return sprintf(buf, "%sline\n", ...
> ^^^^
>
> Thank you for your help !!
Ah, missed that, but you should of also mentioned it in the commit
message....
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next prev parent reply other threads:[~2025-06-17 2:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-17 0:07 [PATCH] arm: orion5x: use string choices helper Kuninori Morimoto
2025-06-17 1:28 ` Andrew Lunn
2025-06-17 1:33 ` Kuninori Morimoto
2025-06-17 2:06 ` Andrew Lunn [this message]
2025-06-17 2:13 ` Kuninori Morimoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=520f1391-a107-4705-bb11-02912cbc3b98@lunn.ch \
--to=andrew@lunn.ch \
--cc=alex@digriz.org.uk \
--cc=andy@kernel.org \
--cc=gregory.clement@bootlin.com \
--cc=kees@kernel.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=sebastian.hesselbarth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox