From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Alexander Clouter <alex@digriz.org.uk>,
Gregory Clement <gregory.clement@bootlin.com>,
Russell King <linux@armlinux.org.uk>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Andy Shevchenko <andy@kernel.org>, Kees Cook <kees@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arm: orion5x: use string choices helper
Date: Tue, 17 Jun 2025 01:33:38 +0000 [thread overview]
Message-ID: <87h60fnoct.wl-kuninori.morimoto.gx@renesas.com> (raw)
In-Reply-To: <eaa1038b-9a3e-4f42-abaf-8bb8b92aa482@lunn.ch>
Hi Andrew
Thank you for your review
> > - return sprintf(buf, "%s\n", (ts78xx_fpga.state) ? "online" : "offline");
> > + return sprintf(buf, "%sline\n", str_on_off(ts78xx_fpga.state));
>
> static inline const char *str_on_off(bool v)
> {
> return v ? "on" : "off";
> }
>
> That is an ABI change. Sorry, but NACK.
It updates format too, I guess it keeps "online/offline" ?
- return sprintf(buf, "%s\n", ...
+ return sprintf(buf, "%sline\n", ...
^^^^
Thank you for your help !!
Best regards
---
Kuninori Morimoto
next prev parent reply other threads:[~2025-06-17 1:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-17 0:07 [PATCH] arm: orion5x: use string choices helper Kuninori Morimoto
2025-06-17 1:28 ` Andrew Lunn
2025-06-17 1:33 ` Kuninori Morimoto [this message]
2025-06-17 2:06 ` Andrew Lunn
2025-06-17 2:13 ` Kuninori Morimoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h60fnoct.wl-kuninori.morimoto.gx@renesas.com \
--to=kuninori.morimoto.gx@renesas.com \
--cc=alex@digriz.org.uk \
--cc=andrew@lunn.ch \
--cc=andy@kernel.org \
--cc=gregory.clement@bootlin.com \
--cc=kees@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=sebastian.hesselbarth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox