From: Joe Perches <joe@perches.com>
To: Dan Carpenter <dan.carpenter@oracle.com>,
Jiri Slaby <jirislaby@kernel.org>,
Julia Lawall <Julia.Lawall@inria.fr>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] mxser: use semi-colons instead of commas
Date: Wed, 25 Aug 2021 03:30:00 -0700 [thread overview]
Message-ID: <53afc244281b6a76aecf4a5565d7e6395e376d4e.camel@perches.com> (raw)
In-Reply-To: <20210825072435.GB13013@kili>
On Wed, 2021-08-25 at 10:24 +0300, Dan Carpenter wrote:
> This code works, but it's cleaner to use semi-colons at the end of
> a statement instead of a comma.
There are still multiple dozens of this type of comma use
in the kernel.
Julia Lawall created a cocci script to convert the commas
to semicolons that worked pretty well.
https://lore.kernel.org/lkml/alpine.DEB.2.22.394.2008201856110.2524@hadrien/
> diff --git a/drivers/tty/mxser.c b/drivers/tty/mxser.c
[]
> @@ -1039,12 +1039,12 @@ static int mxser_get_serial_info(struct tty_struct *tty,
> if (closing_wait != ASYNC_CLOSING_WAIT_NONE)
> closing_wait = jiffies_to_msecs(closing_wait) / 10;
>
>
> - ss->type = info->type,
> - ss->line = tty->index,
> - ss->port = info->ioaddr,
> - ss->irq = info->board->irq,
> - ss->flags = info->port.flags,
> - ss->baud_base = MXSER_BAUD_BASE,
> + ss->type = info->type;
> + ss->line = tty->index;
> + ss->port = info->ioaddr;
> + ss->irq = info->board->irq;
> + ss->flags = info->port.flags;
> + ss->baud_base = MXSER_BAUD_BASE;
> ss->close_delay = close_delay;
> ss->closing_wait = closing_wait;
> ss->custom_divisor = MXSER_CUSTOM_DIVISOR,
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-08-25 10:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-25 7:24 [PATCH] mxser: use semi-colons instead of commas Dan Carpenter
2021-08-25 10:30 ` Joe Perches [this message]
2021-08-25 12:57 ` Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53afc244281b6a76aecf4a5565d7e6395e376d4e.camel@perches.com \
--to=joe@perches.com \
--cc=Julia.Lawall@inria.fr \
--cc=dan.carpenter@oracle.com \
--cc=festevam@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox