From: Marc Gonzalez <marc.w.gonzalez@free.fr>
To: Stanley Chu <stanley.chu@mediatek.com>,
linux-scsi@vger.kernel.org, martin.petersen@oracle.com,
avri.altman@wdc.com, alim.akhtar@samsung.com,
pedrom.sousa@synopsys.com
Cc: andy.teng@mediatek.com, chun-hung.wu@mediatek.com,
kuohong.wang@mediatek.com, evgreen@chromium.org,
subhashj@codeaurora.org, linux-mediatek@lists.infradead.org,
peter.wang@mediatek.com, vivek.gautam@codeaurora.org,
matthias.bgg@gmail.com, sayalil@codeaurora.org,
linux-arm-kernel@lists.infradead.org, beanhuo@micron.com
Subject: Re: [PATCH v1 0/3] scsi: ufs: add error handlings of auto-hibern8
Date: Mon, 13 May 2019 16:51:04 +0200 [thread overview]
Message-ID: <55818bc4-d464-bb35-25bb-9ef87af8224e@free.fr> (raw)
In-Reply-To: <1557758186-18706-1-git-send-email-stanley.chu@mediatek.com>
On 13/05/2019 16:36, Stanley Chu wrote:
> Currently auto-hibern8 is activated if host supports
> auto-hibern8 capability. However no error handlings are existed thus
> this feature is kind of risky.
This last sentence is not very idiomatic.
I would suggest:
"However, error-handling is not implemented, which makes the feature
somewhat risky."
> If "Hibernate Enter" or "Hibernate Exit" fail happens
I would suggest:
If either "Hibernate Enter" or "Hibernate Exit" fail during ...
> during auto-hibern8 flow, the corresponding interrupt
> "UIC_HIBERNATE_ENTER" or "UIC_HIBERNATE_EXIT" shall be raised
> according to UFS specification.
>
> This patch adds auto-hibern8 error handlings:
error-handling
> - Monitor "Hibernate Enter" and "Hibernate Exit" interrupts after
> auto-hibern8 feature is activated.
I just want to take this opportunity to ask a rhetorical question.
Who in the Great Heavens thought it would be a good idea to call the
feature "auto-hibern8" ?
Was it really worth it to save 2 characters by writing "8" instead
of "ate" ?
This bugs me so much that I just might send a patch to fix it up.
Regards.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-05-13 14:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-13 14:36 [PATCH v1 0/3] scsi: ufs: add error handlings of auto-hibern8 Stanley Chu
2019-05-13 14:36 ` [PATCH v1 1/3] scsi: ufs: do not overwrite auto-hibern8 timer Stanley Chu
2019-05-13 14:36 ` [PATCH v1 2/3] scsi: ufs: add error handling of auto-hibern8 Stanley Chu
2019-05-13 18:21 ` [EXT] " Bean Huo (beanhuo)
2019-05-14 6:58 ` Stanley Chu
2019-05-14 11:14 ` Bean Huo (beanhuo)
2019-05-15 2:52 ` Stanley Chu
2019-05-13 14:36 ` [PATCH v1 3/3] scsi: ufs: use re-factored auto_hibern8 function Stanley Chu
2019-05-13 14:51 ` Marc Gonzalez [this message]
2019-05-14 6:25 ` [PATCH v1 0/3] scsi: ufs: add error handlings of auto-hibern8 Stanley Chu
2019-05-20 5:58 ` Avri Altman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55818bc4-d464-bb35-25bb-9ef87af8224e@free.fr \
--to=marc.w.gonzalez@free.fr \
--cc=alim.akhtar@samsung.com \
--cc=andy.teng@mediatek.com \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=chun-hung.wu@mediatek.com \
--cc=evgreen@chromium.org \
--cc=kuohong.wang@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=matthias.bgg@gmail.com \
--cc=pedrom.sousa@synopsys.com \
--cc=peter.wang@mediatek.com \
--cc=sayalil@codeaurora.org \
--cc=stanley.chu@mediatek.com \
--cc=subhashj@codeaurora.org \
--cc=vivek.gautam@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox