From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] dma: of: Move the functions under CONFIG_OF_DMA instead of CONFIG_OF
Date: Fri, 28 Feb 2014 15:47:34 +0100 [thread overview]
Message-ID: <5615884.O4eVkOuQqe@wuerfel> (raw)
In-Reply-To: <53109C1B.2030606@ti.com>
On Friday 28 February 2014 09:24:27 Santosh Shilimkar wrote:
> So for ARM 'allnoconfig' build we have CONFIG_OF enabled but
> CONFIG_DMA_OF disabled. With that the of-dma.c gets compiled
> out leaving the functions from of-dma.h undefined. I noticed
> this while adding couple of exports in of_dma.h
Looking at current linux-next, I find
Kconfig:
menuconfig DMADEVICES
bool "DMA Engine support"
...
if DMADEVICES
config DMA_OF
def_bool y
depends on OF
endif
This means that DMA_OF is disabled in 'allnoconfig' since DMADEVICES
is also disabled, as you say. The Makefile looks like
obj-$(CONFIG_DMA_OF) += of-dma.o
As of 5fa422c922c25 "dmaengine: move drivers/of/dma.c -> drivers/dma/of-dma.c"
which seems to solve the problem already.
> I am not sure but we added couple of functions for dma-ranges
> and dma-coherent which gets called from generic code.
These functions have nothing to do with the dmaengine code though,
they should be in a different file.
Arnd
next prev parent reply other threads:[~2014-02-28 14:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-28 0:20 [PATCH] dma: of: Move the functions under CONFIG_OF_DMA instead of CONFIG_OF Santosh Shilimkar
2014-02-28 0:27 ` Santosh Shilimkar
2014-02-28 9:23 ` Arnd Bergmann
2014-02-28 14:24 ` Santosh Shilimkar
2014-02-28 14:47 ` Arnd Bergmann [this message]
2014-02-28 15:03 ` Santosh Shilimkar
2014-02-28 15:21 ` Arnd Bergmann
2014-02-28 15:25 ` Santosh Shilimkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5615884.O4eVkOuQqe@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox