From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] dma: of: Move the functions under CONFIG_OF_DMA instead of CONFIG_OF
Date: Fri, 28 Feb 2014 10:23:06 +0100 [thread overview]
Message-ID: <6287295.Q1WPJPjeZV@wuerfel> (raw)
In-Reply-To: <530FD7D7.9000104@ti.com>
On Thursday 27 February 2014 19:27:03 Santosh Shilimkar wrote:
>
> The of-dma.c is compiled out with !CONFIG_DMA_OF but the functions in
> the header are kept under CONFIG_OF. Move them under CONFIG_OF_DMA
> to avoid build errors with CONFIG_OFF && !CONFIG_DMA_OF
>
> Cc: Grant Likely <grant.likely@linaro.org>
> Cc: Rob Herring <robh+dt@kernel.org>
> Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
Sorry, but what is the problem you are seeing with this?
CONFIG_DMA_OF is defined as 'OF && DMAENGINE', and this code
should only be called from drivers that depend on DMAENGINE.
I'm not saying your patch is wrong, but you shouldn't need it
unless you do something very odd.
Arnd
next prev parent reply other threads:[~2014-02-28 9:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-28 0:20 [PATCH] dma: of: Move the functions under CONFIG_OF_DMA instead of CONFIG_OF Santosh Shilimkar
2014-02-28 0:27 ` Santosh Shilimkar
2014-02-28 9:23 ` Arnd Bergmann [this message]
2014-02-28 14:24 ` Santosh Shilimkar
2014-02-28 14:47 ` Arnd Bergmann
2014-02-28 15:03 ` Santosh Shilimkar
2014-02-28 15:21 ` Arnd Bergmann
2014-02-28 15:25 ` Santosh Shilimkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6287295.Q1WPJPjeZV@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox