* [PATCH] arm64: dts: imx8mp: Align both CSI2 pixel clock @ 2024-04-05 20:22 Marek Vasut 2024-04-05 20:42 ` Laurent Pinchart 0 siblings, 1 reply; 6+ messages in thread From: Marek Vasut @ 2024-04-05 20:22 UTC (permalink / raw) To: linux-arm-kernel Cc: Marek Vasut, Conor Dooley, Fabio Estevam, Krzysztof Kozlowski, Laurent Pinchart, Paul Elder, Pengutronix Kernel Team, Rob Herring, Sascha Hauer, Shawn Guo, devicetree, imx Configure both CSI2 assigned-clock-rates the same way. There does not seem to be any reason for keeping the two CSI2 pixel clock set to different frequencies. Signed-off-by: Marek Vasut <marex@denx.de> --- Cc: Conor Dooley <conor+dt@kernel.org> Cc: Fabio Estevam <festevam@gmail.com> Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Cc: Paul Elder <paul.elder@ideasonboard.com> Cc: Pengutronix Kernel Team <kernel@pengutronix.de> Cc: Rob Herring <robh@kernel.org> Cc: Sascha Hauer <s.hauer@pengutronix.de> Cc: Shawn Guo <shawnguo@kernel.org> Cc: devicetree@vger.kernel.org Cc: imx@lists.linux.dev Cc: linux-arm-kernel@lists.infradead.org --- arch/arm64/boot/dts/freescale/imx8mp.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi index 1bb96e96639f2..2e9ce0c3a9815 100644 --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi @@ -1703,7 +1703,7 @@ mipi_csi_1: csi@32e50000 { <&clk IMX8MP_CLK_MEDIA_MIPI_PHY1_REF>; assigned-clock-parents = <&clk IMX8MP_SYS_PLL2_1000M>, <&clk IMX8MP_CLK_24M>; - assigned-clock-rates = <266000000>; + assigned-clock-rates = <500000000>; power-domains = <&media_blk_ctrl IMX8MP_MEDIABLK_PD_MIPI_CSI2_2>; status = "disabled"; -- 2.43.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: dts: imx8mp: Align both CSI2 pixel clock 2024-04-05 20:22 [PATCH] arm64: dts: imx8mp: Align both CSI2 pixel clock Marek Vasut @ 2024-04-05 20:42 ` Laurent Pinchart 2024-04-05 21:04 ` Adam Ford 0 siblings, 1 reply; 6+ messages in thread From: Laurent Pinchart @ 2024-04-05 20:42 UTC (permalink / raw) To: Marek Vasut Cc: linux-arm-kernel, Conor Dooley, Fabio Estevam, Krzysztof Kozlowski, Paul Elder, Pengutronix Kernel Team, Rob Herring, Sascha Hauer, Shawn Guo, devicetree, imx, Adam Ford Hi Marek, (CC'ing Adam) Thank you for the patch. On Fri, Apr 05, 2024 at 10:22:26PM +0200, Marek Vasut wrote: > Configure both CSI2 assigned-clock-rates the same way. > There does not seem to be any reason for keeping the > two CSI2 pixel clock set to different frequencies. There's an issue when using two cameras concurrently. This has been discussed some time ago on the linux-media mailing list, see [1]. Adam knows more than I do on this topic. [1] https://lore.kernel.org/linux-media/CAHCN7x+kymRGO2kxvN2=zLiqRjfTc3hdf3VdNVkWjsW3La0bnA@mail.gmail.com/ > Signed-off-by: Marek Vasut <marex@denx.de> > --- > Cc: Conor Dooley <conor+dt@kernel.org> > Cc: Fabio Estevam <festevam@gmail.com> > Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> > Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > Cc: Paul Elder <paul.elder@ideasonboard.com> > Cc: Pengutronix Kernel Team <kernel@pengutronix.de> > Cc: Rob Herring <robh@kernel.org> > Cc: Sascha Hauer <s.hauer@pengutronix.de> > Cc: Shawn Guo <shawnguo@kernel.org> > Cc: devicetree@vger.kernel.org > Cc: imx@lists.linux.dev > Cc: linux-arm-kernel@lists.infradead.org > --- > arch/arm64/boot/dts/freescale/imx8mp.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi > index 1bb96e96639f2..2e9ce0c3a9815 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi > @@ -1703,7 +1703,7 @@ mipi_csi_1: csi@32e50000 { > <&clk IMX8MP_CLK_MEDIA_MIPI_PHY1_REF>; > assigned-clock-parents = <&clk IMX8MP_SYS_PLL2_1000M>, > <&clk IMX8MP_CLK_24M>; > - assigned-clock-rates = <266000000>; > + assigned-clock-rates = <500000000>; > power-domains = <&media_blk_ctrl IMX8MP_MEDIABLK_PD_MIPI_CSI2_2>; > status = "disabled"; > -- Regards, Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: dts: imx8mp: Align both CSI2 pixel clock 2024-04-05 20:42 ` Laurent Pinchart @ 2024-04-05 21:04 ` Adam Ford 2024-04-06 2:58 ` Marek Vasut 0 siblings, 1 reply; 6+ messages in thread From: Adam Ford @ 2024-04-05 21:04 UTC (permalink / raw) To: Laurent Pinchart Cc: Marek Vasut, linux-arm-kernel, Conor Dooley, Fabio Estevam, Krzysztof Kozlowski, Paul Elder, Pengutronix Kernel Team, Rob Herring, Sascha Hauer, Shawn Guo, devicetree, imx On Fri, Apr 5, 2024 at 3:43 PM Laurent Pinchart <laurent.pinchart@ideasonboard.com> wrote: > > Hi Marek, > > (CC'ing Adam) > > Thank you for the patch. > > On Fri, Apr 05, 2024 at 10:22:26PM +0200, Marek Vasut wrote: > > Configure both CSI2 assigned-clock-rates the same way. > > There does not seem to be any reason for keeping the > > two CSI2 pixel clock set to different frequencies. > > There's an issue when using two cameras concurrently. This has been > discussed some time ago on the linux-media mailing list, see [1]. Adam > knows more than I do on this topic. > > [1] https://lore.kernel.org/linux-media/CAHCN7x+kymRGO2kxvN2=zLiqRjfTc3hdf3VdNVkWjsW3La0bnA@mail.gmail.com/ > > > Signed-off-by: Marek Vasut <marex@denx.de> > > --- > > Cc: Conor Dooley <conor+dt@kernel.org> > > Cc: Fabio Estevam <festevam@gmail.com> > > Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> > > Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > Cc: Paul Elder <paul.elder@ideasonboard.com> > > Cc: Pengutronix Kernel Team <kernel@pengutronix.de> > > Cc: Rob Herring <robh@kernel.org> > > Cc: Sascha Hauer <s.hauer@pengutronix.de> > > Cc: Shawn Guo <shawnguo@kernel.org> > > Cc: devicetree@vger.kernel.org > > Cc: imx@lists.linux.dev > > Cc: linux-arm-kernel@lists.infradead.org > > --- > > arch/arm64/boot/dts/freescale/imx8mp.dtsi | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi > > index 1bb96e96639f2..2e9ce0c3a9815 100644 > > --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi > > +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi > > @@ -1703,7 +1703,7 @@ mipi_csi_1: csi@32e50000 { > > <&clk IMX8MP_CLK_MEDIA_MIPI_PHY1_REF>; > > assigned-clock-parents = <&clk IMX8MP_SYS_PLL2_1000M>, > > <&clk IMX8MP_CLK_24M>; > > - assigned-clock-rates = <266000000>; > > + assigned-clock-rates = <500000000>; I am traveling, so I don't have the technical documents in front of me, but I beleive this is an over-drive speed, and 400MHz would be the single clock, standard rate. I created an imx8mm-overdrive and imx8mn-overdrive dtsi file to let users who operate in overdrive mode to update their clocks in one place. I also think this goes down if the user is running two cameras instead of one. I re-read the old thread, and it's coming back to me, but until I can get settled into my hotel in Germany, I won't have time to review. I think the original idea was to use the lowest, conservative value with the idea that people can tweak their clock settings if they're only running one and if they are running in over-drive mode. adam > > power-domains = <&media_blk_ctrl IMX8MP_MEDIABLK_PD_MIPI_CSI2_2>; > > status = "disabled"; > > > > -- > Regards, > > Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: dts: imx8mp: Align both CSI2 pixel clock 2024-04-05 21:04 ` Adam Ford @ 2024-04-06 2:58 ` Marek Vasut 2024-04-08 10:14 ` Alexander Stein 0 siblings, 1 reply; 6+ messages in thread From: Marek Vasut @ 2024-04-06 2:58 UTC (permalink / raw) To: Adam Ford, Laurent Pinchart Cc: linux-arm-kernel, Conor Dooley, Fabio Estevam, Krzysztof Kozlowski, Paul Elder, Pengutronix Kernel Team, Rob Herring, Sascha Hauer, Shawn Guo, devicetree, imx On 4/5/24 11:04 PM, Adam Ford wrote: > On Fri, Apr 5, 2024 at 3:43 PM Laurent Pinchart > <laurent.pinchart@ideasonboard.com> wrote: >> >> Hi Marek, >> >> (CC'ing Adam) >> >> Thank you for the patch. >> >> On Fri, Apr 05, 2024 at 10:22:26PM +0200, Marek Vasut wrote: >>> Configure both CSI2 assigned-clock-rates the same way. >>> There does not seem to be any reason for keeping the >>> two CSI2 pixel clock set to different frequencies. >> >> There's an issue when using two cameras concurrently. This has been >> discussed some time ago on the linux-media mailing list, see [1]. Adam >> knows more than I do on this topic. >> >> [1] https://lore.kernel.org/linux-media/CAHCN7x+kymRGO2kxvN2=zLiqRjfTc3hdf3VdNVkWjsW3La0bnA@mail.gmail.com/ >> >>> Signed-off-by: Marek Vasut <marex@denx.de> >>> --- >>> Cc: Conor Dooley <conor+dt@kernel.org> >>> Cc: Fabio Estevam <festevam@gmail.com> >>> Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> >>> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com> >>> Cc: Paul Elder <paul.elder@ideasonboard.com> >>> Cc: Pengutronix Kernel Team <kernel@pengutronix.de> >>> Cc: Rob Herring <robh@kernel.org> >>> Cc: Sascha Hauer <s.hauer@pengutronix.de> >>> Cc: Shawn Guo <shawnguo@kernel.org> >>> Cc: devicetree@vger.kernel.org >>> Cc: imx@lists.linux.dev >>> Cc: linux-arm-kernel@lists.infradead.org >>> --- >>> arch/arm64/boot/dts/freescale/imx8mp.dtsi | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi >>> index 1bb96e96639f2..2e9ce0c3a9815 100644 >>> --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi >>> +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi >>> @@ -1703,7 +1703,7 @@ mipi_csi_1: csi@32e50000 { >>> <&clk IMX8MP_CLK_MEDIA_MIPI_PHY1_REF>; >>> assigned-clock-parents = <&clk IMX8MP_SYS_PLL2_1000M>, >>> <&clk IMX8MP_CLK_24M>; >>> - assigned-clock-rates = <266000000>; >>> + assigned-clock-rates = <500000000>; > > I am traveling, so I don't have the technical documents in front of > me, but I beleive this is an over-drive speed, and 400MHz would be the > single clock, standard rate. I created an imx8mm-overdrive and > imx8mn-overdrive dtsi file to let users who operate in overdrive mode > to update their clocks in one place. > > I also think this goes down if the user is running two cameras instead > of one. I re-read the old thread, and it's coming back to me, but > until I can get settled into my hotel in Germany, I won't have time to > review. I think the original idea was to use the lowest, conservative > value with the idea that people can tweak their clock settings if > they're only running one and if they are running in over-drive mode. MX8MPCEC does indeed read 400 MHz regular, 500 MHz overdrive. Shall we align both CSI2 ports to 400 MHz ? Currently they are one 500 MHz and the other 266 MHz . _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: dts: imx8mp: Align both CSI2 pixel clock 2024-04-06 2:58 ` Marek Vasut @ 2024-04-08 10:14 ` Alexander Stein 2024-04-16 13:11 ` Adam Ford 0 siblings, 1 reply; 6+ messages in thread From: Alexander Stein @ 2024-04-08 10:14 UTC (permalink / raw) To: Adam Ford, Laurent Pinchart, linux-arm-kernel Cc: linux-arm-kernel, Conor Dooley, Fabio Estevam, Krzysztof Kozlowski, Paul Elder, Pengutronix Kernel Team, Rob Herring, Sascha Hauer, Shawn Guo, devicetree, imx, Marek Vasut Hi everyone, Am Samstag, 6. April 2024, 04:58:39 CEST schrieb Marek Vasut: > On 4/5/24 11:04 PM, Adam Ford wrote: > > On Fri, Apr 5, 2024 at 3:43 PM Laurent Pinchart > > <laurent.pinchart@ideasonboard.com> wrote: > >> > >> Hi Marek, > >> > >> (CC'ing Adam) > >> > >> Thank you for the patch. > >> > >> On Fri, Apr 05, 2024 at 10:22:26PM +0200, Marek Vasut wrote: > >>> Configure both CSI2 assigned-clock-rates the same way. > >>> There does not seem to be any reason for keeping the > >>> two CSI2 pixel clock set to different frequencies. > >> > >> There's an issue when using two cameras concurrently. This has been > >> discussed some time ago on the linux-media mailing list, see [1]. Adam > >> knows more than I do on this topic. > >> > >> [1] https://lore.kernel.org/linux-media/CAHCN7x+kymRGO2kxvN2=zLiqRjfTc3hdf3VdNVkWjsW3La0bnA@mail.gmail.com/ > >> > >>> Signed-off-by: Marek Vasut <marex@denx.de> > >>> --- > >>> Cc: Conor Dooley <conor+dt@kernel.org> > >>> Cc: Fabio Estevam <festevam@gmail.com> > >>> Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> > >>> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > >>> Cc: Paul Elder <paul.elder@ideasonboard.com> > >>> Cc: Pengutronix Kernel Team <kernel@pengutronix.de> > >>> Cc: Rob Herring <robh@kernel.org> > >>> Cc: Sascha Hauer <s.hauer@pengutronix.de> > >>> Cc: Shawn Guo <shawnguo@kernel.org> > >>> Cc: devicetree@vger.kernel.org > >>> Cc: imx@lists.linux.dev > >>> Cc: linux-arm-kernel@lists.infradead.org > >>> --- > >>> arch/arm64/boot/dts/freescale/imx8mp.dtsi | 2 +- > >>> 1 file changed, 1 insertion(+), 1 deletion(-) > >>> > >>> diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi > >>> index 1bb96e96639f2..2e9ce0c3a9815 100644 > >>> --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi > >>> +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi > >>> @@ -1703,7 +1703,7 @@ mipi_csi_1: csi@32e50000 { > >>> <&clk IMX8MP_CLK_MEDIA_MIPI_PHY1_REF>; > >>> assigned-clock-parents = <&clk IMX8MP_SYS_PLL2_1000M>, > >>> <&clk IMX8MP_CLK_24M>; > >>> - assigned-clock-rates = <266000000>; > >>> + assigned-clock-rates = <500000000>; > > > > I am traveling, so I don't have the technical documents in front of > > me, but I beleive this is an over-drive speed, and 400MHz would be the > > single clock, standard rate. I created an imx8mm-overdrive and > > imx8mn-overdrive dtsi file to let users who operate in overdrive mode > > to update their clocks in one place. > > > > I also think this goes down if the user is running two cameras instead > > of one. I re-read the old thread, and it's coming back to me, but > > until I can get settled into my hotel in Germany, I won't have time to > > review. I think the original idea was to use the lowest, conservative > > value with the idea that people can tweak their clock settings if > > they're only running one and if they are running in over-drive mode. > > MX8MPCEC does indeed read 400 MHz regular, 500 MHz overdrive. > > Shall we align both CSI2 ports to 400 MHz ? Currently they are one 500 > MHz and the other 266 MHz . No, that won't do. The (industrial products) datasheet says (Table 1): * Single camera on CSI1: 400/500 MHz in normal/overdrive mode * Single camera on CSI2: 277 MHz * Dual camera on CSI1 & CSI2: 266 MHz Assuming you need CSI2 more likely in a dual camera setup only, defaulting to 266MHz seems sensible to me. Best regards, Alexander -- TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany Amtsgericht München, HRB 105018 Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider http://www.tq-group.com/ _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: dts: imx8mp: Align both CSI2 pixel clock 2024-04-08 10:14 ` Alexander Stein @ 2024-04-16 13:11 ` Adam Ford 0 siblings, 0 replies; 6+ messages in thread From: Adam Ford @ 2024-04-16 13:11 UTC (permalink / raw) To: Alexander Stein Cc: Laurent Pinchart, linux-arm-kernel, Conor Dooley, Fabio Estevam, Krzysztof Kozlowski, Paul Elder, Pengutronix Kernel Team, Rob Herring, Sascha Hauer, Shawn Guo, devicetree, imx, Marek Vasut On Mon, Apr 8, 2024 at 5:14 AM Alexander Stein <alexander.stein@ew.tq-group.com> wrote: > > Hi everyone, > > Am Samstag, 6. April 2024, 04:58:39 CEST schrieb Marek Vasut: > > On 4/5/24 11:04 PM, Adam Ford wrote: > > > On Fri, Apr 5, 2024 at 3:43 PM Laurent Pinchart > > > <laurent.pinchart@ideasonboard.com> wrote: > > >> > > >> Hi Marek, > > >> > > >> (CC'ing Adam) > > >> > > >> Thank you for the patch. > > >> > > >> On Fri, Apr 05, 2024 at 10:22:26PM +0200, Marek Vasut wrote: > > >>> Configure both CSI2 assigned-clock-rates the same way. > > >>> There does not seem to be any reason for keeping the > > >>> two CSI2 pixel clock set to different frequencies. > > >> > > >> There's an issue when using two cameras concurrently. This has been > > >> discussed some time ago on the linux-media mailing list, see [1]. Adam > > >> knows more than I do on this topic. > > >> > > >> [1] https://lore.kernel.org/linux-media/CAHCN7x+kymRGO2kxvN2=zLiqRjfTc3hdf3VdNVkWjsW3La0bnA@mail.gmail.com/ > > >> > > >>> Signed-off-by: Marek Vasut <marex@denx.de> > > >>> --- > > >>> Cc: Conor Dooley <conor+dt@kernel.org> > > >>> Cc: Fabio Estevam <festevam@gmail.com> > > >>> Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> > > >>> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > >>> Cc: Paul Elder <paul.elder@ideasonboard.com> > > >>> Cc: Pengutronix Kernel Team <kernel@pengutronix.de> > > >>> Cc: Rob Herring <robh@kernel.org> > > >>> Cc: Sascha Hauer <s.hauer@pengutronix.de> > > >>> Cc: Shawn Guo <shawnguo@kernel.org> > > >>> Cc: devicetree@vger.kernel.org > > >>> Cc: imx@lists.linux.dev > > >>> Cc: linux-arm-kernel@lists.infradead.org > > >>> --- > > >>> arch/arm64/boot/dts/freescale/imx8mp.dtsi | 2 +- > > >>> 1 file changed, 1 insertion(+), 1 deletion(-) > > >>> > > >>> diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi > > >>> index 1bb96e96639f2..2e9ce0c3a9815 100644 > > >>> --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi > > >>> +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi > > >>> @@ -1703,7 +1703,7 @@ mipi_csi_1: csi@32e50000 { > > >>> <&clk IMX8MP_CLK_MEDIA_MIPI_PHY1_REF>; > > >>> assigned-clock-parents = <&clk IMX8MP_SYS_PLL2_1000M>, > > >>> <&clk IMX8MP_CLK_24M>; > > >>> - assigned-clock-rates = <266000000>; > > >>> + assigned-clock-rates = <500000000>; > > > > > > I am traveling, so I don't have the technical documents in front of > > > me, but I beleive this is an over-drive speed, and 400MHz would be the > > > single clock, standard rate. I created an imx8mm-overdrive and > > > imx8mn-overdrive dtsi file to let users who operate in overdrive mode > > > to update their clocks in one place. > > > > > > I also think this goes down if the user is running two cameras instead > > > of one. I re-read the old thread, and it's coming back to me, but > > > until I can get settled into my hotel in Germany, I won't have time to > > > review. I think the original idea was to use the lowest, conservative > > > value with the idea that people can tweak their clock settings if > > > they're only running one and if they are running in over-drive mode. > > > > MX8MPCEC does indeed read 400 MHz regular, 500 MHz overdrive. > > > > Shall we align both CSI2 ports to 400 MHz ? Currently they are one 500 > > MHz and the other 266 MHz . > > No, that won't do. The (industrial products) datasheet says (Table 1): > * Single camera on CSI1: 400/500 MHz in normal/overdrive mode > * Single camera on CSI2: 277 MHz > * Dual camera on CSI1 & CSI2: 266 MHz > > Assuming you need CSI2 more likely in a dual camera setup only, defaulting to > 266MHz seems sensible to me. I agree. I think that at a minimum, the 500MHz clock should be reduced to 400MHz since 500MHz requires overdrive mode, but the safest clock rate would be to set both to 266MHz. Would it be appropriate to add a note to the device tree indicating that a single camera operating mode could potentially increase this to 400/500 depending on overdrive mode? adam > > Best regards, > Alexander > -- > TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany > Amtsgericht München, HRB 105018 > Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider > http://www.tq-group.com/ > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-04-16 13:11 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2024-04-05 20:22 [PATCH] arm64: dts: imx8mp: Align both CSI2 pixel clock Marek Vasut 2024-04-05 20:42 ` Laurent Pinchart 2024-04-05 21:04 ` Adam Ford 2024-04-06 2:58 ` Marek Vasut 2024-04-08 10:14 ` Alexander Stein 2024-04-16 13:11 ` Adam Ford
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox