* [RFC] ARM: Allow use debug_ll_io_init as .map_io in machine description
@ 2013-06-26 4:33 Alexander Shiyan
2013-06-26 9:05 ` Arnd Bergmann
0 siblings, 1 reply; 2+ messages in thread
From: Alexander Shiyan @ 2013-06-26 4:33 UTC (permalink / raw)
To: linux-arm-kernel
Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
---
arch/arm/include/asm/mach/map.h | 4 +---
arch/arm/mm/mmu.c | 4 ++++
2 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/arch/arm/include/asm/mach/map.h b/arch/arm/include/asm/mach/map.h
index 2fe141f..c1fafc5 100644
--- a/arch/arm/include/asm/mach/map.h
+++ b/arch/arm/include/asm/mach/map.h
@@ -42,10 +42,8 @@ extern void vm_reserve_area_early(unsigned long addr, unsigned long size,
#ifdef CONFIG_DEBUG_LL
extern void debug_ll_addr(unsigned long *paddr, unsigned long *vaddr);
-extern void debug_ll_io_init(void);
-#else
-static inline void debug_ll_io_init(void) {}
#endif
+extern void debug_ll_io_init(void);
struct mem_type;
extern const struct mem_type *get_mem_type(unsigned int type);
diff --git a/arch/arm/mm/mmu.c b/arch/arm/mm/mmu.c
index d7229d2..557831b 100644
--- a/arch/arm/mm/mmu.c
+++ b/arch/arm/mm/mmu.c
@@ -952,6 +952,10 @@ void __init debug_ll_io_init(void)
map.type = MT_DEVICE;
create_mapping(&map);
}
+#else
+void __init debug_ll_io_init(void)
+{
+}
#endif
static void * __initdata vmalloc_min =
--
1.8.1.5
^ permalink raw reply related [flat|nested] 2+ messages in thread* [RFC] ARM: Allow use debug_ll_io_init as .map_io in machine description
2013-06-26 4:33 [RFC] ARM: Allow use debug_ll_io_init as .map_io in machine description Alexander Shiyan
@ 2013-06-26 9:05 ` Arnd Bergmann
0 siblings, 0 replies; 2+ messages in thread
From: Arnd Bergmann @ 2013-06-26 9:05 UTC (permalink / raw)
To: linux-arm-kernel
On Wednesday 26 June 2013 08:33:47 Alexander Shiyan wrote:
>
> Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
> ---
> arch/arm/include/asm/mach/map.h | 4 +---
> arch/arm/mm/mmu.c | 4 ++++
> 2 files changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/include/asm/mach/map.h b/arch/arm/include/asm/mach/map.h
> index 2fe141f..c1fafc5 100644
> --- a/arch/arm/include/asm/mach/map.h
> +++ b/arch/arm/include/asm/mach/map.h
> @@ -42,10 +42,8 @@ extern void vm_reserve_area_early(unsigned long addr, unsigned long size,
>
> #ifdef CONFIG_DEBUG_LL
> extern void debug_ll_addr(unsigned long *paddr, unsigned long *vaddr);
> -extern void debug_ll_io_init(void);
> -#else
> -static inline void debug_ll_io_init(void) {}
> #endif
> +extern void debug_ll_io_init(void);
>
> struct mem_type;
Hi Alexander,
I don't think you need this, since having a NULL .map_io callback means
the same thing. Just remove the reference in your platform code.
Arnd
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-06-26 9:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-26 4:33 [RFC] ARM: Allow use debug_ll_io_init as .map_io in machine description Alexander Shiyan
2013-06-26 9:05 ` Arnd Bergmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox