From: "Jernej Škrabec" <jernej.skrabec@gmail.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Martin Botka <martin.botka@somainline.org>
Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
Samuel Holland <samuel@sholland.org>,
Maxime Ripard <mripard@kernel.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org,
Andre Przywara <andre.przywara@arm.com>,
Alan Ma <tech@biqu3d.com>,
Marijn Suijten <marijn.suijten@somainline.org>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@somainline.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>
Subject: Re: [PATCH v2 1/2] dt-bindings: nvmem: SID: Add binding for H616 SID controller
Date: Mon, 14 Aug 2023 12:28:36 +0200 [thread overview]
Message-ID: <5856748.MhkbZ0Pkbq@jernej-laptop> (raw)
In-Reply-To: <DKGDZR.4G4SZ781MVSV2@somainline.org>
Dne ponedeljek, 14. avgust 2023 ob 10:21:49 CEST je Martin Botka napisal(a):
> On Mon, Aug 14 2023 at 10:08:38 AM +02:00:00, Krzysztof Kozlowski
>
> <krzysztof.kozlowski@linaro.org> wrote:
> > On 14/08/2023 08:38, Martin Botka wrote:
> >> Add binding for the SID controller found in H616 SoC
> >>
> >> Signed-off-by: Martin Botka <martin.botka@somainline.org>
> >> ---
> >>
> >> Documentation/devicetree/bindings/nvmem/allwinner,sun4i-a10-sid.yaml
> >>
> >> | 1 +
> >> |
> >> 1 file changed, 1 insertion(+)
> >>
> >> diff --git
> >>
> >> a/Documentation/devicetree/bindings/nvmem/allwinner,sun4i-a10-sid.yaml
> >> b/Documentation/devicetree/bindings/nvmem/allwinner,sun4i-a10-sid.yaml
> >>
> >> index 296001e7f498..2ec0a1b8f803 100644
> >> ---
> >>
> >> a/Documentation/devicetree/bindings/nvmem/allwinner,sun4i-a10-sid.yaml
> >>
> >> +++
> >>
> >> b/Documentation/devicetree/bindings/nvmem/allwinner,sun4i-a10-sid.yaml
> >>
> >> @@ -27,6 +27,7 @@ properties:
> >> - const: allwinner,sun50i-a64-sid
> >>
> >> - const: allwinner,sun50i-h5-sid
> >> - const: allwinner,sun50i-h6-sid
> >>
> >> + - const: allwinner,sun50i-h616-sid
> >
> > It does not look like you tested the DTS against bindings. Please run
> > `make dtbs_check` (see
> > Documentation/devicetree/bindings/writing-schema.rst or
> > https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sour
> > ces-with-the-devicetree-schema/ for instructions).
> >
> > Best regards,
> > Krzysztof
>
> Yea completely forgot. Sorry for that.
>
> Will send v3 tomorrow with proper binding patch using items with enums
Don't. You have cca. 1 month time now, since you missed at least window for DT
changes for 6.6.
Best regards,
Jernej
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-08-14 10:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-14 6:38 [PATCH v2 0/2] Enable Security ID for H616 Martin Botka
2023-08-14 6:38 ` [PATCH v2 1/2] dt-bindings: nvmem: SID: Add binding for H616 SID controller Martin Botka
2023-08-14 8:08 ` Krzysztof Kozlowski
2023-08-14 8:21 ` Martin Botka
2023-08-14 10:28 ` Jernej Škrabec [this message]
2023-08-14 12:47 ` Andre Przywara
2023-08-14 6:38 ` [PATCH v2 2/2] arm64: dts: allwinner: h616: Add SID controller node Martin Botka
2023-08-14 8:09 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5856748.MhkbZ0Pkbq@jernej-laptop \
--to=jernej.skrabec@gmail.com \
--cc=andre.przywara@arm.com \
--cc=angelogioacchino.delregno@somainline.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=marijn.suijten@somainline.org \
--cc=martin.botka@somainline.org \
--cc=mripard@kernel.org \
--cc=robh+dt@kernel.org \
--cc=samuel@sholland.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=tech@biqu3d.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox