Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: David Heidelberg <david@ixit.cz>
To: Sebastian Krzyszkowiak <sebastian.krzyszkowiak@puri.sm>,
	Sakari Ailus <sakari.ailus@linux.intel.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Heiko Stuebner <heiko@sntech.de>, Ondrej Jirman <megi@xff.cz>,
	Olivier Benjamin <olivier.benjamin@bootlin.com>,
	Manuel Traut <manut@mecka.net>,
	Alexander Warnecke <awarnecke002@hotmail.com>,
	Frank Li <Frank.Li@nxp.com>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	Martin Kepplinger <martin.kepplinger@puri.sm>,
	Shawn Guo <shawnguo@kernel.org>
Cc: Krzysztof Kozlowski <krzk@kernel.org>,
	linux-media@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, phone-devel@vger.kernel.org,
	imx@lists.linux.dev, stable@vger.kernel.org
Subject: Re: [PATCH 4/4] arm64: dts: imx8mq-librem5: Dongwoon DW9714 coil requires higher voltage
Date: Mon, 3 Aug 2026 21:35:19 +0200	[thread overview]
Message-ID: <58da7454-e539-4e2b-b658-829cece52205@ixit.cz> (raw)
In-Reply-To: <yJywMSNTQGGZm3rbxd56Yw@puri.sm>

On 03/08/2026 20:12, Sebastian Krzyszkowiak wrote:
> On sobota, 1 sierpnia 2026 02:35:23 czas środkowoeuropejski letni David
> Heidelberg via B4 Relay wrote:
>> From: David Heidelberg <david@ixit.cz>
>>
>> By datasheet the VDD (in-kernel named vcc) range is between 2.3 to 4.3 V.
>> Usually it's around 2.8 V. Here it matches the reg_vcam_2v8.
> 
> It doesn't - VCAM_2V8 isn't connected to DW9714 (and neither is CSI_1V8);
> VCAM_AFVDD is.

I didn't realized we have datasheet here :)

> 
>> 1.8 V here is likely used for i2c level shifter.
> 
> I'm not sure where you've got an I2C level shifter from, there's none involved

it's copy-paste from previous commits.

> there. CSI_1V8 is passed to the rear camera module as DOVDD and is consumed by
> S5K3L6 as VDDIO, and both S5K3L6 and DW9714 are connected to I2C4_SDA/
> I2C4_SCL, operating at the 1.8V level, only though an EMI filter (F7 in the
> schematic).

I don't see the AFVDD in the [1], do you have it somewhere defined?

Thanks
David

[1] 
https://source.puri.sm/Librem5/linux/-/tree/pureos/latest/arch/arm64/boot/dts/freescale?ref_type=heads

> 
>>
>> Fixes: f00df2bdb512 ("arm64: dts: imx8mq-librem5: describe the voice coil
>> motor for focus control") Cc: stable@vger.kernel.org
>> Signed-off-by: David Heidelberg <david@ixit.cz>
>> ---
>>   arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
>> b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi index
>> f5d529c5baf3e..583cba2d3bebf 100644
>> --- a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
>> +++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
>> @@ -1167,17 +1167,17 @@ &i2c4 {
>>   	pinctrl-1 = <&pinctrl_i2c4_gpio>;
>>   	scl-gpios = <&gpio5 20 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
>>   	sda-gpios = <&gpio5 21 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
>>   	status = "okay";
>>
>>   	vcm@c {
>>   		compatible = "dongwoon,dw9714";
>>   		reg = <0x0c>;
>> -		vcc-supply = <&reg_csi_1v8>;
>> +		vcc-supply = <&reg_vcam_2v8>;
>>   	};
>>
>>   	bat: fuel-gauge@36 {
>>   		compatible = "maxim,max17055";
>>   		reg = <0x36>;
>>   		interrupt-parent = <&gpio3>;
>>   		interrupts = <20 IRQ_TYPE_LEVEL_LOW>;
>>   		pinctrl-names = "default";
> 
> 
> 
> 

-- 
David Heidelberg



      reply	other threads:[~2026-08-03 19:54 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-01  0:35 [PATCH 0/4] Dongwoon DW9714 - correct vcc/vdd supply voltage David Heidelberg via B4 Relay
2026-08-01  0:35 ` [PATCH 1/4] media: dt-bindings: dongwoon,dw9714: Example shouldn't imply 1.8 V David Heidelberg via B4 Relay
2026-08-01  0:35 ` [PATCH 2/4] arm64: dts: rockchip: rk3399-pinephone-pro: DW9714 coil requires higher voltage David Heidelberg via B4 Relay
2026-08-04  7:39   ` Ondřej Jirman
2026-08-04  9:12     ` David Heidelberg
2026-08-06 11:19       ` Ondřej Jirman
2026-08-06 11:49         ` David Heidelberg
2026-08-06 14:18           ` Ondřej Jirman
2026-08-01  0:35 ` [PATCH 3/4] arm64: dts: rockchip: rk3566-pinetab2: " David Heidelberg via B4 Relay
2026-08-01  0:35 ` [PATCH 4/4] arm64: dts: imx8mq-librem5: Dongwoon " David Heidelberg via B4 Relay
2026-08-03 18:12   ` Sebastian Krzyszkowiak
2026-08-03 19:35     ` David Heidelberg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=58da7454-e539-4e2b-b658-829cece52205@ixit.cz \
    --to=david@ixit.cz \
    --cc=Frank.Li@nxp.com \
    --cc=awarnecke002@hotmail.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=heiko@sntech.de \
    --cc=imx@lists.linux.dev \
    --cc=kernel@pengutronix.de \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=manut@mecka.net \
    --cc=martin.kepplinger@puri.sm \
    --cc=mchehab@kernel.org \
    --cc=megi@xff.cz \
    --cc=olivier.benjamin@bootlin.com \
    --cc=phone-devel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=sakari.ailus@linux.intel.com \
    --cc=sebastian.krzyszkowiak@puri.sm \
    --cc=shawnguo@kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox