From: Alexander Stein <alexander.stein@ew.tq-group.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-arm-kernel@lists.infradead.org
Cc: linux-serial@vger.kernel.org, "Jiri Slaby" <jirislaby@kernel.org>,
"Fabio Estevam" <festevam@gmail.com>,
"NXP Linux Team" <linux-imx@nxp.com>,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
"Shawn Guo" <shawnguo@kernel.org>,
linux-arm-kernel@lists.infradead.org,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Subject: Re: [PATCH] serial: imx: Simplify imx_uart_type
Date: Thu, 02 Mar 2023 13:20:25 +0100 [thread overview]
Message-ID: <5912297.lOV4Wx5bFT@steina-w> (raw)
In-Reply-To: <20230302115547.sacjk4ekwmfev2xz@pengutronix.de>
Hi Uwe,
Am Donnerstag, 2. März 2023, 12:55:47 CET schrieb Uwe Kleine-König:
> * PGP Signed by an unknown key
>
> Hello,
>
> On Thu, Mar 02, 2023 at 12:48:10PM +0100, Uwe Kleine-König wrote:
> > There is no point in casting a struct uart_port to a struct imx_port
> > just to access the first member of the latter (a struct uart_port).
> >
> > This introduces code changes.
>
> Please disregard this patch. While the patch is fine as is, I just
> noticed a few more functions in this driver that can be simplified
> accordingly. I'm about to send out an improved version (with a different
> subject, so not called v2).
Shouldn't this cast on the other locations be converted into a to_imx_port()
function using container_of as well?
Best regards,
Alexander
> Best regards
> Uwe
--
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-03-02 12:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-02 11:48 [PATCH] serial: imx: Simplify imx_uart_type Uwe Kleine-König
2023-03-02 11:55 ` Uwe Kleine-König
2023-03-02 12:20 ` Alexander Stein [this message]
2023-03-02 13:19 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5912297.lOV4Wx5bFT@steina-w \
--to=alexander.stein@ew.tq-group.com \
--cc=festevam@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-serial@vger.kernel.org \
--cc=shawnguo@kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox