Re: [PATCH v4 2/3] dt-bindings: clock: Add rk3576 clock definitions and documentation

Re: [PATCH v4 2/3] dt-bindings: clock: Add rk3576 clock definitions and documentation

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 3844 bytes --]

On Fri, Aug 09, 2024 at 08:54:53AM -0400, Detlev Casanova wrote:
> Add clock ID defines for rk3576.
> 
> Compared to the downstream bindings written by Elaine, this uses
> continous gapless clock IDs starting at 1. Thus all numbers are
> different between downstream and upstream, but names are kept
> exactly the same.
> 
> Also add documentation for the rk3576 CRU core.
> 
> Signed-off-by: Detlev Casanova <detlev.casanova@collabora.com>
> ---
>  .../bindings/clock/rockchip,rk3576-cru.yaml   |  84 +++
>  .../dt-bindings/clock/rockchip,rk3576-cru.h   | 592 ++++++++++++++++++
>  2 files changed, 676 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/clock/rockchip,rk3576-cru.yaml
>  create mode 100644 include/dt-bindings/clock/rockchip,rk3576-cru.h
> 
> diff --git a/Documentation/devicetree/bindings/clock/rockchip,rk3576-cru.yaml b/Documentation/devicetree/bindings/clock/rockchip,rk3576-cru.yaml
> new file mode 100644
> index 0000000000000..d6fd17320e56a
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/rockchip,rk3576-cru.yaml
> @@ -0,0 +1,84 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/clock/rockchip,rk3576-cru.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Rockchip rk3576 Family Clock and Reset Control Module
> +
> +maintainers:
> +  - Elaine Zhang <zhangqing@rock-chips.com>
> +  - Heiko Stuebner <heiko@sntech.de>

Why not you, the author?

> +
> +description: |

The | here is not needed, you've got no formatting worth preserving.

> +  The RK3576 clock controller generates the clock and also implements a reset
> +  controller for SoC peripherals. For example it provides SCLK_UART2 and
> +  PCLK_UART2, as well as SRST_P_UART2 and SRST_S_UART2 for the second UART
> +  module.
> +
> +properties:
> +  compatible:
> +    enum:
> +      - rockchip,rk3576-cru

Why an enum rather than const?

> +
> +  reg:
> +    maxItems: 1
> +
> +  "#clock-cells":
> +    const: 1
> +
> +  "#reset-cells":
> +    const: 1
> +
> +  clocks:
> +    maxItems: 2
> +
> +  clock-names:
> +    items:
> +      - const: xin24m
> +      - const: xin32k
> +
> +  rockchip,grf:
> +    $ref: /schemas/types.yaml#/definitions/phandle
> +    description: >
> +      phandle to the syscon managing the "general register files". It is used
> +      for GRF muxes, if missing any muxes present in the GRF will not be
> +      available.
> +
> +required:
> +  - compatible
> +  - reg
> +  - "#clock-cells"
> +  - "#reset-cells"
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/clock/rockchip,rk3576-cru.h>
> +    clock-controller@27200000 {
> +      compatible = "rockchip,rk3576-cru";
> +      reg = <0xfd7c0000 0x5c000>;
> +      #clock-cells = <1>;
> +      #reset-cells = <1>;
> +      assigned-clocks =
> +        <&cru CLK_AUDIO_FRAC_1_SRC>,
> +        <&cru PLL_GPLL>, <&cru PLL_CPLL>,
> +        <&cru PLL_AUPLL>, <&cru CLK_UART_FRAC_0>,
> +        <&cru CLK_UART_FRAC_1>, <&cru CLK_UART_FRAC_2>,
> +        <&cru CLK_AUDIO_FRAC_0>, <&cru CLK_AUDIO_FRAC_1>,
> +        <&cru CLK_CPLL_DIV2>, <&cru CLK_CPLL_DIV4>,
> +        <&cru CLK_CPLL_DIV10>, <&cru FCLK_DDR_CM0_CORE>,
> +        <&cru ACLK_PHP_ROOT>;
> +      assigned-clock-parents = <&cru PLL_AUPLL>;
> +      assigned-clock-rates =
> +        <0>,
> +        <1188000000>, <1000000000>,
> +        <786432000>, <18432000>,
> +        <96000000>, <128000000>,
> +        <45158400>, <49152000>,
> +        <500000000>, <250000000>,
> +        <100000000>, <500000000>,
> +        <250000000>;

I don't think these assigned-clock* properties add anything to the
example.

Cheers,
Conor.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH v4 1/3] dt-bindings: reset: Add rk3576 reset definitions

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 620 bytes --]

On Fri, Aug 09, 2024 at 08:54:52AM -0400, Detlev Casanova wrote:
> Add reset ID defines for rk3576.
> 
> Compared to the downstream bindings this uses continous gapless
> reset IDs starting at 1 instead of register offsets as IDs, as
> introduced in the RK3588 bindings.
> Thus all numbers are different between upstream and downstream,
> but names are kept exactly the same.
> 
> Signed-off-by: Elaine Zhang <zhangqing@rock-chips.com>
> Signed-off-by: Sugar Zhang <sugar.zhang@rock-chips.com>
> Signed-off-by: Detlev Casanova <detlev.casanova@collabora.com>

IMO squash this with the other binding patch.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH v4 1/3] dt-bindings: reset: Add rk3576 reset definitions

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 1000 bytes --]

On Fri, Aug 09, 2024 at 10:49:42AM -0400, Detlev Casanova wrote:
> On Friday, 9 August 2024 10:15:12 EDT Conor Dooley wrote:
> > On Fri, Aug 09, 2024 at 08:54:52AM -0400, Detlev Casanova wrote:
> > > Add reset ID defines for rk3576.
> > > 
> > > Compared to the downstream bindings this uses continous gapless
> > > reset IDs starting at 1 instead of register offsets as IDs, as
> > > introduced in the RK3588 bindings.
> > > Thus all numbers are different between upstream and downstream,
> > > but names are kept exactly the same.
> > > 
> > > Signed-off-by: Elaine Zhang <zhangqing@rock-chips.com>
> > > Signed-off-by: Sugar Zhang <sugar.zhang@rock-chips.com>
> > > Signed-off-by: Detlev Casanova <detlev.casanova@collabora.com>
> > 
> > IMO squash this with the other binding patch.
> 
> Yes, I wanted to but the issue is with the subject line: do I use "dt-
> bindings: reset+clock: [...]" in the squashed commit ? 

Yeah, I guess you could do "dt-bindings: clock, reset:".

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH v4 1/3] dt-bindings: reset: Add rk3576 reset definitions

[Diederik de Haas]

On Fri Aug 9, 2024 at 2:54 PM CEST, Detlev Casanova wrote:
> Add reset ID defines for rk3576.
>
> Compared to the downstream bindings this uses continous gapless
> reset IDs starting at 1 instead of register offsets as IDs, as
> introduced in the RK3588 bindings.
> ...
> ---
>  .../dt-bindings/reset/rockchip,rk3576-cru.h   | 564 ++++++++++++++++++
>  1 file changed, 564 insertions(+)
>  create mode 100644 include/dt-bindings/reset/rockchip,rk3576-cru.h
>
> diff --git a/include/dt-bindings/reset/rockchip,rk3576-cru.h b/include/dt-bindings/reset/rockchip,rk3576-cru.h
> new file mode 100644
> index 0000000000000..8c968af4888d5
> --- /dev/null
> +++ b/include/dt-bindings/reset/rockchip,rk3576-cru.h
> @@ -0,0 +1,564 @@
> +/* SPDX-License-Identifier: (GPL-2.0 OR MIT) */
> + ...
> +
> +#ifndef _DT_BINDINGS_RESET_ROCKCHIP_RK3576_H
> +#define _DT_BINDINGS_RESET_ROCKCHIP_RK3576_H
> +
> +#define SRST_A_TOP_BIU			0
> +#define SRST_P_TOP_BIU			1

As requested you renumbered starting from '0', but the commit message
mentions "starting at 1". Same for patch 2 of this series.

Re: [PATCH v4 1/3] dt-bindings: reset: Add rk3576 reset definitions

[Krzysztof Kozlowski]

On 09/08/2024 14:54, Detlev Casanova wrote:
> Add reset ID defines for rk3576.
> 
> Compared to the downstream bindings this uses continous gapless
> reset IDs starting at 1 instead of register offsets as IDs, as
> introduced in the RK3588 bindings.
> Thus all numbers are different between upstream and downstream,
> but names are kept exactly the same.
> 
> Signed-off-by: Elaine Zhang <zhangqing@rock-chips.com>
> Signed-off-by: Sugar Zhang <sugar.zhang@rock-chips.com>
> Signed-off-by: Detlev Casanova <detlev.casanova@collabora.com>
> ---
>  .../dt-bindings/reset/rockchip,rk3576-cru.h   | 564 ++++++++++++++++++

I think I was clear:

"These are bindings. Must be squashed with previous patch."

Other comments were also not implemented?

Best regards,
Krzysztof