* [PATCH] ARM: dts: imx6qdl-dhcom: Align PHY reset timing with other DHCOM SoMs
@ 2021-12-08 15:05 Christoph Niedermaier
2021-12-08 17:36 ` Fabio Estevam
2021-12-14 8:30 ` Shawn Guo
0 siblings, 2 replies; 3+ messages in thread
From: Christoph Niedermaier @ 2021-12-08 15:05 UTC (permalink / raw)
To: linux-arm-kernel
Cc: Christoph Niedermaier, Shawn Guo, Fabio Estevam, Marek Vasut,
NXP Linux Team, kernel
According to datasheet Microchip LAN8710A/LAN8710Ai DS00002164B [1]
the reset should stay asserted for at least 100uS and software
should wait at least 200nS. On other DHCOM SoMs with the SMSC
LAN8710Ai PHY both reset delays are 500us. This should be plenty
and for consistency, the i.MX6 SoM should also use these delays.
[1] https://ww1.microchip.com/downloads/en/DeviceDoc/00002164B.pdf
Signed-off-by: Christoph Niedermaier <cniedermaier@dh-electronics.com>
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: Fabio Estevam <festevam@denx.de>
Cc: Marek Vasut <marex@denx.de>
Cc: NXP Linux Team <linux-imx@nxp.com>
Cc: kernel@dh-electronics.com
To: linux-arm-kernel@lists.infradead.org
---
arch/arm/boot/dts/imx6qdl-dhcom-som.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/imx6qdl-dhcom-som.dtsi b/arch/arm/boot/dts/imx6qdl-dhcom-som.dtsi
index 5d10c40313cb..e71687061161 100644
--- a/arch/arm/boot/dts/imx6qdl-dhcom-som.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-dhcom-som.dtsi
@@ -138,8 +138,8 @@
pinctrl-0 = <&pinctrl_ethphy0>;
pinctrl-names = "default";
reg = <0>;
- reset-assert-us = <1000>;
- reset-deassert-us = <1000>;
+ reset-assert-us = <500>;
+ reset-deassert-us = <500>;
reset-gpios = <&gpio5 0 GPIO_ACTIVE_LOW>;
smsc,disable-energy-detect; /* Make plugin detection reliable */
};
--
2.11.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ARM: dts: imx6qdl-dhcom: Align PHY reset timing with other DHCOM SoMs
2021-12-08 15:05 [PATCH] ARM: dts: imx6qdl-dhcom: Align PHY reset timing with other DHCOM SoMs Christoph Niedermaier
@ 2021-12-08 17:36 ` Fabio Estevam
2021-12-14 8:30 ` Shawn Guo
1 sibling, 0 replies; 3+ messages in thread
From: Fabio Estevam @ 2021-12-08 17:36 UTC (permalink / raw)
To: Christoph Niedermaier
Cc: linux-arm-kernel, Shawn Guo, Marek Vasut, NXP Linux Team, kernel
Hi Christoph,
On 08/12/2021 12:05, Christoph Niedermaier wrote:
> According to datasheet Microchip LAN8710A/LAN8710Ai DS00002164B [1]
> the reset should stay asserted for at least 100uS and software
> should wait at least 200nS. On other DHCOM SoMs with the SMSC
> LAN8710Ai PHY both reset delays are 500us. This should be plenty
> and for consistency, the i.MX6 SoM should also use these delays.
>
> [1] https://ww1.microchip.com/downloads/en/DeviceDoc/00002164B.pdf
>
> Signed-off-by: Christoph Niedermaier <cniedermaier@dh-electronics.com>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: Fabio Estevam <festevam@denx.de>
> Cc: Marek Vasut <marex@denx.de>
> Cc: NXP Linux Team <linux-imx@nxp.com>
> Cc: kernel@dh-electronics.com
> To: linux-arm-kernel@lists.infradead.org
Reviewed-by: Fabio Estevam <festevam@denx.de>
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-60 Fax: (+49)-8142-66989-80 Email:
festevam@denx.de
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ARM: dts: imx6qdl-dhcom: Align PHY reset timing with other DHCOM SoMs
2021-12-08 15:05 [PATCH] ARM: dts: imx6qdl-dhcom: Align PHY reset timing with other DHCOM SoMs Christoph Niedermaier
2021-12-08 17:36 ` Fabio Estevam
@ 2021-12-14 8:30 ` Shawn Guo
1 sibling, 0 replies; 3+ messages in thread
From: Shawn Guo @ 2021-12-14 8:30 UTC (permalink / raw)
To: Christoph Niedermaier
Cc: linux-arm-kernel, Fabio Estevam, Marek Vasut, NXP Linux Team,
kernel
On Wed, Dec 08, 2021 at 04:05:43PM +0100, Christoph Niedermaier wrote:
> According to datasheet Microchip LAN8710A/LAN8710Ai DS00002164B [1]
> the reset should stay asserted for at least 100uS and software
> should wait at least 200nS. On other DHCOM SoMs with the SMSC
> LAN8710Ai PHY both reset delays are 500us. This should be plenty
> and for consistency, the i.MX6 SoM should also use these delays.
>
> [1] https://ww1.microchip.com/downloads/en/DeviceDoc/00002164B.pdf
>
> Signed-off-by: Christoph Niedermaier <cniedermaier@dh-electronics.com>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: Fabio Estevam <festevam@denx.de>
> Cc: Marek Vasut <marex@denx.de>
> Cc: NXP Linux Team <linux-imx@nxp.com>
> Cc: kernel@dh-electronics.com
> To: linux-arm-kernel@lists.infradead.org
Applied, thanks!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-12-14 8:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-12-08 15:05 [PATCH] ARM: dts: imx6qdl-dhcom: Align PHY reset timing with other DHCOM SoMs Christoph Niedermaier
2021-12-08 17:36 ` Fabio Estevam
2021-12-14 8:30 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox