From: "Guilherme G. Piccoli" <gpiccoli@igalia.com>
To: Bradley Morgan <include@grrlz.net>
Cc: broonie@kernel.org, catalin.marinas@arm.com, gshan@redhat.com,
kernel-dev@igalia.com, kernel@gpiccoli.net,
linux-arm-kernel@lists.infradead.org, mark.rutland@arm.com,
robin.murphy@arm.com, sonicadvance1@gmail.com, will@kernel.org
Subject: Re: [PATCH] arm64/kernel: Expose the running CPU of a native task in TPIDRRO_EL0
Date: Mon, 17 Aug 2026 11:51:46 -0300 [thread overview]
Message-ID: <5c95bd13-993f-55be-4aa7-acb990738d91@igalia.com> (raw)
In-Reply-To: <404DF303-5478-4B5C-9DE1-3A7B3B3927A5@grrlz.net>
On 15/08/2026 13:52, Bradley Morgan wrote:
> Hi, we meet again, :)
>
> Well, I looked at this assembly code until I was blind,heh, and I
> couldnt particularly find anything bad about it, well, I know I'll
> probably get these arm pros saying I'm dumb or something for not
> noticing a mistake, but I don't see any mistakes asm side.
>
>
> For process.c, I really really like your comment, it's, straight
> to the point, did your LLM write this, or did you write it?
>
> For your patch;
>
> Reviewed-by: Bradley Morgan <include@grrlz.net>
>
>
> Note: I hope I don't get plonked, I couldnt find anything wrong, but who knows
> Thanks!
Hey Bradley \o
Thanks for your review.
I wrote the comment myself, but LLM helped me with ping-pong reviews,
for example, checking corner cases, commenting on potential ideas. For
example, in a first version I just updated this write_sysreg() to the
CPU id, but then started to think "why am I doing this if the register
is updated at every exit?". "Talking" with the LLM gave me confidence to
suppress this write, due to the reason well explained in the comment heh
Cheers!
next prev parent reply other threads:[~2026-08-17 14:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-15 15:19 [PATCH] arm64/kernel: Expose the running CPU of a native task in TPIDRRO_EL0 Guilherme G. Piccoli
2026-08-15 16:52 ` Bradley Morgan
2026-08-17 14:51 ` Guilherme G. Piccoli [this message]
2026-08-17 14:56 ` Bradley Morgan
2026-08-16 9:51 ` Will Deacon
2026-08-17 8:51 ` Catalin Marinas
2026-08-17 12:53 ` Ryan Houdek
2026-08-17 14:48 ` Guilherme G. Piccoli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5c95bd13-993f-55be-4aa7-acb990738d91@igalia.com \
--to=gpiccoli@igalia.com \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=gshan@redhat.com \
--cc=include@grrlz.net \
--cc=kernel-dev@igalia.com \
--cc=kernel@gpiccoli.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=robin.murphy@arm.com \
--cc=sonicadvance1@gmail.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox