From: "Sven Peter" <sven@svenpeter.dev>
To: "Arminder Singh" <arminders208@outlook.com>,
"Wolfram Sang" <wsa@kernel.org>
Cc: "Alyssa Rosenzweig" <alyssa@rosenzweig.io>,
asahi@lists.linux.dev,
"Benjamin Herrenschmidt" <benh@kernel.crashing.org>,
"Christian Zigotzky" <chzigotzky@xenosoft.de>,
"Darren Stevens" <darren@stevens-zone.net>,
linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
"Hector Martin" <marcan@marcan.st>,
"Michael Ellerman" <mpe@ellerman.id.au>,
"Paul Mackerras" <paulus@samba.org>
Subject: Re: [PATCH v2] i2c-pasemi: PASemi I2C controller IRQ enablement
Date: Sun, 02 Oct 2022 17:02:07 +0200 [thread overview]
Message-ID: <5e89999e-5c9d-428c-a6c6-b454fb47aaa3@app.fastmail.com> (raw)
In-Reply-To: <MN2PR01MB5358FB185A18D2E6C22A45FE9F589@MN2PR01MB5358.prod.exchangelabs.com>
Hi,
On Sun, Oct 2, 2022, at 16:07, Arminder Singh wrote:
> Hi,
>
>> #define REG_MTXFIFO 0x00
>> #define REG_MRXFIFO 0x04
>> #define REG_SMSTA 0x14
>> +#define REG_IMASK 0x18
>
>> This doesn't seem to be aligned correctly, this file seems to use a tab
>> to separate the register name and the offset and you used spaces here.
>
>> @@ -15,7 +16,11 @@ struct pasemi_smbus {
>> struct i2c_adapter adapter;
>> void __iomem *ioaddr;
>> unsigned int clk_div;
>> - int hw_rev;
>> + int hw_rev;
>> + int use_irq;
>> + struct completion irq_completion;
>
>> This doesn't seem to be aligned correctly and the hw_rev line
>> doesn't have to be changed.
>
> I'm sorry for the alignment issues in the patch, I genuinely didn't notice
> them as from the perspective of my primary editor (Visual Studio Code)
> the entries were aligned. I just saw them when opening the files in
> nano.
No worries, it's just a small nit and quickly fixed after all! :)
>
> Does fixing the alignment issues and the commit description justify a v3
> of the patch or should the minor fixes go out as a "resend"? Just not sure
> in this particular case as the fixes seem to be very minor ones.
I'd send a v3. I've only used resend when e.g. my previous mail provider
messed up and silently converted all my outgoing mails to HTML.
Best,
Sven
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-10-02 15:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-01 22:25 [PATCH v2] i2c/pasemi: PASemi I2C controller IRQ enablement Arminder Singh
2022-10-02 11:21 ` Sven Peter
2022-10-02 11:28 ` Wolfram Sang
2022-10-02 14:07 ` [PATCH v2] i2c-pasemi: " Arminder Singh
2022-10-02 15:02 ` Sven Peter [this message]
2022-10-04 1:27 ` Michael Ellerman
2022-10-05 19:04 ` Wolfram Sang
2022-10-02 15:28 ` [PATCH v2] i2c/pasemi: " Christian Zigotzky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5e89999e-5c9d-428c-a6c6-b454fb47aaa3@app.fastmail.com \
--to=sven@svenpeter.dev \
--cc=alyssa@rosenzweig.io \
--cc=arminders208@outlook.com \
--cc=asahi@lists.linux.dev \
--cc=benh@kernel.crashing.org \
--cc=chzigotzky@xenosoft.de \
--cc=darren@stevens-zone.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=marcan@marcan.st \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox