Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] pinctrl: ssbi: fix function name typo
@ 2015-10-16 20:41 Arnd Bergmann
  2015-10-17 17:11 ` Bjorn Andersson
  0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2015-10-16 20:41 UTC (permalink / raw)
  To: linux-arm-kernel

The two newly added qcom ssbi pinctrl drivers have the same bug
from a function name that apparently got changed in one place
but not another, resulting in a build error when CONFIG_DEBUG_FS
is disabled:

drivers/pinctrl/qcom/pinctrl-ssbi-mpp.c:652:14: error: 'pm8xxx_mpp_dbg_show' undeclared here (not in a function)

This fixes the two identifiers.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: b4c45fe974bc ("pinctrl: qcom: ssbi: Family A gpio & mpp drivers")

diff --git a/drivers/pinctrl/qcom/pinctrl-ssbi-gpio.c b/drivers/pinctrl/qcom/pinctrl-ssbi-gpio.c
index e1a3721bc8e5..d809c9eaa323 100644
--- a/drivers/pinctrl/qcom/pinctrl-ssbi-gpio.c
+++ b/drivers/pinctrl/qcom/pinctrl-ssbi-gpio.c
@@ -584,7 +584,7 @@ static void pm8xxx_gpio_dbg_show(struct seq_file *s, struct gpio_chip *chip)
 }
 
 #else
-#define msm_gpio_dbg_show NULL
+#define pm8xxx_gpio_dbg_show NULL
 #endif
 
 static struct gpio_chip pm8xxx_gpio_template = {
diff --git a/drivers/pinctrl/qcom/pinctrl-ssbi-mpp.c b/drivers/pinctrl/qcom/pinctrl-ssbi-mpp.c
index 6652b8d7f707..8982027de8e8 100644
--- a/drivers/pinctrl/qcom/pinctrl-ssbi-mpp.c
+++ b/drivers/pinctrl/qcom/pinctrl-ssbi-mpp.c
@@ -639,7 +639,7 @@ static void pm8xxx_mpp_dbg_show(struct seq_file *s, struct gpio_chip *chip)
 }
 
 #else
-#define msm_mpp_dbg_show NULL
+#define pm8xxx_mpp_dbg_show NULL
 #endif
 
 static struct gpio_chip pm8xxx_mpp_template = {

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [PATCH] pinctrl: ssbi: fix function name typo
  2015-10-16 20:41 [PATCH] pinctrl: ssbi: fix function name typo Arnd Bergmann
@ 2015-10-17 17:11 ` Bjorn Andersson
  0 siblings, 0 replies; 2+ messages in thread
From: Bjorn Andersson @ 2015-10-17 17:11 UTC (permalink / raw)
  To: linux-arm-kernel

On Fri 16 Oct 13:41 PDT 2015, Arnd Bergmann wrote:

> The two newly added qcom ssbi pinctrl drivers have the same bug
> from a function name that apparently got changed in one place
> but not another, resulting in a build error when CONFIG_DEBUG_FS
> is disabled:
> 
> drivers/pinctrl/qcom/pinctrl-ssbi-mpp.c:652:14: error: 'pm8xxx_mpp_dbg_show' undeclared here (not in a function)
> 
> This fixes the two identifiers.

Sorry about this Arnd.

Jonas Gorski found this a few days ago and Linus picked it up today, so
it's in the pipe already.

Regards,
Bjorn

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-10-17 17:11 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-16 20:41 [PATCH] pinctrl: ssbi: fix function name typo Arnd Bergmann
2015-10-17 17:11 ` Bjorn Andersson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox