From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Animesh Agarwal <animeshagarwal28@gmail.com>
Cc: Damien Le Moal <dlemoal@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
linux-ide@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5] dt-bindings: imx-pata: Convert to dtschema
Date: Mon, 11 Mar 2024 07:26:36 +0100 [thread overview]
Message-ID: <6597b720-4b8f-4034-8f0b-b67949ef5feb@linaro.org> (raw)
In-Reply-To: <CAE3Oz8353cPXgZa3BhtjyfdFfu+XPUhHXf=qWxWQ7sbvVK7gcg@mail.gmail.com>
On 11/03/2024 04:18, Animesh Agarwal wrote:
> On Mon, Mar 11, 2024 at 1:55 AM Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org> wrote:
>> What changelog? Read carefully what I asked you few versions ago:
> Below the sign off I have added changes done in all the versions
> before and explained why imx51-pata was added.
>
>> "Please explain the differences done during conversion in the commit
>> msg. There was no imx51 compatible in the binding before."
>
> ""
> Changes in v4:
> - added fsl,imx31-pata in compatible property as enum
> - imx31-pata was not listed in compatible in original txt binding
> - adding imx31-pata in enum ensures the node compiles to imx31.dtsi
> Changes in v3:
> - added fsl,imx51-pata in compatible property as enum
> - imx51-pata was not listed in compatible in original txt binding
> - adding imx51-pata in enum ensures the node compiles to imx51.dtsi
> - fsl,imx27-pata is added as a const to ensure it is present always
> ""
> Aren't these lines enough for the said explanation?
This is changelog, not commit msg. I did not ask to explain differences
from pure conversion in changelog.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-03-11 6:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-10 17:19 [PATCH v5] dt-bindings: imx-pata: Convert to dtschema Animesh Agarwal
2024-03-10 17:25 ` Krzysztof Kozlowski
2024-03-10 17:31 ` Animesh Agarwal
2024-03-10 17:37 ` Krzysztof Kozlowski
2024-03-10 17:51 ` Animesh Agarwal
2024-03-10 20:25 ` Krzysztof Kozlowski
2024-03-11 3:18 ` Animesh Agarwal
2024-03-11 6:26 ` Krzysztof Kozlowski [this message]
2024-03-11 11:11 ` Animesh Agarwal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6597b720-4b8f-4034-8f0b-b67949ef5feb@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=animeshagarwal28@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlemoal@kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox