From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Animesh Agarwal <animeshagarwal28@gmail.com>
Cc: Damien Le Moal <dlemoal@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
linux-ide@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5] dt-bindings: imx-pata: Convert to dtschema
Date: Sun, 10 Mar 2024 21:25:49 +0100 [thread overview]
Message-ID: <ba834984-d0d7-4b46-81f6-5a2df8e74944@linaro.org> (raw)
In-Reply-To: <CAE3Oz80zrnLvpo=YdBA-3PAtJFP8KK4LGHpEpQaMCacFFG13Qg@mail.gmail.com>
On 10/03/2024 18:51, Animesh Agarwal wrote:
> On Sun, Mar 10, 2024 at 11:08 PM Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org> wrote:
>> I did not say about subject, but about commit message.
> Ok, I'll add commit message above the change log.
What changelog? Read carefully what I asked you few versions ago:
"Please explain the differences done during conversion in the commit
msg. There was no imx51 compatible in the binding before."
The differences from conversion. There was some binding in TXT and you
convert to different format. You introduce changes beyond pure
conversion, so this must be explained. Again: explain what changes are
you making *to the binding*, which are not pure conversion, and why you
are making them.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-03-10 20:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-10 17:19 [PATCH v5] dt-bindings: imx-pata: Convert to dtschema Animesh Agarwal
2024-03-10 17:25 ` Krzysztof Kozlowski
2024-03-10 17:31 ` Animesh Agarwal
2024-03-10 17:37 ` Krzysztof Kozlowski
2024-03-10 17:51 ` Animesh Agarwal
2024-03-10 20:25 ` Krzysztof Kozlowski [this message]
2024-03-11 3:18 ` Animesh Agarwal
2024-03-11 6:26 ` Krzysztof Kozlowski
2024-03-11 11:11 ` Animesh Agarwal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ba834984-d0d7-4b46-81f6-5a2df8e74944@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=animeshagarwal28@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlemoal@kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox