* [PATCH] ata: ahci_platform: Add ACPI support for APM X-Gene AHCI controller v3 hardware. [not found] ` <1466034240-22694-1-git-send-email-stripathi@apm.com> @ 2016-06-16 6:54 ` Arnd Bergmann 2016-06-21 18:08 ` Suman Tripathi 0 siblings, 1 reply; 6+ messages in thread From: Arnd Bergmann @ 2016-06-16 6:54 UTC (permalink / raw) To: linux-arm-kernel On Wednesday, June 15, 2016 5:44:00 PM CEST suman-tripathi wrote: > This patch adds ACPI support for APM X-Gene AHCI controller in > ahci_platform driver for v3 hardware. APM X-Gene AHCI controller > v3 hardware is fully compliant with ahci_platform driver and requires > no workaround quirk. > > Signed-off-by: Suman Tripathi <stripathi@apm.com> > --- > drivers/ata/ahci_platform.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/drivers/ata/ahci_platform.c b/drivers/ata/ahci_platform.c > index 62a04c8..3395baf 100644 > --- a/drivers/ata/ahci_platform.c > +++ b/drivers/ata/ahci_platform.c > @@ -86,6 +86,7 @@ MODULE_DEVICE_TABLE(of, ahci_of_match); > > static const struct acpi_device_id ahci_acpi_match[] = { > { ACPI_DEVICE_CLASS(PCI_CLASS_STORAGE_SATA_AHCI, 0xffffff) }, > + { "APMC0D33", 0}, > {}, > }; > MODULE_DEVICE_TABLE(acpi, ahci_acpi_match); > Doesn't the ACPI_DEVICE_CLASS entry take care of this? I thought it had been added specifically for this purpose. It doesn't seem right to add vendor specific entries for generic hardware in each generic driver. Arnd ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] ata: ahci_platform: Add ACPI support for APM X-Gene AHCI controller v3 hardware. 2016-06-16 6:54 ` [PATCH] ata: ahci_platform: Add ACPI support for APM X-Gene AHCI controller v3 hardware Arnd Bergmann @ 2016-06-21 18:08 ` Suman Tripathi 2016-06-21 23:31 ` Suman Tripathi 0 siblings, 1 reply; 6+ messages in thread From: Suman Tripathi @ 2016-06-21 18:08 UTC (permalink / raw) To: linux-arm-kernel On Wed, Jun 15, 2016 at 11:54 PM, Arnd Bergmann <arnd@arndb.de> wrote: > > On Wednesday, June 15, 2016 5:44:00 PM CEST suman-tripathi wrote: > > This patch adds ACPI support for APM X-Gene AHCI controller in > > ahci_platform driver for v3 hardware. APM X-Gene AHCI controller > > v3 hardware is fully compliant with ahci_platform driver and requires > > no workaround quirk. > > > > Signed-off-by: Suman Tripathi <stripathi@apm.com> > > --- > > drivers/ata/ahci_platform.c | 1 + > > 1 files changed, 1 insertions(+), 0 deletions(-) > > > > diff --git a/drivers/ata/ahci_platform.c b/drivers/ata/ahci_platform.c > > index 62a04c8..3395baf 100644 > > --- a/drivers/ata/ahci_platform.c > > +++ b/drivers/ata/ahci_platform.c > > @@ -86,6 +86,7 @@ MODULE_DEVICE_TABLE(of, ahci_of_match); > > > > static const struct acpi_device_id ahci_acpi_match[] = { > > { ACPI_DEVICE_CLASS(PCI_CLASS_STORAGE_SATA_AHCI, 0xffffff) }, > > + { "APMC0D33", 0}, > > {}, > > }; > > MODULE_DEVICE_TABLE(acpi, ahci_acpi_match); > > > > Doesn't the ACPI_DEVICE_CLASS entry take care of this? I thought it had been yeah it also works. Just thought that we need something different as our's is a non-PCI SATA. > > added specifically for this purpose. It doesn't seem right to add vendor > specific entries for generic hardware in each generic driver. > > Arnd -- Thanks, with regards, Suman Tripathi ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] ata: ahci_platform: Add ACPI support for APM X-Gene AHCI controller v3 hardware. 2016-06-21 18:08 ` Suman Tripathi @ 2016-06-21 23:31 ` Suman Tripathi 2016-06-22 10:18 ` Arnd Bergmann 2016-07-05 9:07 ` Graeme Gregory 0 siblings, 2 replies; 6+ messages in thread From: Suman Tripathi @ 2016-06-21 23:31 UTC (permalink / raw) To: linux-arm-kernel Hi Arnd, On Tue, Jun 21, 2016 at 11:08 AM, Suman Tripathi <stripathi@apm.com> wrote: > On Wed, Jun 15, 2016 at 11:54 PM, Arnd Bergmann <arnd@arndb.de> wrote: >> >> On Wednesday, June 15, 2016 5:44:00 PM CEST suman-tripathi wrote: >> > This patch adds ACPI support for APM X-Gene AHCI controller in >> > ahci_platform driver for v3 hardware. APM X-Gene AHCI controller >> > v3 hardware is fully compliant with ahci_platform driver and requires >> > no workaround quirk. >> > >> > Signed-off-by: Suman Tripathi <stripathi@apm.com> >> > --- >> > drivers/ata/ahci_platform.c | 1 + >> > 1 files changed, 1 insertions(+), 0 deletions(-) >> > >> > diff --git a/drivers/ata/ahci_platform.c b/drivers/ata/ahci_platform.c >> > index 62a04c8..3395baf 100644 >> > --- a/drivers/ata/ahci_platform.c >> > +++ b/drivers/ata/ahci_platform.c >> > @@ -86,6 +86,7 @@ MODULE_DEVICE_TABLE(of, ahci_of_match); >> > >> > static const struct acpi_device_id ahci_acpi_match[] = { >> > { ACPI_DEVICE_CLASS(PCI_CLASS_STORAGE_SATA_AHCI, 0xffffff) }, >> > + { "APMC0D33", 0}, >> > {}, >> > }; >> > MODULE_DEVICE_TABLE(acpi, ahci_acpi_match); >> > >> >> Doesn't the ACPI_DEVICE_CLASS entry take care of this? I thought it had been > > > yeah it also works. Just thought that we need something different as > our's is a non-PCI SATA. Are you suggesting to introduce a new class ACPI_DEVICE_CLASS for non-pci ahci ? or to reuse the existing PCI_CLASS_STORAGE_SATA_AHCI ? >> >> added specifically for this purpose. It doesn't seem right to add vendor >> specific entries for generic hardware in each generic driver. >> >> Arnd > > > > > -- > Thanks, > with regards, > Suman Tripathi -- Thanks, with regards, Suman Tripathi ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] ata: ahci_platform: Add ACPI support for APM X-Gene AHCI controller v3 hardware. 2016-06-21 23:31 ` Suman Tripathi @ 2016-06-22 10:18 ` Arnd Bergmann 2016-07-05 9:07 ` Graeme Gregory 1 sibling, 0 replies; 6+ messages in thread From: Arnd Bergmann @ 2016-06-22 10:18 UTC (permalink / raw) To: linux-arm-kernel On Tuesday, June 21, 2016 4:31:38 PM CEST Suman Tripathi wrote: > On Tue, Jun 21, 2016 at 11:08 AM, Suman Tripathi <stripathi@apm.com> wrote: > > On Wed, Jun 15, 2016 at 11:54 PM, Arnd Bergmann <arnd@arndb.de> wrote: > >> > >> On Wednesday, June 15, 2016 5:44:00 PM CEST suman-tripathi wrote: > >> > This patch adds ACPI support for APM X-Gene AHCI controller in > >> > ahci_platform driver for v3 hardware. APM X-Gene AHCI controller > >> > v3 hardware is fully compliant with ahci_platform driver and requires > >> > no workaround quirk. > >> > > >> > Signed-off-by: Suman Tripathi <stripathi@apm.com> > >> > --- > >> > drivers/ata/ahci_platform.c | 1 + > >> > 1 files changed, 1 insertions(+), 0 deletions(-) > >> > > >> > diff --git a/drivers/ata/ahci_platform.c b/drivers/ata/ahci_platform.c > >> > index 62a04c8..3395baf 100644 > >> > --- a/drivers/ata/ahci_platform.c > >> > +++ b/drivers/ata/ahci_platform.c > >> > @@ -86,6 +86,7 @@ MODULE_DEVICE_TABLE(of, ahci_of_match); > >> > > >> > static const struct acpi_device_id ahci_acpi_match[] = { > >> > { ACPI_DEVICE_CLASS(PCI_CLASS_STORAGE_SATA_AHCI, 0xffffff) }, > >> > + { "APMC0D33", 0}, > >> > {}, > >> > }; > >> > MODULE_DEVICE_TABLE(acpi, ahci_acpi_match); > >> > > >> > >> Doesn't the ACPI_DEVICE_CLASS entry take care of this? I thought it had been > > > > > > yeah it also works. Just thought that we need something different as > > our's is a non-PCI SATA. > > Are you suggesting to introduce a new class ACPI_DEVICE_CLASS for > non-pci ahci ? or to reuse the existing PCI_CLASS_STORAGE_SATA_AHCI ? This was specifically introduced for non-PCI devices, so it should just work. Arnd ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] ata: ahci_platform: Add ACPI support for APM X-Gene AHCI controller v3 hardware. 2016-06-21 23:31 ` Suman Tripathi 2016-06-22 10:18 ` Arnd Bergmann @ 2016-07-05 9:07 ` Graeme Gregory 2016-07-05 18:01 ` Suman Tripathi 1 sibling, 1 reply; 6+ messages in thread From: Graeme Gregory @ 2016-07-05 9:07 UTC (permalink / raw) To: linux-arm-kernel On Tue, Jun 21, 2016 at 04:31:38PM -0700, Suman Tripathi wrote: > Hi Arnd, > > On Tue, Jun 21, 2016 at 11:08 AM, Suman Tripathi <stripathi@apm.com> wrote: > > On Wed, Jun 15, 2016 at 11:54 PM, Arnd Bergmann <arnd@arndb.de> wrote: > >> > >> On Wednesday, June 15, 2016 5:44:00 PM CEST suman-tripathi wrote: > >> > This patch adds ACPI support for APM X-Gene AHCI controller in > >> > ahci_platform driver for v3 hardware. APM X-Gene AHCI controller > >> > v3 hardware is fully compliant with ahci_platform driver and requires > >> > no workaround quirk. > >> > > >> > Signed-off-by: Suman Tripathi <stripathi@apm.com> > >> > --- > >> > drivers/ata/ahci_platform.c | 1 + > >> > 1 files changed, 1 insertions(+), 0 deletions(-) > >> > > >> > diff --git a/drivers/ata/ahci_platform.c b/drivers/ata/ahci_platform.c > >> > index 62a04c8..3395baf 100644 > >> > --- a/drivers/ata/ahci_platform.c > >> > +++ b/drivers/ata/ahci_platform.c > >> > @@ -86,6 +86,7 @@ MODULE_DEVICE_TABLE(of, ahci_of_match); > >> > > >> > static const struct acpi_device_id ahci_acpi_match[] = { > >> > { ACPI_DEVICE_CLASS(PCI_CLASS_STORAGE_SATA_AHCI, 0xffffff) }, > >> > + { "APMC0D33", 0}, > >> > {}, > >> > }; > >> > MODULE_DEVICE_TABLE(acpi, ahci_acpi_match); > >> > > >> > >> Doesn't the ACPI_DEVICE_CLASS entry take care of this? I thought it had been > > > > > > yeah it also works. Just thought that we need something different as > > our's is a non-PCI SATA. > > Are you suggesting to introduce a new class ACPI_DEVICE_CLASS for > non-pci ahci ? or to reuse the existing PCI_CLASS_STORAGE_SATA_AHCI ? This was discussed when AMD Seattle SoC had the same issue and it was decided in standards body and on LKML that using PCI device classes for non PCI devices was fine. Example from Overdrive DSDT Device (AHC0) { Name (_HID, "AMDI0600") // _HID: Hardware ID Name (_UID, 0x00) // _UID: Unique ID Name (_CCA, 0x01) // _CCA: Cache Coherency Attribute Name (_CLS, Package (0x03) // _CLS: Class Code { 0x01, 0x06, 0x01 }) ... Graeme ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] ata: ahci_platform: Add ACPI support for APM X-Gene AHCI controller v3 hardware. 2016-07-05 9:07 ` Graeme Gregory @ 2016-07-05 18:01 ` Suman Tripathi 0 siblings, 0 replies; 6+ messages in thread From: Suman Tripathi @ 2016-07-05 18:01 UTC (permalink / raw) To: linux-arm-kernel On Tue, Jul 5, 2016 at 2:07 AM, Graeme Gregory <gg@slimlogic.co.uk> wrote: > > On Tue, Jun 21, 2016 at 04:31:38PM -0700, Suman Tripathi wrote: > > Hi Arnd, > > > > On Tue, Jun 21, 2016 at 11:08 AM, Suman Tripathi <stripathi@apm.com> wrote: > > > On Wed, Jun 15, 2016 at 11:54 PM, Arnd Bergmann <arnd@arndb.de> wrote: > > >> > > >> On Wednesday, June 15, 2016 5:44:00 PM CEST suman-tripathi wrote: > > >> > This patch adds ACPI support for APM X-Gene AHCI controller in > > >> > ahci_platform driver for v3 hardware. APM X-Gene AHCI controller > > >> > v3 hardware is fully compliant with ahci_platform driver and requires > > >> > no workaround quirk. > > >> > > > >> > Signed-off-by: Suman Tripathi <stripathi@apm.com> > > >> > --- > > >> > drivers/ata/ahci_platform.c | 1 + > > >> > 1 files changed, 1 insertions(+), 0 deletions(-) > > >> > > > >> > diff --git a/drivers/ata/ahci_platform.c b/drivers/ata/ahci_platform.c > > >> > index 62a04c8..3395baf 100644 > > >> > --- a/drivers/ata/ahci_platform.c > > >> > +++ b/drivers/ata/ahci_platform.c > > >> > @@ -86,6 +86,7 @@ MODULE_DEVICE_TABLE(of, ahci_of_match); > > >> > > > >> > static const struct acpi_device_id ahci_acpi_match[] = { > > >> > { ACPI_DEVICE_CLASS(PCI_CLASS_STORAGE_SATA_AHCI, 0xffffff) }, > > >> > + { "APMC0D33", 0}, > > >> > {}, > > >> > }; > > >> > MODULE_DEVICE_TABLE(acpi, ahci_acpi_match); > > >> > > > >> > > >> Doesn't the ACPI_DEVICE_CLASS entry take care of this? I thought it had been > > > > > > > > > yeah it also works. Just thought that we need something different as > > > our's is a non-PCI SATA. > > > > Are you suggesting to introduce a new class ACPI_DEVICE_CLASS for > > non-pci ahci ? or to reuse the existing PCI_CLASS_STORAGE_SATA_AHCI ? > > This was discussed when AMD Seattle SoC had the same issue and it was > decided in standards body and on LKML that using PCI device classes for > non PCI devices was fine. > > Example from Overdrive DSDT > > Device (AHC0) > { > Name (_HID, "AMDI0600") // _HID: Hardware ID > Name (_UID, 0x00) // _UID: Unique ID > Name (_CCA, 0x01) // _CCA: Cache Coherency Attribute > Name (_CLS, > Package (0x03) // _CLS: Class Code > { > 0x01, > 0x06, > 0x01 > }) Got it. Will do the same. Thanks !! > > ... > > Graeme > -- Thanks, with regards, Suman Tripathi ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-07-05 18:01 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <stripathi@apm.com>
[not found] ` <1466034240-22694-1-git-send-email-stripathi@apm.com>
2016-06-16 6:54 ` [PATCH] ata: ahci_platform: Add ACPI support for APM X-Gene AHCI controller v3 hardware Arnd Bergmann
2016-06-21 18:08 ` Suman Tripathi
2016-06-21 23:31 ` Suman Tripathi
2016-06-22 10:18 ` Arnd Bergmann
2016-07-05 9:07 ` Graeme Gregory
2016-07-05 18:01 ` Suman Tripathi
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox