From: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
To: Maxime Ripard <maxime.ripard@bootlin.com>, Eric Anholt <eric@anholt.net>
Cc: eben@raspberrypi.org,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
dri-devel@lists.freedesktop.org,
Sean Paul <seanpaul@chromium.org>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] drm/vc4: Use 16bpp by default for the fbdev buffer
Date: Wed, 06 Mar 2019 16:06:44 +0100 [thread overview]
Message-ID: <672c7eba534ca4b8008da6c5016a8c3881db5914.camel@bootlin.com> (raw)
In-Reply-To: <20190306140245.21973-1-maxime.ripard@bootlin.com>
On Wed, 2019-03-06 at 15:02 +0100, Maxime Ripard wrote:
> The preferred bpp for the fbdev emulation buffer has been 32 so far, which
> means that by default we will allocate an 8MB buffer with a 1920x1080
> resolution.
>
> Worse this memory will be allocated from the CMA pool, and will never be
> freed even if we don't use the fbdev emulation. Therefore, reducing it is a
> big deal, and switching to 16bpp by default will gain us around 4MB at
> 1920x1080, while keeping decent color depth. And users still have the
> option to switch to 32bpp using the kernel command line.
>
> Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>
Reviewed-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
Cheers,
Paul
> ---
> drivers/gpu/drm/vc4/vc4_drv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/vc4/vc4_drv.c b/drivers/gpu/drm/vc4/vc4_drv.c
> index 52576dee809e..c38cf64837e1 100644
> --- a/drivers/gpu/drm/vc4/vc4_drv.c
> +++ b/drivers/gpu/drm/vc4/vc4_drv.c
> @@ -286,7 +286,7 @@ static int vc4_drm_bind(struct device *dev)
>
> vc4_kms_load(drm);
>
> - drm_fbdev_generic_setup(drm, 32);
> + drm_fbdev_generic_setup(drm, 16);
>
> return 0;
>
--
Paul Kocialkowski, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-03-06 15:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-06 14:02 [PATCH] drm/vc4: Use 16bpp by default for the fbdev buffer Maxime Ripard
2019-03-06 15:06 ` Paul Kocialkowski [this message]
2019-03-06 17:32 ` Eric Anholt
2019-03-07 12:14 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=672c7eba534ca4b8008da6c5016a8c3881db5914.camel@bootlin.com \
--to=paul.kocialkowski@bootlin.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=eben@raspberrypi.org \
--cc=eric@anholt.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=maxime.ripard@bootlin.com \
--cc=seanpaul@chromium.org \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox