Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org
Subject: Re: [PATCH] arm64: dts: mediatek: Remove undocumented, unapproved aliases
Date: Wed, 18 Nov 2026 13:30:42 +0100	[thread overview]
Message-ID: <68df102e-66e0-4049-9ffd-8e2746db8403@collabora.com> (raw)
In-Reply-To: <96e3cc39-d10b-4743-bd9a-d683a91fdf34@oss.qualcomm.com>

On 11/18/26 13:09, Krzysztof Kozlowski wrote:
> On 17/11/2026 15:06, AngeloGioacchino Del Regno wrote:
>> On 11/17/26 14:05, Krzysztof Kozlowski wrote:
>>> The ovl, aal, color, dsi, gce, rdma, split and other aliases were never
>>> approved by Devicetree maintainers, because they were never documented
>>> as actual ABI.  Drop them, because no new custom aliases are allowed for
>>> years now.
>>>
>>> This might break users of this undocumented ABI, so these should be
>>> updated to use only documented and approved ABI.
>>>
>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
>>
>> That'll just break everything.
> 
> True, almost everything. I suppose few aliases are not used, but rest are.
> 

Would still create regressions, and that's not acceptable - the cleanup can be
done only - and exclusively - after addressing the situation elsewhere so that
no regressions are seen.

Still, a question mark remains on "new DT on old kernel" compatibility which would
miserably break - that may not be something to care about in this case, and I don't
think that it's time to start thinking about that.

> Well, it's a start of a discussion. :)

Yes, I like this spirit.

> 
>>
>> I do have a mediatek-drm restructuring series that is partially resolving this
>> situation, at least for some SoCs it's getting 0 and 1 hw instance id dynamically
>> recognized, but with some caveats that could be unacceptable (as in, if 0 is
>> disabled and 1 is enabled, 1 becomes 0, so it's not actually resolving anything
>> for real, it's just making it tick right when stars in the sky align in the
>> right way, which for some SoCs is reliably possible without side effects).
>>
>> In any case, all of the ones that have only instance 0 (and all of the instance
>> 0s) can be removed even right now already (still needs some testing to make sure
>> that there's no regression), but everything else can't, at least not until the
>> whole restructuring thing is merged as that'd break things.
>>
>> Worst part is we have two new SoCs (MT8196, MT8189) ready to be upstreamed here,
>> which took almost a year of development... and it also does rely on the aliases.
>> I was in the process of slowly cleaning up those (as I said, there's already a
>> restructuring that makes things a little better in this regard), but at this point
>> that'll need to be done with the highest possible priority.
> 
> That's unfortunate and still new DTS/DTSI should not come with these
> aliases.
> 

Indeed.

Since conversations went on in the other thread, though, if we have to spend any
other word on this topic, I think it's a better idea to continue on the other one
( 94ed1340-94bd-49ee-ba31-9bb63164c89a@kernel.org ) and let this one go.

Cheers!
Angelo


  reply	other threads:[~2026-11-18 12:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17 13:05 [PATCH] arm64: dts: mediatek: Remove undocumented, unapproved aliases Krzysztof Kozlowski
2026-11-17 14:06 ` AngeloGioacchino Del Regno
2026-11-18 12:09   ` Krzysztof Kozlowski
2026-11-18 12:30     ` AngeloGioacchino Del Regno [this message]
2026-11-17 14:16 ` Akari Tsuyukusa
2026-11-17 14:26   ` AngeloGioacchino Del Regno

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=68df102e-66e0-4049-9ffd-8e2746db8403@collabora.com \
    --to=angelogioacchino.delregno@collabora.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzysztof.kozlowski@oss.qualcomm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox