* [PATCH] arm64: dts: mediatek: Remove undocumented, unapproved aliases @ 2026-11-17 13:05 Krzysztof Kozlowski 2026-11-17 14:06 ` AngeloGioacchino Del Regno 2026-11-17 14:16 ` Akari Tsuyukusa 0 siblings, 2 replies; 6+ messages in thread From: Krzysztof Kozlowski @ 2026-11-17 13:05 UTC (permalink / raw) To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Matthias Brugger, AngeloGioacchino Del Regno, devicetree, linux-kernel, linux-arm-kernel, linux-mediatek Cc: Krzysztof Kozlowski The ovl, aal, color, dsi, gce, rdma, split and other aliases were never approved by Devicetree maintainers, because they were never documented as actual ABI. Drop them, because no new custom aliases are allowed for years now. This might break users of this undocumented ABI, so these should be updated to use only documented and approved ABI. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com> --- arch/arm64/boot/dts/mediatek/mt6795.dtsi | 17 ---------- arch/arm64/boot/dts/mediatek/mt8173.dtsi | 16 --------- arch/arm64/boot/dts/mediatek/mt8183.dtsi | 5 --- arch/arm64/boot/dts/mediatek/mt8186.dtsi | 7 ---- .../boot/dts/mediatek/mt8188-geralt.dtsi | 1 - arch/arm64/boot/dts/mediatek/mt8188.dtsi | 33 ------------------- arch/arm64/boot/dts/mediatek/mt8192.dtsi | 8 ----- arch/arm64/boot/dts/mediatek/mt8195.dtsi | 24 -------------- arch/arm64/boot/dts/mediatek/mt8365.dtsi | 13 -------- .../dts/mediatek/mt8390-genio-common.dtsi | 1 - .../dts/mediatek/mt8390-tungsten-smarc.dtsi | 1 - 11 files changed, 126 deletions(-) diff --git a/arch/arm64/boot/dts/mediatek/mt6795.dtsi b/arch/arm64/boot/dts/mediatek/mt6795.dtsi index 6dd706b27830..971fb19e95df 100644 --- a/arch/arm64/boot/dts/mediatek/mt6795.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt6795.dtsi @@ -21,23 +21,6 @@ / { #address-cells = <2>; #size-cells = <2>; - aliases { - ovl0 = &ovl0; - ovl1 = &ovl1; - rdma0 = &rdma0; - rdma1 = &rdma1; - rdma2 = &rdma2; - wdma0 = &wdma0; - wdma1 = &wdma1; - color0 = &color0; - color1 = &color1; - split0 = &split0; - split1 = &split1; - dpi0 = &dpi0; - dsi0 = &dsi0; - dsi1 = &dsi1; - }; - psci { compatible = "arm,psci-0.2"; method = "smc"; diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi index 6ec50125cea0..868b0fb84449 100644 --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi @@ -22,22 +22,6 @@ / { #size-cells = <2>; aliases { - ovl0 = &ovl0; - ovl1 = &ovl1; - rdma0 = &rdma0; - rdma1 = &rdma1; - rdma2 = &rdma2; - wdma0 = &wdma0; - wdma1 = &wdma1; - color0 = &color0; - color1 = &color1; - split0 = &split0; - split1 = &split1; - dpi0 = &dpi0; - dsi0 = &dsi0; - dsi1 = &dsi1; - mdp-rdma0 = &mdp_rdma0; - mdp-rdma1 = &mdp_rdma1; mdp-rsz0 = &mdp_rsz0; mdp-rsz1 = &mdp_rsz1; mdp-rsz2 = &mdp_rsz2; diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi index 7414c10ee664..2c3836555e55 100644 --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi @@ -35,11 +35,6 @@ aliases { i2c9 = &i2c9; i2c10 = &i2c10; i2c11 = &i2c11; - ovl0 = &ovl0; - ovl-2l0 = &ovl_2l0; - ovl-2l1 = &ovl_2l1; - rdma0 = &rdma0; - rdma1 = &rdma1; }; cluster0_opp: opp-table-cluster0 { diff --git a/arch/arm64/boot/dts/mediatek/mt8186.dtsi b/arch/arm64/boot/dts/mediatek/mt8186.dtsi index 621408439ffa..2f82eb532f30 100644 --- a/arch/arm64/boot/dts/mediatek/mt8186.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt8186.dtsi @@ -22,13 +22,6 @@ / { #address-cells = <2>; #size-cells = <2>; - aliases { - ovl0 = &ovl0; - ovl-2l0 = &ovl_2l0; - rdma0 = &rdma0; - rdma1 = &rdma1; - }; - fhctl: fhctl@1000ce00 { compatible = "mediatek,mt8186-fhctl"; clocks = <&apmixedsys CLK_APMIXED_TVDPLL>; diff --git a/arch/arm64/boot/dts/mediatek/mt8188-geralt.dtsi b/arch/arm64/boot/dts/mediatek/mt8188-geralt.dtsi index 801eee735afe..883141d8a6d5 100644 --- a/arch/arm64/boot/dts/mediatek/mt8188-geralt.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt8188-geralt.dtsi @@ -9,7 +9,6 @@ / { aliases { - dsi0 = &disp_dsi0; i2c0 = &i2c0; i2c1 = &i2c1; i2c2 = &i2c2; diff --git a/arch/arm64/boot/dts/mediatek/mt8188.dtsi b/arch/arm64/boot/dts/mediatek/mt8188.dtsi index 14a320f0c70c..f14b23dd57aa 100644 --- a/arch/arm64/boot/dts/mediatek/mt8188.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt8188.dtsi @@ -23,39 +23,6 @@ / { #address-cells = <2>; #size-cells = <2>; - aliases { - dp-intf0 = &dp_intf0; - dp-intf1 = &dp_intf1; - dpi1 = &dpi1; - dsc0 = &dsc0; - ethdr0 = ðdr0; - gce0 = &gce0; - gce1 = &gce1; - merge0 = &merge0; - merge1 = &merge1; - merge2 = &merge2; - merge3 = &merge3; - merge4 = &merge4; - merge5 = &merge5; - mutex0 = &mutex0; - mutex1 = &mutex1; - padding0 = &padding0; - padding1 = &padding1; - padding2 = &padding2; - padding3 = &padding3; - padding4 = &padding4; - padding5 = &padding5; - padding6 = &padding6; - padding7 = &padding7; - vdo1-rdma0 = &vdo1_rdma0; - vdo1-rdma1 = &vdo1_rdma1; - vdo1-rdma2 = &vdo1_rdma2; - vdo1-rdma3 = &vdo1_rdma3; - vdo1-rdma4 = &vdo1_rdma4; - vdo1-rdma5 = &vdo1_rdma5; - vdo1-rdma6 = &vdo1_rdma6; - vdo1-rdma7 = &vdo1_rdma7; - }; cpus { #address-cells = <1>; diff --git a/arch/arm64/boot/dts/mediatek/mt8192.dtsi b/arch/arm64/boot/dts/mediatek/mt8192.dtsi index 898953acdb61..bf5893e3002b 100644 --- a/arch/arm64/boot/dts/mediatek/mt8192.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt8192.dtsi @@ -23,14 +23,6 @@ / { #address-cells = <2>; #size-cells = <2>; - aliases { - ovl0 = &ovl0; - ovl-2l0 = &ovl_2l0; - ovl-2l2 = &ovl_2l2; - rdma0 = &rdma0; - rdma4 = &rdma4; - }; - clk13m: fixed-factor-clock-13m { compatible = "fixed-factor-clock"; #clock-cells = <0>; diff --git a/arch/arm64/boot/dts/mediatek/mt8195.dtsi b/arch/arm64/boot/dts/mediatek/mt8195.dtsi index 9aaf8b6edcb5..389fb9d7ea89 100644 --- a/arch/arm64/boot/dts/mediatek/mt8195.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt8195.dtsi @@ -23,30 +23,6 @@ / { #address-cells = <2>; #size-cells = <2>; - aliases { - dp-intf0 = &dp_intf0; - dp-intf1 = &dp_intf1; - dpi1 = &dpi1; - gce0 = &gce0; - gce1 = &gce1; - hdmi0 = &hdmi; - ethdr0 = ðdr0; - mutex0 = &mutex; - mutex1 = &mutex1; - merge1 = &merge1; - merge2 = &merge2; - merge3 = &merge3; - merge4 = &merge4; - merge5 = &merge5; - vdo1-rdma0 = &vdo1_rdma0; - vdo1-rdma1 = &vdo1_rdma1; - vdo1-rdma2 = &vdo1_rdma2; - vdo1-rdma3 = &vdo1_rdma3; - vdo1-rdma4 = &vdo1_rdma4; - vdo1-rdma5 = &vdo1_rdma5; - vdo1-rdma6 = &vdo1_rdma6; - vdo1-rdma7 = &vdo1_rdma7; - }; cpus { #address-cells = <1>; diff --git a/arch/arm64/boot/dts/mediatek/mt8365.dtsi b/arch/arm64/boot/dts/mediatek/mt8365.dtsi index 2e782558fb77..4b05f6a864d4 100644 --- a/arch/arm64/boot/dts/mediatek/mt8365.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt8365.dtsi @@ -20,19 +20,6 @@ / { #address-cells = <2>; #size-cells = <2>; - aliases { - aal0 = &aal0; - ccorr0 = &ccorr0; - color0 = &color0; - dither0 = &dither0; - dpi0 = &dpi0; - dsi0 = &dsi0; - gamma0 = &gamma0; - ovl0 = &ovl0; - rdma0 = &rdma0; - rdma1 = &rdma1; - }; - cpus { #address-cells = <1>; #size-cells = <0>; diff --git a/arch/arm64/boot/dts/mediatek/mt8390-genio-common.dtsi b/arch/arm64/boot/dts/mediatek/mt8390-genio-common.dtsi index 669eaec662f3..a938539c92b8 100644 --- a/arch/arm64/boot/dts/mediatek/mt8390-genio-common.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt8390-genio-common.dtsi @@ -21,7 +21,6 @@ / { aliases { - dsi0 = &disp_dsi0; ethernet0 = ð i2c0 = &i2c0; i2c1 = &i2c1; diff --git a/arch/arm64/boot/dts/mediatek/mt8390-tungsten-smarc.dtsi b/arch/arm64/boot/dts/mediatek/mt8390-tungsten-smarc.dtsi index f2ad9265be31..d70bed80274b 100644 --- a/arch/arm64/boot/dts/mediatek/mt8390-tungsten-smarc.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt8390-tungsten-smarc.dtsi @@ -16,7 +16,6 @@ / { aliases { - dsi0 = &disp_dsi0; ethernet0 = ð i2c0 = &i2c0; i2c1 = &i2c1; -- 2.53.0 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: dts: mediatek: Remove undocumented, unapproved aliases 2026-11-17 13:05 [PATCH] arm64: dts: mediatek: Remove undocumented, unapproved aliases Krzysztof Kozlowski @ 2026-11-17 14:06 ` AngeloGioacchino Del Regno 2026-11-18 12:09 ` Krzysztof Kozlowski 2026-11-17 14:16 ` Akari Tsuyukusa 1 sibling, 1 reply; 6+ messages in thread From: AngeloGioacchino Del Regno @ 2026-11-17 14:06 UTC (permalink / raw) To: Krzysztof Kozlowski, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Matthias Brugger, devicetree, linux-kernel, linux-arm-kernel, linux-mediatek On 11/17/26 14:05, Krzysztof Kozlowski wrote: > The ovl, aal, color, dsi, gce, rdma, split and other aliases were never > approved by Devicetree maintainers, because they were never documented > as actual ABI. Drop them, because no new custom aliases are allowed for > years now. > > This might break users of this undocumented ABI, so these should be > updated to use only documented and approved ABI. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com> That'll just break everything. I do have a mediatek-drm restructuring series that is partially resolving this situation, at least for some SoCs it's getting 0 and 1 hw instance id dynamically recognized, but with some caveats that could be unacceptable (as in, if 0 is disabled and 1 is enabled, 1 becomes 0, so it's not actually resolving anything for real, it's just making it tick right when stars in the sky align in the right way, which for some SoCs is reliably possible without side effects). In any case, all of the ones that have only instance 0 (and all of the instance 0s) can be removed even right now already (still needs some testing to make sure that there's no regression), but everything else can't, at least not until the whole restructuring thing is merged as that'd break things. Worst part is we have two new SoCs (MT8196, MT8189) ready to be upstreamed here, which took almost a year of development... and it also does rely on the aliases. I was in the process of slowly cleaning up those (as I said, there's already a restructuring that makes things a little better in this regard), but at this point that'll need to be done with the highest possible priority. Let me see what can I do to make the right thing to happen. Anyway - thanks for pointing this. Cheers, Angelo > --- > arch/arm64/boot/dts/mediatek/mt6795.dtsi | 17 ---------- > arch/arm64/boot/dts/mediatek/mt8173.dtsi | 16 --------- > arch/arm64/boot/dts/mediatek/mt8183.dtsi | 5 --- > arch/arm64/boot/dts/mediatek/mt8186.dtsi | 7 ---- > .../boot/dts/mediatek/mt8188-geralt.dtsi | 1 - > arch/arm64/boot/dts/mediatek/mt8188.dtsi | 33 ------------------- > arch/arm64/boot/dts/mediatek/mt8192.dtsi | 8 ----- > arch/arm64/boot/dts/mediatek/mt8195.dtsi | 24 -------------- > arch/arm64/boot/dts/mediatek/mt8365.dtsi | 13 -------- > .../dts/mediatek/mt8390-genio-common.dtsi | 1 - > .../dts/mediatek/mt8390-tungsten-smarc.dtsi | 1 - > 11 files changed, 126 deletions(-) > > diff --git a/arch/arm64/boot/dts/mediatek/mt6795.dtsi b/arch/arm64/boot/dts/mediatek/mt6795.dtsi > index 6dd706b27830..971fb19e95df 100644 > --- a/arch/arm64/boot/dts/mediatek/mt6795.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt6795.dtsi > @@ -21,23 +21,6 @@ / { > #address-cells = <2>; > #size-cells = <2>; > > - aliases { > - ovl0 = &ovl0; > - ovl1 = &ovl1; > - rdma0 = &rdma0; > - rdma1 = &rdma1; > - rdma2 = &rdma2; > - wdma0 = &wdma0; > - wdma1 = &wdma1; > - color0 = &color0; > - color1 = &color1; > - split0 = &split0; > - split1 = &split1; > - dpi0 = &dpi0; > - dsi0 = &dsi0; > - dsi1 = &dsi1; > - }; > - > psci { > compatible = "arm,psci-0.2"; > method = "smc"; > diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi > index 6ec50125cea0..868b0fb84449 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi > @@ -22,22 +22,6 @@ / { > #size-cells = <2>; > > aliases { > - ovl0 = &ovl0; > - ovl1 = &ovl1; > - rdma0 = &rdma0; > - rdma1 = &rdma1; > - rdma2 = &rdma2; > - wdma0 = &wdma0; > - wdma1 = &wdma1; > - color0 = &color0; > - color1 = &color1; > - split0 = &split0; > - split1 = &split1; > - dpi0 = &dpi0; > - dsi0 = &dsi0; > - dsi1 = &dsi1; > - mdp-rdma0 = &mdp_rdma0; > - mdp-rdma1 = &mdp_rdma1; > mdp-rsz0 = &mdp_rsz0; > mdp-rsz1 = &mdp_rsz1; > mdp-rsz2 = &mdp_rsz2; > diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi > index 7414c10ee664..2c3836555e55 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi > @@ -35,11 +35,6 @@ aliases { > i2c9 = &i2c9; > i2c10 = &i2c10; > i2c11 = &i2c11; > - ovl0 = &ovl0; > - ovl-2l0 = &ovl_2l0; > - ovl-2l1 = &ovl_2l1; > - rdma0 = &rdma0; > - rdma1 = &rdma1; > }; > > cluster0_opp: opp-table-cluster0 { > diff --git a/arch/arm64/boot/dts/mediatek/mt8186.dtsi b/arch/arm64/boot/dts/mediatek/mt8186.dtsi > index 621408439ffa..2f82eb532f30 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8186.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8186.dtsi > @@ -22,13 +22,6 @@ / { > #address-cells = <2>; > #size-cells = <2>; > > - aliases { > - ovl0 = &ovl0; > - ovl-2l0 = &ovl_2l0; > - rdma0 = &rdma0; > - rdma1 = &rdma1; > - }; > - > fhctl: fhctl@1000ce00 { > compatible = "mediatek,mt8186-fhctl"; > clocks = <&apmixedsys CLK_APMIXED_TVDPLL>; > diff --git a/arch/arm64/boot/dts/mediatek/mt8188-geralt.dtsi b/arch/arm64/boot/dts/mediatek/mt8188-geralt.dtsi > index 801eee735afe..883141d8a6d5 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8188-geralt.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8188-geralt.dtsi > @@ -9,7 +9,6 @@ > > / { > aliases { > - dsi0 = &disp_dsi0; > i2c0 = &i2c0; > i2c1 = &i2c1; > i2c2 = &i2c2; > diff --git a/arch/arm64/boot/dts/mediatek/mt8188.dtsi b/arch/arm64/boot/dts/mediatek/mt8188.dtsi > index 14a320f0c70c..f14b23dd57aa 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8188.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8188.dtsi > @@ -23,39 +23,6 @@ / { > #address-cells = <2>; > #size-cells = <2>; > > - aliases { > - dp-intf0 = &dp_intf0; > - dp-intf1 = &dp_intf1; > - dpi1 = &dpi1; > - dsc0 = &dsc0; > - ethdr0 = ðdr0; > - gce0 = &gce0; > - gce1 = &gce1; > - merge0 = &merge0; > - merge1 = &merge1; > - merge2 = &merge2; > - merge3 = &merge3; > - merge4 = &merge4; > - merge5 = &merge5; > - mutex0 = &mutex0; > - mutex1 = &mutex1; > - padding0 = &padding0; > - padding1 = &padding1; > - padding2 = &padding2; > - padding3 = &padding3; > - padding4 = &padding4; > - padding5 = &padding5; > - padding6 = &padding6; > - padding7 = &padding7; > - vdo1-rdma0 = &vdo1_rdma0; > - vdo1-rdma1 = &vdo1_rdma1; > - vdo1-rdma2 = &vdo1_rdma2; > - vdo1-rdma3 = &vdo1_rdma3; > - vdo1-rdma4 = &vdo1_rdma4; > - vdo1-rdma5 = &vdo1_rdma5; > - vdo1-rdma6 = &vdo1_rdma6; > - vdo1-rdma7 = &vdo1_rdma7; > - }; > > cpus { > #address-cells = <1>; > diff --git a/arch/arm64/boot/dts/mediatek/mt8192.dtsi b/arch/arm64/boot/dts/mediatek/mt8192.dtsi > index 898953acdb61..bf5893e3002b 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8192.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8192.dtsi > @@ -23,14 +23,6 @@ / { > #address-cells = <2>; > #size-cells = <2>; > > - aliases { > - ovl0 = &ovl0; > - ovl-2l0 = &ovl_2l0; > - ovl-2l2 = &ovl_2l2; > - rdma0 = &rdma0; > - rdma4 = &rdma4; > - }; > - > clk13m: fixed-factor-clock-13m { > compatible = "fixed-factor-clock"; > #clock-cells = <0>; > diff --git a/arch/arm64/boot/dts/mediatek/mt8195.dtsi b/arch/arm64/boot/dts/mediatek/mt8195.dtsi > index 9aaf8b6edcb5..389fb9d7ea89 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8195.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8195.dtsi > @@ -23,30 +23,6 @@ / { > #address-cells = <2>; > #size-cells = <2>; > > - aliases { > - dp-intf0 = &dp_intf0; > - dp-intf1 = &dp_intf1; > - dpi1 = &dpi1; > - gce0 = &gce0; > - gce1 = &gce1; > - hdmi0 = &hdmi; > - ethdr0 = ðdr0; > - mutex0 = &mutex; > - mutex1 = &mutex1; > - merge1 = &merge1; > - merge2 = &merge2; > - merge3 = &merge3; > - merge4 = &merge4; > - merge5 = &merge5; > - vdo1-rdma0 = &vdo1_rdma0; > - vdo1-rdma1 = &vdo1_rdma1; > - vdo1-rdma2 = &vdo1_rdma2; > - vdo1-rdma3 = &vdo1_rdma3; > - vdo1-rdma4 = &vdo1_rdma4; > - vdo1-rdma5 = &vdo1_rdma5; > - vdo1-rdma6 = &vdo1_rdma6; > - vdo1-rdma7 = &vdo1_rdma7; > - }; > > cpus { > #address-cells = <1>; > diff --git a/arch/arm64/boot/dts/mediatek/mt8365.dtsi b/arch/arm64/boot/dts/mediatek/mt8365.dtsi > index 2e782558fb77..4b05f6a864d4 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8365.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8365.dtsi > @@ -20,19 +20,6 @@ / { > #address-cells = <2>; > #size-cells = <2>; > > - aliases { > - aal0 = &aal0; > - ccorr0 = &ccorr0; > - color0 = &color0; > - dither0 = &dither0; > - dpi0 = &dpi0; > - dsi0 = &dsi0; > - gamma0 = &gamma0; > - ovl0 = &ovl0; > - rdma0 = &rdma0; > - rdma1 = &rdma1; > - }; > - > cpus { > #address-cells = <1>; > #size-cells = <0>; > diff --git a/arch/arm64/boot/dts/mediatek/mt8390-genio-common.dtsi b/arch/arm64/boot/dts/mediatek/mt8390-genio-common.dtsi > index 669eaec662f3..a938539c92b8 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8390-genio-common.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8390-genio-common.dtsi > @@ -21,7 +21,6 @@ > > / { > aliases { > - dsi0 = &disp_dsi0; > ethernet0 = ð > i2c0 = &i2c0; > i2c1 = &i2c1; > diff --git a/arch/arm64/boot/dts/mediatek/mt8390-tungsten-smarc.dtsi b/arch/arm64/boot/dts/mediatek/mt8390-tungsten-smarc.dtsi > index f2ad9265be31..d70bed80274b 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8390-tungsten-smarc.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8390-tungsten-smarc.dtsi > @@ -16,7 +16,6 @@ > > / { > aliases { > - dsi0 = &disp_dsi0; > ethernet0 = ð > i2c0 = &i2c0; > i2c1 = &i2c1; ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: dts: mediatek: Remove undocumented, unapproved aliases 2026-11-17 14:06 ` AngeloGioacchino Del Regno @ 2026-11-18 12:09 ` Krzysztof Kozlowski 2026-11-18 12:30 ` AngeloGioacchino Del Regno 0 siblings, 1 reply; 6+ messages in thread From: Krzysztof Kozlowski @ 2026-11-18 12:09 UTC (permalink / raw) To: AngeloGioacchino Del Regno, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Matthias Brugger, devicetree, linux-kernel, linux-arm-kernel, linux-mediatek On 17/11/2026 15:06, AngeloGioacchino Del Regno wrote: > On 11/17/26 14:05, Krzysztof Kozlowski wrote: >> The ovl, aal, color, dsi, gce, rdma, split and other aliases were never >> approved by Devicetree maintainers, because they were never documented >> as actual ABI. Drop them, because no new custom aliases are allowed for >> years now. >> >> This might break users of this undocumented ABI, so these should be >> updated to use only documented and approved ABI. >> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com> > > That'll just break everything. True, almost everything. I suppose few aliases are not used, but rest are. Well, it's a start of a discussion. :) > > I do have a mediatek-drm restructuring series that is partially resolving this > situation, at least for some SoCs it's getting 0 and 1 hw instance id dynamically > recognized, but with some caveats that could be unacceptable (as in, if 0 is > disabled and 1 is enabled, 1 becomes 0, so it's not actually resolving anything > for real, it's just making it tick right when stars in the sky align in the > right way, which for some SoCs is reliably possible without side effects). > > In any case, all of the ones that have only instance 0 (and all of the instance > 0s) can be removed even right now already (still needs some testing to make sure > that there's no regression), but everything else can't, at least not until the > whole restructuring thing is merged as that'd break things. > > Worst part is we have two new SoCs (MT8196, MT8189) ready to be upstreamed here, > which took almost a year of development... and it also does rely on the aliases. > I was in the process of slowly cleaning up those (as I said, there's already a > restructuring that makes things a little better in this regard), but at this point > that'll need to be done with the highest possible priority. That's unfortunate and still new DTS/DTSI should not come with these aliases. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: dts: mediatek: Remove undocumented, unapproved aliases 2026-11-18 12:09 ` Krzysztof Kozlowski @ 2026-11-18 12:30 ` AngeloGioacchino Del Regno 0 siblings, 0 replies; 6+ messages in thread From: AngeloGioacchino Del Regno @ 2026-11-18 12:30 UTC (permalink / raw) To: Krzysztof Kozlowski, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Matthias Brugger, devicetree, linux-kernel, linux-arm-kernel, linux-mediatek On 11/18/26 13:09, Krzysztof Kozlowski wrote: > On 17/11/2026 15:06, AngeloGioacchino Del Regno wrote: >> On 11/17/26 14:05, Krzysztof Kozlowski wrote: >>> The ovl, aal, color, dsi, gce, rdma, split and other aliases were never >>> approved by Devicetree maintainers, because they were never documented >>> as actual ABI. Drop them, because no new custom aliases are allowed for >>> years now. >>> >>> This might break users of this undocumented ABI, so these should be >>> updated to use only documented and approved ABI. >>> >>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com> >> >> That'll just break everything. > > True, almost everything. I suppose few aliases are not used, but rest are. > Would still create regressions, and that's not acceptable - the cleanup can be done only - and exclusively - after addressing the situation elsewhere so that no regressions are seen. Still, a question mark remains on "new DT on old kernel" compatibility which would miserably break - that may not be something to care about in this case, and I don't think that it's time to start thinking about that. > Well, it's a start of a discussion. :) Yes, I like this spirit. > >> >> I do have a mediatek-drm restructuring series that is partially resolving this >> situation, at least for some SoCs it's getting 0 and 1 hw instance id dynamically >> recognized, but with some caveats that could be unacceptable (as in, if 0 is >> disabled and 1 is enabled, 1 becomes 0, so it's not actually resolving anything >> for real, it's just making it tick right when stars in the sky align in the >> right way, which for some SoCs is reliably possible without side effects). >> >> In any case, all of the ones that have only instance 0 (and all of the instance >> 0s) can be removed even right now already (still needs some testing to make sure >> that there's no regression), but everything else can't, at least not until the >> whole restructuring thing is merged as that'd break things. >> >> Worst part is we have two new SoCs (MT8196, MT8189) ready to be upstreamed here, >> which took almost a year of development... and it also does rely on the aliases. >> I was in the process of slowly cleaning up those (as I said, there's already a >> restructuring that makes things a little better in this regard), but at this point >> that'll need to be done with the highest possible priority. > > That's unfortunate and still new DTS/DTSI should not come with these > aliases. > Indeed. Since conversations went on in the other thread, though, if we have to spend any other word on this topic, I think it's a better idea to continue on the other one ( 94ed1340-94bd-49ee-ba31-9bb63164c89a@kernel.org ) and let this one go. Cheers! Angelo ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: dts: mediatek: Remove undocumented, unapproved aliases 2026-11-17 13:05 [PATCH] arm64: dts: mediatek: Remove undocumented, unapproved aliases Krzysztof Kozlowski 2026-11-17 14:06 ` AngeloGioacchino Del Regno @ 2026-11-17 14:16 ` Akari Tsuyukusa 2026-11-17 14:26 ` AngeloGioacchino Del Regno 1 sibling, 1 reply; 6+ messages in thread From: Akari Tsuyukusa @ 2026-11-17 14:16 UTC (permalink / raw) To: Krzysztof Kozlowski Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Matthias Brugger, AngeloGioacchino Del Regno, devicetree, linux-kernel, linux-arm-kernel, linux-mediatek Hi Krzysztof, On Tue, Nov 17, 2026 at 02:05:57PM +0100, Krzysztof Kozlowski wrote: > The ovl, aal, color, dsi, gce, rdma, split and other aliases were never > approved by Devicetree maintainers, because they were never documented > as actual ABI. Drop them, because no new custom aliases are allowed for > years now. > > This might break users of this undocumented ABI, so these should be > updated to use only documented and approved ABI. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com> You mentioned 64-bit MediaTek SoCs, but the same class of issues also exists in 32-bit MediaTek SoCs under arch/arm/boot/dts/mediatek/. For example, mt7623n.dtsi has rdma0/rdma1 aliases, while mt6589.dtsi, mt8127.dtsi and mt8135.dtsi misuse "simple-bus" for the "clocks" node. I hope this push for correctness doesn't lead to any regressions. Best regards, Akari ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: dts: mediatek: Remove undocumented, unapproved aliases 2026-11-17 14:16 ` Akari Tsuyukusa @ 2026-11-17 14:26 ` AngeloGioacchino Del Regno 0 siblings, 0 replies; 6+ messages in thread From: AngeloGioacchino Del Regno @ 2026-11-17 14:26 UTC (permalink / raw) To: Akari Tsuyukusa, Krzysztof Kozlowski Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Matthias Brugger, devicetree, linux-kernel, linux-arm-kernel, linux-mediatek On 11/17/26 15:16, Akari Tsuyukusa wrote: > Hi Krzysztof, > > On Tue, Nov 17, 2026 at 02:05:57PM +0100, Krzysztof Kozlowski wrote: >> The ovl, aal, color, dsi, gce, rdma, split and other aliases were never >> approved by Devicetree maintainers, because they were never documented >> as actual ABI. Drop them, because no new custom aliases are allowed for >> years now. >> >> This might break users of this undocumented ABI, so these should be >> updated to use only documented and approved ABI. >> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com> > > You mentioned 64-bit MediaTek SoCs, but the same class of issues also > exists in 32-bit MediaTek SoCs under arch/arm/boot/dts/mediatek/. > For example, mt7623n.dtsi has rdma0/rdma1 aliases, while mt6589.dtsi, > mt8127.dtsi and mt8135.dtsi misuse "simple-bus" for the "clocks" node. > > I hope this push for correctness doesn't lead to any regressions. > As I said, picking this right now would break all MediaTek SoCs, but that patch is just a way to get a discussion started - don't worry, noone is crazy here, this will not get merged until a decent solution that avoids regressions is found. Cheers, Angelo > Best regards, > Akari ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2026-11-18 12:30 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2026-11-17 13:05 [PATCH] arm64: dts: mediatek: Remove undocumented, unapproved aliases Krzysztof Kozlowski 2026-11-17 14:06 ` AngeloGioacchino Del Regno 2026-11-18 12:09 ` Krzysztof Kozlowski 2026-11-18 12:30 ` AngeloGioacchino Del Regno 2026-11-17 14:16 ` Akari Tsuyukusa 2026-11-17 14:26 ` AngeloGioacchino Del Regno
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox