From: Florian Fainelli <f.fainelli@gmail.com>
To: Jim Quinlan <james.quinlan@broadcom.com>,
bcm-kernel-feedback-list@broadcom.com
Cc: Jassi Brar <jassisinghbrar@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
open list <linux-kernel@vger.kernel.org>,
"moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v1 2/2] mailbox: Add Broadcom STB mailbox driver
Date: Tue, 15 Sep 2020 12:33:50 -0700 [thread overview]
Message-ID: <6924a28d-ceb6-6d96-b84a-9f8919de9866@gmail.com> (raw)
In-Reply-To: <20200915193109.16034-2-james.quinlan@broadcom.com>
Hi Jim,
On 9/15/2020 12:31 PM, Jim Quinlan wrote:
> This is a simple mailbox driver to be used by the SCMI protocol stack. It
> only implements the agent-to-platform channel; we may implement the
> platform-to-agent channel in the future. An unusual aspect of this driver
> is how the completion of an SCMI message is indicated. An SCMI message is
> initiated with an ARM SMC call, but the return of this call does not
> indicate the execution or completion of the message. Rather, the message's
> completion is signaled by an interrupt.
>
> Signed-off-by: Jim Quinlan <james.quinlan@broadcom.com>
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
> drivers/mailbox/Kconfig | 13 +++
> drivers/mailbox/Makefile | 2 +
> drivers/mailbox/brcmstb-mailbox.c | 173 ++++++++++++++++++++++++++++++
> 3 files changed, 188 insertions(+)
> create mode 100644 drivers/mailbox/brcmstb-mailbox.c
>
> diff --git a/drivers/mailbox/Kconfig b/drivers/mailbox/Kconfig
> index 05b1009e2820..bebf7da778bc 100644
> --- a/drivers/mailbox/Kconfig
> +++ b/drivers/mailbox/Kconfig
> @@ -254,4 +254,17 @@ config QCOM_IPCC
> acts as an interrupt controller for receiving interrupts from clients.
> Say Y here if you want to build this driver.
>
> +config BRCMSTB_MBOX
> + tristate "Broadcom STB Mailbox"
> + depends on ARM64 || ARM
> + depends on ARM_SCMI_PROTOCOL && ARCH_BRCMSTB
> + depends on SMP
We can actually remove the SMP dependency cannot we? This was needed
back when we used the hackish way of hooking to IPIs in the downstream
kernel which we fortunately no longer do.
--
Florian
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-09-15 19:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-15 19:31 [PATCH v1 1/2] dt-bindings: Add bindings for BrcmSTB SCMI mailbox driver Jim Quinlan
2020-09-15 19:31 ` [PATCH v1 2/2] mailbox: Add Broadcom STB " Jim Quinlan
2020-09-15 19:33 ` Florian Fainelli [this message]
2020-09-18 17:22 ` [PATCH v1 1/2] dt-bindings: Add bindings for BrcmSTB SCMI " Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6924a28d-ceb6-6d96-b84a-9f8919de9866@gmail.com \
--to=f.fainelli@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=james.quinlan@broadcom.com \
--cc=jassisinghbrar@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox