From: Fabrice Gasnier <fabrice.gasnier@st.com>
To: Coiby Xu <coiby.xu@gmail.com>, <linux-i2c@vger.kernel.org>
Cc: Alexandre Torgue <alexandre.torgue@st.com>,
open list <linux-kernel@vger.kernel.org>,
Pierre-Yves MORDRET <pierre-yves.mordret@st.com>,
Alain VOLMAT <alain.volmat@st.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
"moderated list:ARM/STM32 ARCHITECTURE"
<linux-stm32@st-md-mailman.stormreply.com>,
"moderated list:ARM/STM32 ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 5/5] i2c: stm32: remove unnecessary CONFIG_PM_SLEEP
Date: Thu, 29 Oct 2020 12:31:54 +0100 [thread overview]
Message-ID: <699f4908-1ea1-6075-3375-7f1dfc6fb225@st.com> (raw)
In-Reply-To: <20201029074654.227263-5-coiby.xu@gmail.com>
On 10/29/20 8:46 AM, Coiby Xu wrote:
> SET_SYSTEM_SLEEP_PM_OPS has already took good care of CONFIG_PM_CONFIG.
>
> Signed-off-by: Coiby Xu <coiby.xu@gmail.com>
> ---
> drivers/i2c/busses/i2c-stm32f7.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-stm32f7.c b/drivers/i2c/busses/i2c-stm32f7.c
> index f41f51a176a1..95ac9dfdf458 100644
> --- a/drivers/i2c/busses/i2c-stm32f7.c
> +++ b/drivers/i2c/busses/i2c-stm32f7.c
> @@ -2262,7 +2262,6 @@ static int __maybe_unused stm32f7_i2c_runtime_resume(struct device *dev)
> return 0;
> }
>
> -#ifdef CONFIG_PM_SLEEP
Hi Coiby,
This generates warnings when building with W=1 and CONFIG_PM_SLEEP=n.
Could you please add also "__maybe_unused" for relevant routines below ?
> static int stm32f7_i2c_regs_backup(struct stm32f7_i2c_dev *i2c_dev)
^
e.g. insert: __maybe_unused
Best regards,
Fabrice
> {
> int ret;
> @@ -2356,7 +2355,6 @@ static int stm32f7_i2c_resume(struct device *dev)
>
> return 0;
> }
> -#endif
>
> static const struct dev_pm_ops stm32f7_i2c_pm_ops = {
> SET_RUNTIME_PM_OPS(stm32f7_i2c_runtime_suspend,
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-10-29 11:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20201029074654.227263-1-coiby.xu@gmail.com>
2020-10-29 7:46 ` [PATCH 2/5] i2c: mediatek: remove unnecessary CONFIG_PM_SLEEP Coiby Xu
2020-10-29 7:46 ` [PATCH 3/5] i2c: brcmstb: " Coiby Xu
2020-11-04 3:28 ` Florian Fainelli
2020-10-29 7:46 ` [PATCH 4/5] i2c: nomadik: " Coiby Xu
2020-11-05 14:03 ` Linus Walleij
2020-10-29 7:46 ` [PATCH 5/5] i2c: stm32: " Coiby Xu
2020-10-29 11:31 ` Fabrice Gasnier [this message]
2020-10-29 14:18 ` Coiby Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=699f4908-1ea1-6075-3375-7f1dfc6fb225@st.com \
--to=fabrice.gasnier@st.com \
--cc=alain.volmat@st.com \
--cc=alexandre.torgue@st.com \
--cc=coiby.xu@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=pierre-yves.mordret@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox