From: "Helen Mae Koike Fornazier" <helen.koike@collabora.com>
To: "Jai Luthra" <j-luthra@ti.com>
Cc: "Phong LE" <ple@baylibre.com>,
"Neil Armstrong" <neil.armstrong@linaro.org>,
"Andrzej Hajda" <andrzej.hajda@intel.com>,
"Robert Foss" <rfoss@kernel.org>,
"Laurent Pinchart" <Laurent.pinchart@ideasonboard.com>,
"Jonas Karlman" <jonas@kwiboo.se>,
"Jernej Skrabec" <jernej.skrabec@gmail.com>,
"David Airlie" <airlied@gmail.com>,
"Daniel Vetter" <daniel@ffwll.ch>,
"Nicolas Belin" <nbelin@baylibre.com>,
"Andy.Hsieh" <Andy.Hsieh@mediatek.com>,
nm@ti.com, "Aradhya Bhatia" <a-bhatia1@ti.com>,
devarsht@ti.com, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] drm: bridge: it66121: Fix invalid connector dereference
Date: Mon, 28 Aug 2023 16:35:36 +0100 [thread overview]
Message-ID: <6fd4-64ecbf00-7-213b7840@157890373> (raw)
In-Reply-To: <20230825-it66121_edid-v1-1-3ab54923e472@ti.com>
On Friday, August 25, 2023 08:02 -03, Jai Luthra <j-luthra@ti.com> wrote:
> Fix the NULL pointer dereference when no monitor is connected, and the
> sound card is opened from userspace.
>
> Instead return an error as EDID information cannot be provided to
> the sound framework if there is no connector attached.
>
> Fixes: e0fd83dbe924 ("drm: bridge: it66121: Add audio support")
> Reported-by: Nishanth Menon <nm@ti.com>
> Closes: https://lore.kernel.org/all/20230825105849.crhon42qndxqif4i@gondola/
> Signed-off-by: Jai Luthra <j-luthra@ti.com>
Reviewed-by: Helen Koike <helen.koike@collabora.com>
> ---
> drivers/gpu/drm/bridge/ite-it66121.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/gpu/drm/bridge/ite-it66121.c b/drivers/gpu/drm/bridge/ite-it66121.c
> index 466641c77fe9..d6fa00dea464 100644
> --- a/drivers/gpu/drm/bridge/ite-it66121.c
> +++ b/drivers/gpu/drm/bridge/ite-it66121.c
> @@ -1446,6 +1446,11 @@ static int it66121_audio_get_eld(struct device *dev, void *data,
> {
> struct it66121_ctx *ctx = dev_get_drvdata(dev);
>
> + if (!ctx->connector) {
> + dev_dbg(dev, "No connector present, cannot provide EDID data");
> + return -EINVAL;
> + }
> +
> mutex_lock(&ctx->lock);
>
> memcpy(buf, ctx->connector->eld,
>
> ---
> base-commit: 6269320850097903b30be8f07a5c61d9f7592393
> change-id: 20230825-it66121_edid-6ee98517808b
>
> Best regards,
> --
> Jai Luthra <j-luthra@ti.com>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-08-28 15:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-25 11:02 [PATCH] drm: bridge: it66121: Fix invalid connector dereference Jai Luthra
2023-08-28 11:04 ` Aradhya Bhatia
2023-09-01 8:58 ` Jai Luthra
2023-08-28 15:35 ` Helen Mae Koike Fornazier [this message]
2023-08-31 12:25 ` Nishanth Menon
2023-09-01 9:06 ` Jai Luthra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6fd4-64ecbf00-7-213b7840@157890373 \
--to=helen.koike@collabora.com \
--cc=Andy.Hsieh@mediatek.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=a-bhatia1@ti.com \
--cc=airlied@gmail.com \
--cc=andrzej.hajda@intel.com \
--cc=daniel@ffwll.ch \
--cc=devarsht@ti.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=j-luthra@ti.com \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nbelin@baylibre.com \
--cc=neil.armstrong@linaro.org \
--cc=nm@ti.com \
--cc=ple@baylibre.com \
--cc=rfoss@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox